Repository navigation
docs: correct the contributor command descriptions - #534
Open
wufangyong973 wants to merge 1 commit into
Open
wufangyong973 wants to merge 1 commit into
wufangyong973 wants to merge 1 commit into
Conversation
|
@wufangyong973 is attempting to deploy a commit to the electrohyun's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
documentation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
|
@wufangyong973 Thanks for the contribution! The changes look good. Could you run |
This was referenced Oct 1, 2026
wufangyong973
force-pushed
the
docs/contributor-command-descriptions
branch
from
October 2, 2026 06:45
484d8e9 to
4f8b10c
Compare
wufangyong973
force-pushed
the
docs/contributor-command-descriptions
branch
from
October 12, 2026 02:24
4f8b10c to
4970904
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#523
The command tables in CONTRIBUTING.md and CONTRIBUTING.ko.md described
pnpm typecheckas producing no output andpnpm lintas checking documentation style. Neither is accurate:typecheckactually runstsup(the package build) plustscacross the workspace, so it does build packages.lintiseslint .over TypeScript files only (the ESLint config'sfilesis**/*.{ts,mts,cts}), not a documentation style check.Restated the two rows in both guides as "Build packages and check types" / "Lint TypeScript source files" (and the equivalent Korean wording). The commands themselves are unchanged and the table alignment is preserved.
Closes #523.