Skip to content

docs: note Chromium installation before browser verification - #536

Closed
wufangyong973 wants to merge 1 commit into
electrohyun:mainfrom
wufangyong973:docs/chromium-install-note
Closed

wufangyong973 wants to merge 1 commit into
electrohyun:mainfrom
wufangyong973:docs/chromium-install-note

Conversation

@wufangyong973

Copy link
Copy Markdown
Contributor

#522

Both example READMEs offer a browser verification step, but neither said Playwright needs Chromium installed first — CI already does this before running the checks. Added the suggested one-line setup note immediately before the browser verification command block in examples/drawing-game/README.md and examples/shared-worker-lobby/README.md. The Node-only comparison path is left untouched, as the issue notes it does not need Chromium.

Docs-only change.

Closes #522.

@vercel

vercel Bot commented Oct 1, 2026

Copy link
Copy Markdown

@wufangyong973 is attempting to deploy a commit to the electrohyun's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository: electrohyun/smocket/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: c03f9387-61d8-4221-901e-6b1c77287691

  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added documentation Improvements or additions to documentation 📏 xs Pull request changes fewer than 10 lines good first issue Good for newcomers labels Oct 1, 2026
@electrohyun

Copy link
Copy Markdown
Owner

Thank you for the contribution! The changes address the issue as intended.

But, I'd like to keep the remaining good first issues available for other new contributors, so I'll close this PR. I'm happy to merge #534 once you've addressed the review feedback and the required checks pass.

@electrohyun electrohyun closed this Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation good first issue Good for newcomers 📏 xs Pull request changes fewer than 10 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: add Chromium installation to example verification instructions

2 participants