fix: correct the drawing-game Socket.IO version labels - #537
wufangyong973 wants to merge 1 commit into
Conversation
|
@wufangyong973 is attempting to deploy a commit to the electrohyun's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. 鈿欙笍 Run configurationConfiguration used: Repository: electrohyun/smocket/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thank you for the contribution! The changes address the issue as intended. But, I'd like to keep the remaining good first issues available for other new contributors, so I'll close this PR. I'm happy to merge #534 once you've addressed the review feedback and the required checks pass. |
#521
The example pins
socket.ioandsocket.io-clientto4.8.4in itspackage.json, but the observation target key inexamples/drawing-game/observe.tsand both version strings in the README's "Run with Real Socket.IO" section still said4.8.3. Corrected the three version strings to4.8.4.No logic change; the output should now report
socket.io@4.8.4and keepdeeplyEqual: true.Closes #521.