Skip to content

fix: correct the drawing-game Socket.IO version labels - #537

Closed
wufangyong973 wants to merge 1 commit into
electrohyun:mainfrom
wufangyong973:fix/drawing-game-socket-io-versions
Closed

wufangyong973 wants to merge 1 commit into
electrohyun:mainfrom
wufangyong973:fix/drawing-game-socket-io-versions

Conversation

@wufangyong973

Copy link
Copy Markdown
Contributor

#521

The example pins socket.io and socket.io-client to 4.8.4 in its package.json, but the observation target key in examples/drawing-game/observe.ts and both version strings in the README's "Run with Real Socket.IO" section still said 4.8.3. Corrected the three version strings to 4.8.4.

No logic change; the output should now report socket.io@4.8.4 and keep deeplyEqual: true.

Closes #521.

@vercel

vercel Bot commented Oct 1, 2026

Copy link
Copy Markdown

@wufangyong973 is attempting to deploy a commit to the electrohyun's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown

Important

  • 馃攳 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

鈿欙笍 Run configuration

Configuration used: Repository: electrohyun/smocket/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 83350785-f228-484d-b343-375344dd97d0

  • Autopilot 路 Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

鉂わ笍 Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added bug Something isn't working 馃搹 xs Pull request changes fewer than 10 lines good first issue Good for newcomers labels Oct 1, 2026
@electrohyun

Copy link
Copy Markdown
Owner

Thank you for the contribution! The changes address the issue as intended.

But, I'd like to keep the remaining good first issues available for other new contributors, so I'll close this PR. I'm happy to merge #534 once you've addressed the review feedback and the required checks pass.

@electrohyun electrohyun closed this Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working good first issue Good for newcomers 馃搹 xs Pull request changes fewer than 10 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: correct the drawing-game Socket.IO version labels

2 participants