Repository navigation
fix(mobile): name the agent-device session for device-cloud leases - #1513
Merged
Merged
Conversation
agent-device refuses a provider lease to a Node client that names no session (callstack/agent-device#4177). The lease allocate and heartbeat clients, and Limrun's allocate and install, now use a session derived from the lease daemon's stateDir. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Thanks for the PR. It does not meet the contributing guidelines yet:
Edit the PR within 72 hours or it will be closed automatically. If this was flagged by mistake, say so here. |
This was referenced Nov 3, 2026
Closed
kblok
added a commit
to hardkoded/e2e-dotnet
that referenced
this pull request
Nov 3, 2026
* Name the agent-device session of a device-cloud lease (upstream e2e-inc/e2e#1513) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK * Check the Limrun driver created at least one client Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK * Fix whitespace Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
5 tasks done
Akarshkushwaha
pushed a commit
to Akarshkushwaha/e2e
that referenced
this pull request
Nov 10, 2026
The driver put the agent-device session on the lease's client (e2e-inc#1513), a key the mobile engine reserves, so the engine rejected every Limrun lease with ENGINE_FAILURE. The session now stays on the driver's and the heartbeat's own clients and off the client the engine receives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
REMOTE_SESSION_REQUIRED, fix(daemon): refuse leased requests that name no session at admission callstack/agent-device#4177): on a shared daemon, an unnamed client lands on thedefaultsession and can act through another agent's lease.allocateandheartbeatinpackages/mobile/src/lease/, and Limrun'sallocateandapps.installinpackages/limrun/src/driver.ts. Limrun's heartbeat reuses the binding's client.e2e-lease-<8 hex of the lease's stateDir>. One daemon holds one lease, so the name only has to be stable perstateDir. The worker engine still sets its own session over the lease client's (packages/mobile/src/engine.ts).@e2e-dev/mobilegains no public export.Issue
No e2e issue: this prepares for callstack/agent-device#4177, planned for agent-device 0.22.
Verified
Ran it locally: yes
pnpm checkpasses;@e2e-dev/mobileunit tests 484 passed,@e2e-dev/limrun17 passed.stateDir, socket transport,leaseProvider: 'proxy', allocate then heartbeat):Checklist
pnpm changeset) for any change to a published package, or the change is testbed, docs, or CI only.🤖 Generated with Claude Code