Repository navigation
Name the agent-device session of a device-cloud lease - #984
Merged
Merged
Conversation
…nc/e2e#1513) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 43 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
Member
Author
|
@coderabbitai review |
Contributor
Action not completed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer agent-device refuses a provider lease to a client that names no session, so BrowserStack and Limrun leases would fail to allocate or renew. The port's lease requests carried no session at all. Now the lease driver, the lease heartbeat, and the Limrun driver and heartbeat use
e2e-lease-plus the first 8 hex digits of the SHA-256 of the daemon's state directory, and the client sends it assessioninlease.allocate,lease.heartbeat, andlease.release.Upstream change ported: e2e-inc/e2e#1513 (383c0bc):
leaseSessioninmobile/src/lease/session.ts(LeaseSessions.LeaseSession), used bylease/driver.ts(LeaseDriver),lease/heartbeat.ts(LeaseHeartbeat), andlimrun/src/driver.ts(LimrunDriver).Difference from upstream: upstream also puts
sessionin the Limrun binding'sclient. The port cannot, becausesessionis a reserved key there (DeviceBindings).LimrunHeartbeatderives the session again from the binding'sstateDir.Tests:
LeaseDriver,LeaseHeartbeat, andLimrunHeartbeatassertions now check the session. Partial:Partial_Uses_the_requested_app_when_installation_returns_no_identifier(upstreamdriver.test.ts) checks the session the driver's clients are created with, not the binding'sclient.session. The second Limrun heartbeat test now gives its binding astateDir, as the real driver always does..NET-only:
LimrunDriver.LeaseSession(internal copy of the hash;E2E.Limruncannot seeE2E.Mobileinternals, and upstream inlines it there too). No public API change. COMPATIBILITY.md updated. Not checked against a live provider.Closes #976
🤖 Generated with Claude Code
https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK