Repository navigation
fix(limrun): let tests run on Limrun devices again - #1663
Merged
Merged
Conversation
The driver put the agent-device session on the lease's client (#1513), a key the mobile engine reserves, so the engine rejected every Limrun lease with ENGINE_FAILURE. The session now stays on the driver's and the heartbeat's own clients and off the client the engine receives.
Contributor
🟢 e2e android agent: 20 passed24 agent steps · 15 replayed from cache · 47 model calls · 299.3k tokens (78% cached) · $0.0232 All 20 tests in 1 file
Tested by e2e 0.23.0 · 6m 6s · android-emulator · run artifacts |
Contributor
🟢 e2e ios: 55 passed, 1 skippedAll 56 tests in 7 files
Tested by e2e 0.23.0 · 6m 54s · ios-simulator · run artifacts |
Contributor
🟢 e2e android: 57 passed, 1 skippedAll 58 tests in 7 files
Tested by e2e 0.23.0 · 8m 58s · android-emulator · run artifacts |
Contributor
🟢 e2e ios agent: 21 passed, 1 skipped25 agent steps · 12 replayed from cache · 67 model calls · 513.1k tokens (78% cached) · $0.0402 All 22 tests in 1 file
Tested by e2e 0.23.0 · 9m 43s · ios-simulator · run artifacts |
kdy1
approved these changes
Nov 10, 2026
kdy1
left a comment
Collaborator
There was a problem hiding this comment.
I did human review with help of Sonnet 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Every
limrun()lease failed seconds after Limrun created the device, so no test ore2e mcpsession could run on one (@e2e-dev/limrun0.2.4 with@e2e-dev/mobile0.12.6):fix(mobile): name the agent-device session for device-cloud leases #1513 put the agent-device
sessionon the lease'sclient, so the install and heartbeat clients that reuse that object would name one. The mobile engine reserves that key (RESERVED_CLIENT_KEYSinpackages/mobile/src/bindings.ts) and rejects a lease that sets it.The driver now leaves
sessionoff theclientit returns. Its allocate and install clients and the heartbeat add it themselves fromleaseSession(stateDir), the waypackages/mobile/src/lease/does.DriverBinding.clientis typed asDeviceClientConfig, so asessionin that literal no longer compiles.leaseSessionis a local copy of mobile's five lines.@e2e-dev/mobile/leasedoes not export it, and exporting it would raise Limrun's peer floor on mobile.The driver unit test asserted that
sessionwas on the binding. It now asserts the exact client the engine receives, and fails on main.Issue
No e2e issue. This is a regression from #1513, found on 2026-11-10 with the published packages.
Verified
Ran it locally: yes
mobile({ platform: 'ios', device: limrun({ hardTimeout: '15m' }) })withapp: { bundleId: 'com.apple.mobilesafari' }, run withe2e run tests/safari.e2e.ts --video. The test opens Safari, openshttps://example.com, closes Safari's first-launch tip, and expects the page text.main:
this branch:
driver lease renewal failedline. I ran no control without the heartbeat.creating,assigned, orready.appPathinstall on a live device (Safari is preinstalled, so that client is unit-tested only), ande2e mcp(it reaches the same engineprepare).Checklist
pnpm changeset) for any change to a published package, or the change is testbed, docs, or CI only.Written by Claude Fable 5.2 in Claude Code, running in T3 Code.
limrun-ios-after.mp4