Repository navigation
fix(api): return coded 503 when rate limiter fails on keeper health - #1206
Conversation
checkRateLimit was awaited with no try/catch in the health action, so an Upstash failure rejected the handler and surfaced a generic 500 instead of the 503 the other keeper actions and admin routes return when the limiter backend is unavailable. Wrap it in the same try/catch and add a test covering the failure. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@The-Big-Danny Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@The-Big-Danny is attempting to deploy a commit to the Collins' projects Team on Vercel. A member of the Team first needs to authorize it. |
collinsezedike
left a comment
collinsezedike
left a comment
There was a problem hiding this comment.
Thanks for the fix, @The-Big-Danny. The coded 503 now matches the other rate-limited handlers. If you'd like to pick up another open issue, there are several available in the tracker.
|
@The-Big-Danny thank you again for getting this over the line. If you are enjoying working on Meridian, starring the repository helps more contributors find the project and is much appreciated. |
2 participants
checkRateLimit was awaited with no try/catch in the health action, so an Upstash failure rejected the handler and surfaced a generic 500 instead of the 503 the other keeper actions and admin routes return when the limiter backend is unavailable. Wrap it in the same try/catch and add a test covering the failure.
Summary
Test plan
pnpm lint && pnpm typecheck && pnpm testpass locallyCloses #1137