Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions api/__tests__/handlers.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1318,6 +1318,27 @@ describe("GET /api/v1/keepers/health", () => {
lastSuccessMs: null,
});
});

it("returns 503 when the upstream rate limiter fails", async () => {
vi.mocked(checkRateLimit).mockRejectedValueOnce(
new Error("Upstash timeout")
);

const res = makeRes();
await keepersHandler(
fakeReq({
query: { action: "health" },
method: "GET",
headers: {},
}),
res
);

expect(res.statusCode).toBe(503);
expect(res.body).toEqual({
error: "Rate limiter unavailable; refusing to run",
});
});
});

describe("GET /api/v1/admin/vault-state", () => {
Expand Down
9 changes: 8 additions & 1 deletion api/v1/keepers/[action].ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,14 @@ export default async function handler(req: VercelRequest, res: VercelResponse) {

if (action === "health") {
if (applyCors(req, res)) return;
if (!(await checkRateLimit(req, res))) return;
try {
if (!(await checkRateLimit(req, res))) return;
} catch (err) {
console.error("[keepers/health] rate limit check failed:", err);
return res
.status(503)
.json({ error: "Rate limiter unavailable; refusing to run" });
}
const result = await handleGetKeeperHealth();
if (result.error) console.error("[keepers/health] error:", result.error);
res.setHeader("Cache-Control", "no-store");
Expand Down
Loading