Repository navigation
[Bug] Keeper health does not handle a rate-limiter failure #1137
Description
Summary
The keeper health action awaits checkRateLimit with no try/catch, so an Upstash failure rejects the handler and returns a generic 500 instead of the coded 503 JSON that the other keeper actions and every admin route return when the limiter is unavailable.
Tasks
api/v1/keepers/[action].ts:45-47callsif (!(await checkRateLimit(req, res))) return;with no surrounding try/catch.api/v1/keepers/[action].ts:75-82andapi/v1/admin/[resource].ts:16-23show the coded-503 pattern used everywhere else.- Wrap the
healthlimiter call and return the sameRATE_LIMIT_BACKEND_UNAVAILABLEresponse.
Scope
| Field | Value |
|---|---|
| Area | API |
| Protocol affected | None |
| Network | testnet and mainnet |
| Breaking change? | No |
Acceptance Criteria
-
healthreturns the coded 503 JSON when the limiter is unavailable. - A test covers a rate-limiter failure on
health. -
pnpm lint && pnpm typecheck && pnpm testpass.
Additional Context
Found in a repository-wide code audit on 2026-10-18 and re-verified against the source at 66fad4d.
Star the repo
Please star this repository before picking up this issue. It is a small ask that meaningfully helps the project reach more people.
Activity
Hasmong commentedon Oct 18, 2026
@Hasmong has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Hasmong to this issue.
Leemxiey commentedon Oct 18, 2026
@Leemxiey has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Leemxiey to this issue.
The-Big-Danny commentedon Oct 18, 2026
@The-Big-Danny has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @The-Big-Danny to this issue.
drips-wave commentedon Oct 18, 2026
Congratulations, @The-Big-Danny! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.
🧑💻 @The-Big-Danny: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
grantfox-oss commentedon Oct 20, 2026
🎉 This issue has been marked as completed on GrantFox!
@The-Big-Danny's PR #1206 was approved and merged by @collinsezedike.
🏆 @The-Big-Danny: You earned 40 FoxPoints for this contribution! Your current tier: Builder (1,059 total points). Track your full progress on GrantFox.
👏 Great work, @The-Big-Danny! Keep contributing to drydocs.
drips-wave commentedon Oct 20, 2026
This issue has been completed by @The-Big-Danny as part of the Stellar Wave Program's 10th Wave 🥳
😎 @The-Big-Danny: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.