Repository navigation
feat(cosmetics): add EMOTE_PACK cosmetic type with pack validation - #109
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EMOTE_PACKcosmetic type (domain enum and a Postgres enum migration).emote-packs/<slug>/. It holds onepack.jsonand 1 to 12 Lottie files.pack.json(version 1) lists each emote'skey,labelandfile.filemust be<key>.json.<slug>/<key>must fit in 48 bytes.lottie_light(SVG).EMOTE_PACKcannot be equipped throughPUT /me/loadout. Emotes are chosen through the emote bar in the next PRs.PublishCosmetickeeps the 8-file limit for every type exceptEMOTE_PACK.Chain context
This is part of the emote packs feature: emote packs become cosmetics, and each player builds an 8-slot emote bar from the default emotes and the emotes of packs they own. The duel server already relays any emote id up to 48 bytes (diangogav/EDOpro-server-ts#418).
This is a stacked chain into
main. Merge the PRs in order. After each merge, retarget the next PR tomain.main.Size
719 changed lines: 294 production, 425 tests. The maintainer accepted a size exception because the excess over the budget is tests.
Verification
bun test: 683 pass, 0 fail (on the top of the chain).bun run lintandbun run build --noEmitare clean.