Repository navigation
feat(emotes): add public emote bar by username - #113
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /users/by-username/:username/emote-bar. It returns the same shape asGET /me/emote-bar: 8 slots, each{ ref, packId, assetUrl, packUrl, assetsExpiresAt }, with signed URLs for pack emotes./users/by-username/:username/loadout:Cache-Control: private, no-store.GetPublicEmoteBarresolves the username and reusesGetMyEmoteBar, so stale slots fall back to distinct defaults here too.Context
This is part of the emote packs feature. The earlier steps are #109 to #112, plus diangogav/EDOpro-server-ts#418 on the duel server. With this PR the API side is complete. The web client comes next.
Verification
bun test: 687 pass, 0 fail.bun run lintandbun run build --noEmitare clean.