Skip to content

Cleanups - #350

Merged
dfa1 merged 5 commits into
mainfrom
cleanups
Nov 15, 2026
Merged

dfa1 merged 5 commits into
mainfrom
cleanups

Conversation

@dfa1

@dfa1 dfa1 commented Nov 15, 2026

Copy link
Copy Markdown
Owner

What and why

Checklist

See CONTRIBUTING.md for details.

  • Tests use JUnit 5 + AssertJ with @TempDir, and every test follows // Given / // When / // Then
  • ./mvnw test passes
  • ./mvnw package -pl core -am -DskipTests passes (Javadoc fails the build on any error or warning)
  • New native bindings: private static final MH_ fields, each with its /// `<c prototype>` comment from c.h
  • CHANGELOG.md has a line under ## [Unreleased] linking this PR (and the issue, if any), ending with — thanks [@your-handle](https://github.com/your-handle) if you're an external contributor
  • Docs updated in the matching Diátaxis page (tutorial / how-to / reference / explanation), snippets compile against core

@dfa1 dfa1 mentioned this pull request Nov 15, 2026
5 of 6 tasks
…b/libc

malloc is a libc symbol that librocksdb does not export on Windows, so it
resolves through the platform's default lookup via NativeLibrary.libc.
NativeLibrary.lookup is renamed to rocksdb for symmetry.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The MethodType is derived from the FunctionDescriptor, so each callback host
drops its static block, MethodType declarations and try/catch. Also includes
the in-progress MergeOperator change (scratch buffer instead of malloc).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@dfa1
dfa1 merged commit f5ec742 into main Nov 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant