Repository navigation
Conversation
…h NativeLibrary Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…t on Windows Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Owner
Author
|
superseded by #350 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Tidies the handle declarations in
NativeCalls:MH_CLOSEandMH_FREEare initialized inline; thestaticblock is gone.MH_FREEbecomesprivate(nothing outsideNativeCallsused it).SIZE_Tmoves above the handles, sinceMH_MALLOC's descriptor uses it.MH_MALLOCstays on the linker's default lookup. The first commit moved it toNativeLibrary.lookup, and the Windows build failed withUnsatisfiedLinkError: Symbol not found: malloc: a library lookup on Windows sees only the RocksDB DLL's own exports. The second commit restores the default lookup and records why in a comment.Checklist
NativeCallsTestandRocksIteratorTestpass locally on macOS; the full suite runs in CI./mvnw package -pl core -am -DskipTestspassesMH_field keeps its prototype commentCHANGELOG.md: left for the maintainer🤖 Generated with Claude Code