Repository navigation
Drop C malloc entirely; rename NativeLibrary.rocksdb back to downcall - #351
Merged
Merged
Conversation
RocksIterator's size_t out-param is now a heap long[1], passed through critical(true) key/value downcalls (pure Slice accessors). That removes the last malloc user, so NativeCalls.malloc and NativeLibrary.libc go. Documents the no-libc rule in AGENTS.md, CONTRIBUTING.md and ADR 0007. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RocksIterator'ssize_t*length out-param is now a heaplong[1], passed throughcritical(true)rocksdb_iter_key/_valuedowncalls. Both only read the current entry'sSlice(db/c.cc), so they can't block. That removes the lastmallocuser, soNativeCalls.mallocandNativeLibrary.libcare deleted.NativeLibrary.rocksdbis renamed back toNativeLibrary.downcalland now has javadoc.AGENTS.mdandCONTRIBUTING.md. ADR 0007 notes that the iterator's critical calls are an exception made to dropmalloc, not a speed claim.Follows #350, which already moved
MergeOperatoroffmalloc(a no-opdelete_valuehook plus a per-thread scratch buffer).🤖 Generated with Claude Code