Repository navigation
omamobile-modem-sit 0.3.43: a call left ringing doesn't hold back the internet bearer's reconnect - #825
Merged
Conversation
… internet bearer's reconnect The reconnect (0.3.42) waits while a call is live, and nothing ends a ringing-in call the modem never reports ended (the 9a's missed-call phantom, #729), so one such ring would have kept mobile data down after a bearer drop until a reboot. A ring older than two minutes no longer counts: the network gives up on an unanswered call well within that. Found by review round 58 (#759 with #817). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#817's reconnect waits while a call is live. Nothing on main ends a
ringing-incall the modem never reports ended (the 9a's missed-call phantom, #729), so a single phantom ring would hold mobile data down after a bearer drop until a reboot. A ring older than two minutes no longer holds it back (the network gives up on an unanswered call well within that); active, held, dialing and fresh ringing calls still do. Two new tests;test/allpasses. Found in review round 58.Version: 0.3.43. #754 and #759 claimed 0.3.43/0.3.44; they take the next numbers at merge.
🤖 Generated with Claude Code