Repository navigation
Conversation
…up by hand A user set up during bring-up has none of the setup's once-only markers, so the login service never runs, and running the script would reseed shell.json and repeat every step. --adopt marks each once-only step done without running it; the per-login parts still run.
… repeat The first version marked every once-only step, so a hand-set-up user also lost the steps that check their files first, such as Chromium's no-first-run and mobile flags: on the palmtop Chromium opened on its terms-of-service page. Only the shell profile, the monitor scale, the appended cursor and keyboard lines and the screensaver files are skipped now.
|
A correction from real use. The first
The test now builds a user who owns each of those files and checks that |
|
Thanks, and good catch on Chromium. Marking only the steps that would overwrite or repeat something is the right fix, and the new test covers exactly that case. I ran A few notes, none of them a big change:
The version conflicts with main (now 0.2.66). Leave it: I'll set the next free number at merge, in the title too. |
|
The palmtop re-run, today: It printed nothing and exited 0. On what the other steps change, I looked at the palmtop's
So on this palmtop the run matches what a new user gets. You're right that "check first" in the script's comment overstates it for those few steps. I'll leave the rewording to your merge along with the README row, unless you'd rather I push it. |
Files opens folders with a single tap. omamobile-setup-user sets org.gnome.nautilus.preferences click-policy to single once, behind its own omamobile-files-single-tap marker, so someone who goes back to double-click keeps that. It first checks that the key exists (gsettings list-keys) and does nothing, and sets no marker, if it doesn't. test/setup-user.sh covers both cases. Checked on the Pixel 8 Pro: Nautilus 51.1 has the key with the range 'single' 'double'. Maintainer edits at merge: the test file's conflict with #259 resolved (both cases kept), and the key probe uses grep -c under pipefail. Closes #271 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Landed on main as 3a247cb (squashed, authored by you). My review notes from before the merge, for the record: Thanks for the re-run, and for being upfront that it had nothing left to mark because the 12:19 run had already done the work. That's fine: that earlier run is the one that wrote Chromium's flags, so it shows what this version does. Your read of the palmtop's I'll merge it now. At merge I'll reword the README row and the script's comment as we discussed, so they say which steps are marked and which of the others change what's there. I'll also write the squash message from your second commit and set the version, which stays 0.2.67. |
…up by hand (derekross#259) `omamobile-setup-user --adopt` is for a user set up by hand rather than by firstboot. It marks done, without running them, only the once-only steps that would overwrite or repeat what that user already has: the shell profile, the monitor scale, the appended cursor and keyboard lines and the screensaver files. The other steps run as for a new user: missing phone plugins and an idle block go into shell.json, the suspend and lock toggles are set, and Chromium's flags are written. After that the setup service can run at each login. Without --adopt nothing changes. Tested on the palmtop; test/setup-user.sh covers the adopted case. Closes derekross#259 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…oss#271) Files opens folders with a single tap. omamobile-setup-user sets org.gnome.nautilus.preferences click-policy to single once, behind its own omamobile-files-single-tap marker, so someone who goes back to double-click keeps that. It first checks that the key exists (gsettings list-keys) and does nothing, and sets no marker, if it doesn't. test/setup-user.sh covers both cases. Checked on the Pixel 8 Pro: Nautilus 51.1 has the key with the range 'single' 'double'. Maintainer edits at merge: the test file's conflict with derekross#259 resolved (both cases kept), and the key probe uses grep -c under pipefail. Closes derekross#271 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
As agreed on #243:
omamobile-setup-user --adopt, for a user set up by hand rather than by firstboot.The problem. Such a user has none of the setup's once-only markers, so
omamobile-setup-user.serviceis skipped at every login: its condition is theomamobile-shell-profilemarker. Running the script by hand would copy the package'sshell.jsonover the user's and repeat every other once-only step, appending the cursor and keyboard lines to the Hyprland files again and reseeding the scale.The change. With
--adopt,omarchy-done ensurebecomes a check-and-mark: each once-only step is marked done and not run, and the script prints what it adopted. The parts that run at every login still run: the plugin links, the keyboard layouts and theme, and the menu entries kept current. A step the user does want can be had later by removing its marker before a login. The README row says so.Tests. A new case in
test/setup-user.shbuilds a hand-set-up home with no markers, its ownshell.jsonand a looknfeel with a cursor line.--adoptleaves those files byte-identical, marks the once-only steps, links the plugins and reports what it marked, and a normal login run afterwards changes nothing. The test's fakeomarchy-donelearnedcheck.test/allpasses.On the palmtop (the user from #243, set up during bring-up,
omamobile-shell0.2.62 installed, this script run from/tmp): first a backup of the user's config to/root. Then--adoptmarked 46 steps, andshell.json, the Hyprland files andfoot.inihashed the same before and after. With the profile marker in place,systemctl --user start omamobile-setup-userthen ran for the first time on that phone ("inactive (dead) since …", no longer "condition unmet"). The user's files were still unchanged, and all 12 plugin links point at the package.Version 0.2.67: main is at 0.2.64, and #217 and #124 are waiting on 0.2.65 and 0.2.66, so set whatever is free at merge.
tools/pr-checkpasses.