Repository navigation
Conversation
|
Thank you, this is a clean port: the 7 Pro's four files exactly (I checked the blobs), a test that fails if they drift, the generator run for a charger boot, a normal boot and the opt-out, and a phone run that covers the dark panel, Power held and the slot counts. The package test passes on today's main with this merged, and nothing on the 7 Pro changes. The part I need to decide before merging is the one you flagged yourself. On the published kernel panther has no I see two ways, and I'd like your view:
I lean towards the first, since a phone that looks off but isn't is the kind of surprise I'd rather not ship. Either way, a |
9c1c0bf to
092a3a7
Compare
|
Thank you. I agree with the first way: a phone that looks off but isn't shouldn't ship. The charger should load on the Pixel 7. It has charged through the upstream driver on my phone since 2026-11-01, with the Pixel 7 Pro's options. So rather than a blacklist, I've added that setup to this pull request, as two commits on top of the charger-mode one:
The kernel side is linux-omarchy-mobile#259: The 🤖 Generated with Claude Code |
|
The
Nothing in the build changes this pull request's files. The kernel is my test kernel with linux-omarchy-mobile#259's node, #181 and its 90 Hz commits. On that boot the charger loaded with The one new dmesg line, "cma: Failed to reserve 384 MiB", comes at 0.000000, before any module or package file is read. The two boots before this one, with the old package, have it too. So it comes from my test kernel's memory layout, not from this package. The tool's package list is left out; it showed device-panther 0.1.17.1. 🤖 Generated with Claude Code |
|
My decision on the gap: the charger node goes into the kernel first. As it stands, a Pixel 7 that's powered off on its cable and then unplugged stays running with its panel dark until someone holds Power, because panther's published board file has no So please open the kernel PR with the MAX77759's charger cell for panther (as on the 7 Pro), and in this package blacklist the charger driver before that node lands, as akita's 0.1.4 does. Once the node is in a published kernel, a run of this PR on it (powered off on the cable, unplugged, the phone powering off by itself) makes this ready, and I'll merge it. |
|
Thank you, Alejandro, for the kernel PR, the plan with your B3 to D1 results, and the smoke report. I owe you a correction first: my decision this afternoon asked for the charger driver to be blacklisted as on the 8a, and I hadn't taken in your reply from the morning when I posted it. You're right, and I'd rather go your way: a blacklisted charger means no Three things before this can go in:
For that last run, your phone has a local 0.1.17.1, which sorts above what I'll publish, so please install the package built from this branch with |
092a3a7 to
aeee023
Compare
|
Thank you, and no need to apologise: your first decision was right for the board file as it is. Done:
For the last run I'll install the package built from this branch with 🤖 Generated with Claude Code |
|
Thank you, Alejandro. All three points are done: the lint line went with the policy into #827 and CI is green on both, the split is exactly what I asked for, and neither branch carries a version. I've asked on #827 for its version and suggested that the BATTERY-PLAN commit travel with it, so the files cite gates that are on main; if you move it, this one becomes the off-mode commit alone. From here it's the order we agreed: #827 first, then linux-omarchy-mobile#259 once the package is published, then this one rebased onto #827, with your run on a published kernel that has the node, and I'll give you the version number then. |
aeee023 to
f54bb55
Compare
…hone on its cable A Pixel 7 powered off on its cable is started by its bootloader with androidboot.mode = "charger", where stock runs only a charging screen. We started the whole phone. The Pixel 7 Pro's off-mode charging (derekross#554, landed in derekross#730), copied byte for byte: omamobile-charger-mode-generator makes omamobile-charger.target the default of such a boot, and omamobile-charger-mode turns the panel off, restarts into the phone on Power held for a second, and powers off five seconds after the cable is out. The test checks the copies against the cheetah package, runs the generator on a charger boot, a normal boot and with charger-mode-disable, and checks that the target keeps SSH over USB and starts nothing of the phone. python joins depends. The power off on an unplug reads the charger's online, which needs the MAX77759 charger in the device tree (linux-omarchy-mobile#259). Without it the phone stays in the dark charging boot until Power is held. Tested on a Pixel 7 from slot B, on a kernel that describes the charger: a power off on the cable went to the charger boot, the panel went dark and SSH over USB came up; Power held restarted into the phone; a second charger boot powered off once the cable was out. Neither charger boot spent a slot B try. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- The Pixel 9a, not the Pixel 9 Pro, for device/tegu/SLEEP-PLAN.md. - The status line: the kernel releases since kernel-2026.11.13 carry linux-omarchy-mobile#233, so the upower drop-in waits only for off-mode charging (derekross#788). P7's last takeaway names derekross#730, which carried derekross#554's commits. - The standby numbers in the status line each with their condition: Wi-Fi kept at 2028 and at 1014 MHz, Wi-Fi unloaded at 1014 MHz. - Z2k's boot: only stock recovery came up, not Android. - DISPLAY-PLAN D5 and the NOTES entries, which come with the 90 Hz pull request, say so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
f54bb55 to
723acc2
Compare
|
Rebased onto main with #827 in. The conflicts were the two lines both touched: As you noted on #827, two lines said the package starts nothing of the charger.
🤖 Generated with Claude Code |
|
Thank you, Alejandro. The rebase is exactly right: one commit, the two lines both pull requests touched resolved as you describe, and Nothing more is needed from you on this one for now. Where it stands in the order: #827 is merged as device-panther 0.1.17, and I'm waiting for that package to show up in the published repository before I merge linux-omarchy-mobile#259. Then a kernel release with the node, then your run on it, installed with On the version: this will be 0.1.18, unless another Pixel 7 pull request takes that number first. I'll tell you which when I'm ready to merge, and it goes onto the branch before the squash. |
The Pixel 7 Pro's off-mode charging (#554, which landed in #730), on the Pixel 7. A Pixel 7 powered off on its cable is started by its bootloader with
androidboot.mode = "charger", where stock runs only a charging screen, and we started the whole phone. Now that boot charges with the panel dark.What it adds (no version bump; the number is yours at the merge):
omamobile-charger-mode,omamobile-charger-mode-generator,omamobile-charger.serviceandomamobile-charger.target.installstages them, with the generator executable, and enables nothing: only the generator uses the target, on a charger boot.pythonadded todepends.charger-mode-disable. Then it checks that the target keeps SSH over USB and starts nothing of the phone. The script's own behavior stays tested in the cheetah package.The charger's policy came first as #827, merged as device-panther 0.1.17: the Pixel 7 Pro's two modprobe files, so the charger loads with
default_ilim_uaandtemp_guard, and the BATTERY-PLAN commit with gates B3 to D1 and their results. This pull request is the off-mode commit alone, rebased onto it.install's header and the test's last line now say that the charger driver loads under that policy and that the charger target comes only from its generator.The power off once the cable is out reads
max77759-charger/online, which needs the MAX77759's PMIC in the device tree: linux-omarchy-mobile#259. Without that node the phone stays in the dark charging boot until Power is held. Next is linux-omarchy-mobile#259, then this one, with a run on a published kernel that has the node.Tested on a Pixel 7 from slot B, on a 7.3.0-rc6 kernel built from
omamobile82f31d3a7 with my local panther changes, including linux-omarchy-mobile#259's node, and with the two modprobe files. The four files on the phone had the same hashes as this branch's.omamobile-charger.target. The service logged "panel off: 1c2c0000.dsi.0" and then "charging; hold Power to start the phone, battery 98% Charging".graphical.targetwith the screen right.The second charger boot's battery line read "99% Discharging" on the cable, near full, like the first "Discharging" line seen on the 7 Pro. The unplug check uses the charger's
online, which read 1.Checks:
packages/omamobile-device-panther/test/all,tests/grep-q-pipesandtools/pr-checkpass.🤖 Generated with Claude Code