Repository navigation
Conversation
…oss#261) omamobile-setup-user sets org.gnome.nautilus.preferences click-policy to single once, behind its own omamobile-files-single-tap marker, so someone who goes back to double-click keeps that. The step first checks that gsettings list-keys has click-policy and does nothing (no marker either) if it doesn't, so a Nautilus that drops the key can't break the login setup. test/setup-user.sh: set once over three logins; nothing set and no marker when the fake gsettings has no click-policy. test/setup-user.sh passes here; test/all stops earlier on this desktop (no python dbus for call-watch). Checked on a Pixel 8 Pro (Nautilus 51.1-1): the key exists with range 'single' 'double'; the step itself has not run there. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Lef <me@lefteros.com>
Somnius
force-pushed
the
husky-files-single-tap
branch
from
November 1, 2026 20:02
b311832 to
6ac9332
Compare
Owner
|
Landed on main as 6cec0e5 (squashed, authored by you). My review notes from before the merge, for the record: Thanks, this is exactly what I asked for in #261: once only behind its own marker, the key checked first, no marker when the key isn't there, and test cases for both. I ran Two small things, both mine to do at merge:
With #259 and #268 ahead of it, this one keeps 0.2.69. Once it's in, I'll close #261. |
robertzas
pushed a commit
to robertzas/omarchy-mobile
that referenced
this pull request
Nov 14, 2026
…oss#271) Files opens folders with a single tap. omamobile-setup-user sets org.gnome.nautilus.preferences click-policy to single once, behind its own omamobile-files-single-tap marker, so someone who goes back to double-click keeps that. It first checks that the key exists (gsettings list-keys) and does nothing, and sets no marker, if it doesn't. test/setup-user.sh covers both cases. Checked on the Pixel 8 Pro: Nautilus 51.1 has the key with the range 'single' 'double'. Maintainer edits at merge: the test file's conflict with derekross#259 resolved (both cases kept), and the key probe uses grep -c under pipefail. Closes derekross#271 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kdegeek
added a commit
to kdegeek/omarchy-mobile-fork
that referenced
this pull request
Nov 18, 2026
linux-omarchy-mobile#273 now enables comet's USB the Pixel 9a's way, on a plain snps,dwc3 node, and derekross#271's zumapro glue is closed: a cold boot of derekross#273's DT bound 11210000.usb to dwc3 directly and the host configured the gadget, with no glue module. The shared kernel config builds dwc3 in, so dwc3-zumapro leaves the initramfs module list and device/comet/kernel.config, which only selected the glue, goes. BRINGUP-M1 and the package README now name derekross#273 as the one kernel dependency. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@derekross here's the small PR from #261.
omamobile-setup-usernow setsorg.gnome.nautilus.preferences click-policytosingle, once, behind its ownomamobile-files-single-tapmarker. Someone who goes back to double-click keeps that. The step first checksgsettings list-keys org.gnome.nautilus.preferencesforclick-policyand does nothing if the key isn't there, so a Nautilus that drops it won't break the login setup. The marker isn't set in that case either.test/setup-user.shgot a case for it: set once over three logins, and nothing set (no marker) when the fake gsettings has noclick-policy.Tested:
test/setup-user.shpasses here.test/allstops earlier on my desktop (no python dbus for call-watch, and the qmlformat check), before it gets to setup-user.sh, so that's not run through the whole suite. On my 8 Pro (Nautilus 51.1-1)gsettings list-keyshasclick-policyand its range is'single' 'double'(I read it over ssh just now), and my desktop's schema has the same. Not run on the phone itself yet: I had setclick-policy singleby hand there already, so the step would just be marked done. It only takes effect for new setups.Version: #259 has 0.2.67 and #268 has 0.2.68 open, so I took 0.2.69 as a placeholder. Feel free to renumber it when you merge, as you did with the others.