Skip to content

device-panther 0.1.4: display brightness, and the display plan - #258

Closed
nesmeck wants to merge 2 commits into
derekross:mainfrom
nesmeck:panther-display
Closed

nesmeck wants to merge 2 commits into
derekross:mainfrom
nesmeck:panther-display

Conversation

@nesmeck

@nesmeck nesmeck commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

What and why

Brightness for the Pixel 7. The kernel side is derekross/linux-omarchy-mobile#177: the S6E3FC3 panel driver and the DSI command path in panther's board file. This PR brings the rest:

  1. DISPLAY-PLAN (panther), and the panel driver in the kernel config.
    • The plan: what is known about the S6E3FC3 P10 panel and ABL's display pipeline, the changes, and the gates. G1 (the new omamobile base alone), D1 (the DSI command path, read-only) and D2 (brightness and display off/on over DCS) passed on the phone, and their results are recorded.
    • Following your note on device-panther 0.1.3: USB comes back after a replug, and the battery plan #247, every gate has a Rollback line.
    • kernel/configs/omamobile.config gets CONFIG_DRM_PANEL_SAMSUNG_S6E3FC3=m. It binds only to samsung,s6e3fc3-p10, which only panther's board file has.
    • The Pixel 7 row's display cell names brightness and links the plan and DEVICES: the matrix as of 2026-10-30 #177.
  2. device-panther 0.1.4: display brightness. modprobe.d/omamobile-display.conf sets options gs_dsim_cmd allow_tx=1, as the Pixel 7 Pro's package does, so the panel driver can send brightness and display off/on. screen_off comes with gs-decon, in D3.

Device and build

Checks (no phone needed)

  • tools/pr-check upstream/main passes
  • tests/all passes
  • tests/packages passes
  • Each changed package has its version bumped, and the new version is in the commit subject
  • Commits have area prefixes and bodies that say why; any AI help is a Co-Authored-By: trailer, never a Signed-off-by:

On the phone

  • I ran this on my own phone, booted into this build.
  • Runbook steps passed:
    • G1: pass. The new thermal zones read 44-52 °C, no cooling device was active, and cpufreq showed three policies on schedutil.
    • D1: pass. The panel was taken over with the screen unchanged.
    • D2: pass. Brightness 1023, 400, 2047 and 4, then display off and back on with the picture intact, and the shell's slider drove the panel.
    • 0.1.4 was built and installed on the phone (database step as in issue Contributor phones: pacman -U fails when [omamobile] is signed with a local key #168), and modprobe -c lists the option.
  • What I did not test:
    • 0.1.4 setting allow_tx at boot. The phone hasn't rebooted since the install, because slot B is at its last retry. I'll check it at the next boot and add the result.
    • HBM, the panel's cold init (that's D3) and 90 Hz.
  • Nothing in this change writes outside slot B and userdata, weakens the storage guard, or reads registers from userspace.

The new kernel brings one warning, cpu cpuN: EM: invalid perf. state: -22 on the three clusters. It comes from omamobile's new gs201 CPU DVFS: G1 already had it, without this branch.

tools/phone-smoke report

phone-smoke: panther

Kernel 7.3.0-rc6-omamobile-push1-g54fb87ae5295, tools at 19805f0, 2026-11-01T15:59Z.

Check Result Detail
boot (required) ok kernel 7.3.0-rc6-omamobile-push1-g54fb87ae5295, slot b, up 4054s
storage guard (required) ok 55 partitions; only userdata and slot B's boot images writable
root (required) ok ext4 on userdata, 97G free
kernel health (required) ok no oops or BUG; 0 WARN, 9 error lines in dmesg
systemd units ok none failed
USB gadget (required) ok bound to 11210000.usb
display ok card0-Unknown-1 connected, 1080x2400
GPU ok render node on panthor
session (required) ok Hyprland and the Omarchy shell running
lock ok PAM file present, the shell can lock (passwordPam true, locked false)
touch ok FocalTech FT3658
buttons ok gpio-keys
Wi-Fi skip no wireless interface
Bluetooth skip no controller
battery ok 92% Charging, 31 °C
sound cards skip none
sensors skip no sensor proxy
cameras skip no libcamera tools
thermal ok hottest zone 44 °C

Packages: hyprland 0.56.2-5.1, libcamera 0.7.2-4.21, mesa 1:26.2.4-1.4, omacam 0.3.3-1, omamobile-apps 0.2.0-1, omamobile-device-panther 0.1.4-1, omamobile-firstboot 0.1.2-1, omamobile-keyring 20261026-1, omamobile-mirror 0.1.1-1, omamobile-omarchy 0.1.12-1, omamobile-owl-widgets 0.1.1-1, omamobile-shell 0.2.28-1, omarchy 4.0.6-1, quickshell 0.3.2.r7.g2b4501a-1

🤖 Generated with Claude Code

@derekross

Copy link
Copy Markdown
Owner

Thank you, this is a lovely step for the Pixel 7: brightness and display off/on from the shell's slider, with a plan that has a Pass, a Stop and a Rollback for every gate, and results recorded with their kernel release. Thanks also for listing exactly what you didn't test.

What I checked: tools/pr-check is clean and the package's test/all passes at your head. 0.1.4 follows main's 0.1.3. The new modprobe.d file sets only allow_tx=1, the same option the Pixel 7 Pro's package sets, and CONFIG_DRM_PANEL_SAMSUNG_S6E3FC3 exists only in kernel #177, as a module that binds only to samsung,s6e3fc3-p10. Nothing changes for the other phones.

Before it lands:

  1. Merge order. The config line names an option that only exists in linux-omarchy-mobile#177, so this merges right after DEVICES: the matrix as of 2026-10-30 #177.
  2. A conflict in docs/DEVICES.md. The Pixel 7 row changed on main after you branched (DEVICES: the Pixel 8 Pro's and Pixel 7's touch merged, louder speakers on the 7 Pro #254 updated the touch cell), so the row conflicts. Only the display cell is yours, so the fix is to take main's row and put your display cell back in. I can do that when I merge, or you can rebase, whichever you prefer.
  3. The boot from the package. I'll take the result you promised after the next boot. Please also check one thing then: ls /etc/modprobe.d. If an omamobile-display.conf from your hand-testing is still there, it hides the package's file of the same name, and modprobe -c would show the option either way. With that gone, cat /sys/module/gs_dsim_cmd/parameters/allow_tx reading Y after the boot, plus the slider still working, is all I need.

One practical note: you mention slot B is at its last retry. Please don't spend that last try on this check. Instead, bin/omamobile flash the image set you're running now. That gives slot B three tries again and boots it, and the boot it does is the check. The package is already on userdata, so nothing else needs reinstalling.

Not blocking: the Pixel 7 Pro BOE-panel PR (#262) adds its option on the same line of omamobile.config, so whichever of the two lands second gets a one-line conflict. I'll handle it.

Thanks again. Once #177 is in and the boot result is posted, I'll merge.

nesmeck and others added 2 commits November 1, 2026 12:29
…ernel config

The plan for the Pixel 7's display: what is known about its S6E3FC3 P10
panel and ABL's pipeline, the changes (a panel driver and the DSI command
path in panther's device tree, then gs-decon with 1080x2400 modes), and
the gates. G1 (the new omamobile base), D1 (the DSI command path,
read-only) and D2 (brightness and display off/on over DCS) passed on the
phone; their results are recorded. The Pixel 7 row's display cell
names brightness and links the plan and linux-omarchy-mobile#177.

kernel/configs/omamobile.config builds the panel driver as a module. It
binds only to its compatible, which only panther's board file has.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ship a modprobe.d file that sets gs_dsim_cmd's allow_tx, so the panel
driver can send the panel its brightness (DCS 0x51) and display off/on,
as the Pixel 7 Pro's package does. The DSI command driver ships with
sending off; on the Pixel 7, DISPLAY-PLAN gate D2 proved brightness at
four levels, display off and back on, and the shell's slider.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@nesmeck

nesmeck commented Nov 1, 2026

Copy link
Copy Markdown
Contributor Author

Thanks! I've rebased onto main. In docs/DEVICES.md I took main's Pixel 7 row and put back only the display cell. I also fixed the panel supplies in DISPLAY-PLAN (vci on LDO27M, vddi on S2MPG13 BUCKA, as you pointed out on #177). tools/pr-check is clean.

The boot from the package: it ran on a fastboot flash, so it didn't spend the last retry. That was the first gs-decon test boot (7.3.0-rc6-omamobile-push1-gdc3f0ce5e425), with 0.1.4 installed:

  • allow_tx read Y with no hand-written option;
  • the shell's slider changed the brightness.

The phone has booted from the package several times since, always with allow_tx reading Y. On today's boot:

  • ls /etc/modprobe.d lists only hid_apple.conf, so no hand-made omamobile-display.conf hides the package's file;
  • cat /sys/module/gs_dsim_cmd/parameters/allow_tx reads Y.

Agreed on the merge order: this one goes right after #177.

🤖 Generated with Claude Code

@derekross

Copy link
Copy Markdown
Owner

Thank you, that's everything I asked for: the rebase kept main's Pixel 7 row and changed only your display cell, the supplies are corrected, and the boot from the package shows allow_tx reading Y with nothing in /etc/modprobe.d to hide the package's file. Thanks too for booting it from a flash rather than spending the last try. tools/pr-check is clean and CI is green on the new head.

Two things, neither for this PR to wait on:

  1. The plan. The status line still says the package's first boot is still to come, and the results stop at the modprobe -c check. Since you've allowed edits, I'll add the boot you posted as a dated result (kernel release, allow_tx, the slider, the ls /etc/modprobe.d check) and update the status line when I merge.
  2. D3. You mention the boot was your first gs-decon test boot. What ran at that boot: was gs_decon loaded, and did it take the screen over from simpledrm? The plan says D3 gets its own runbook before it starts, with a Rollback for each stage, so please post that runbook (a PR to the plan is fine) before the next gs-decon boot. If gs-decon did take over, I'd also like to see that boot's dmesg | grep -i decon lines there.

I'll merge right after linux-omarchy-mobile#177, and handle the one-line conflict with the BOE-panel PR (#262) in the config fragment, whichever lands first. Thanks again, this is a really nice step for the Pixel 7.

@derekross derekross closed this in d984c52 Nov 1, 2026
@derekross

Copy link
Copy Markdown
Owner

Landed on main as d984c52 (squashed, authored by you), with the package boot you posted recorded in DISPLAY-PLAN. Thanks, @nesmeck. Kernel #177 is merged too.

robertzas pushed a commit to robertzas/omarchy-mobile that referenced this pull request Nov 14, 2026
…ross#258)

The Pixel 7's display brightness and off/on from the shell's slider.
device-panther 0.1.4 ships a modprobe.d file setting the DSI command
path's allow_tx=1, as the Pixel 7 Pro's package does, and the shared
config fragment builds the S6E3FC3 panel driver
(CONFIG_DRM_PANEL_SAMSUNG_S6E3FC3=m, linux-omarchy-mobile#177), which
binds only to samsung,s6e3fc3-p10. DISPLAY-PLAN gets gated steps with a
Pass, a Stop and a Rollback each, and the results with their kernel
release. DEVICES' Pixel 7 display cell is updated.

Maintainer edit at merge: DISPLAY-PLAN records the package boot posted on
the PR (allow_tx reads Y, /etc/modprobe.d clean).

Closes derekross#258

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
W4HO-ham added a commit to W4HO-ham/omarchy-mobile that referenced this pull request Nov 15, 2026
…outside the rule; where data was checked

The plan now says plainly that the 2026-11-13 and 11-14 sleeps with the modem up ran outside the rule in AGENTS.md, with their start times, and that the rule stands until the maintainer decides otherwise. For the night and the package runs it says where mobile data was checked (at the end, with Wi-Fi the first route), adds the night's count of "Reserve doorbell interrupt" and "PCI not powered on" lines (1,205 and 1,142, with data answering at the end; the daily kernel logs the same line awake with no sleep), and lists a run in the shape that lost data on the 7 Pro under what is left. The AGENTS sentence takes the maintainer's wording, so it doesn't go stale now that derekross#258 has merged.

The series script checks data 5 s after every wake (a ping and a DNS query sent out of the bearer's interface), takes WIFI=off for runs with the bearer as the only route, refuses to start and stops when the palmtop isn't charging, and counts the doorbell lines at the end.
derekross pushed a commit that referenced this pull request Nov 18, 2026
… up on a test kernel with the sleep guard (2026-11-13 to 11-15)

This records the 9a's sleeps with the modem up on test kernels with linux-omarchy-mobile#232 and the zumapro sleep guard (#258): a refusal no longer costs the phone service, 299 of 300 sleeps in one boot were entered and woke with the modem registered, calls and texts wake the sleeping palmtop, and a cable-out night ended with mobile data down while the bearer was reported up. The runs of 11-13 to 11-15 were outside AGENTS' rule for modem-up sleep, as the section says with their start times; from 2026-11-15 the owner's palmtop runs these under #809, whose terms the plan quotes. It adds `device/tegu/bringup/modem-sleep-series.sh` (data over the bearer after every wake, `WIFI=off`, N 10 by default, stops off the charger, on the CP not ONLINE, and on a UFS error line or an oops in dmesg) and one sentence in AGENTS.md's modem-up entry.
W4HO-ham added a commit to W4HO-ham/omarchy-mobile that referenced this pull request Nov 18, 2026
…ell to works (opt-in), with the runs on the published branch

The cell's old condition was a fix for the third no-wake and a series from the published kernel as it is. Kernel derekross#247 is merged, and on derek/omamobile at 26867fc4e (derekross#224, derekross#232, derekross#247, derekross#258) 300 of 300 sleeps with a 60 s alarm woke with the modem off on the night of 2026-11-17: 296 on the alarm and 4 within seconds on the touchscreen's interrupt with nobody at the palmtop. On 2026-11-16, 86 of 86 sleeps entered with the modem up woke, each ended by the modem within 29 s, so none of those reached its alarm.

From the review of derekross#846: the word is "works (opt-in)", since auto-sleep ships off on the 9a (omamobile-device-tegu doesn't install /usr/share/omamobile/auto-sleep-default); the cell says again that a new sleep test runs attended first and that the modem's inhibitor stays, the owner's palmtop under derekross#809 excepted; and it cites merged notes, not derekross#758's comments.

MODEM-PLAN gains the 2026-11-16 section: the runs on the test kernel and on the published branch under derekross#809's terms, the route finding that became derekross#837, and the palmtop hanging awake twice at a power-up of the modem's link (once between the sleeps of a series, once in everyday use with Wi-Fi connected), with the NV check after each. The Modem cell names those hangs. SLEEP-PLAN's S1 table gains a row for the 86 modem-up sleeps and one for the night's 300, and its status line is brought up to date.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants