Repository navigation
gs201-panther: the S6E3FC3 panel and the DSI command path, for brightness - #177
Conversation
|
I rebased this onto today's
kernel-pr-check passes on the new head:
The next step is ready locally: 🤖 Generated with Claude Code |
3a0f596 to
9f3b8c0
Compare
|
Thank you, @nesmeck. This is a clean port. I checked it against Google's Two small things before I merge:
One more thing that I'd like fixed before the gs-decon step, here or in that PR. The commit says the driver follows our S6E3HC4 driver, but it follows an older version of it. Today's I'll merge this together with omarchy-mobile#258. Thanks again, and I'm looking forward to the gs-decon step. |
The S6E3FC3 is a Samsung Mobile Display DDIC; the P10 panel is its 1080x2400 command-mode AMOLED panel in the Google Pixel 7. Its compatible string is the one the Pixel 7's own device tree uses. Assisted-by: Claude Opus 5.5 Signed-off-by: Alejandro Garcia <skipper.pelygro@gmail.com>
Add a driver for the Samsung S6E3FC3 DDIC and its P10 1080x2400 AMOLED panel, found in the Google Pixel 7 (panther). The command sequences come from Google's GPL panel driver (panel-samsung-s6e3fc3-p10.c), limited to the EVT1 and later panels that ship in phones: the cold init table at 60 Hz, TE2, DSC enable with the vendor PPS sent as is, MIC off, and display on/off. Local HBM, the low-power (AOD) modes and the panel revision reads are left out. The bootloader powers the panel and leaves it scanning out. When the reset line reads released at probe the driver takes the panel over without sending anything, holding the supplies and keeping the reset line where it is; only brightness and power changes reach the panel. Brightness is a backlight device over DCS 0x51 (11 bits, the normal range; HBM is left for later), with levels below the vendor driver's lowest (4) raised to it, and blanking the backlight turns the display off while keeping the panel out of sleep. The driver follows the Pixel 7 Pro's S6E3HC4 driver in this tree. Tested on a Pixel 7 from slot B (7.3.0-rc6), with the next patch: the driver takes the panel over from the bootloader without changing the picture. With the DSIM command path sending, brightness 1023, 400, 2047 and 4 each changed the screen as expected, blanking the backlight turned the display off and unblanking turned it back on with the picture intact, and the desktop's brightness slider drove the panel. No DSIM errors. Assisted-by: Claude Opus 5.5 Signed-off-by: Alejandro Garcia <skipper.pelygro@gmail.com>
…o the panel Enable the DPU and DISP clock controllers and DSIM0, and describe the panel on it: the Samsung S6E3FC3 P10 with its reset on gpa7-1, as in the Pixel 7's live device tree. The bootloader leaves DECON0, DSIM0 and the panel running in command mode, and simplefb keeps scanning out its buffer; the DSIM command driver and the panel driver take the link and the panel over without sending anything, so that brightness and display on/off can go over DCS. DECON0 stays disabled. The panel's supplies, vci on S2MPG12 LDO27 and vddi on S2MPG13 BUCKA (Google's gs201-panther-display.dtsi and the live tree), have no driver yet and are left as the bootloader set them. Tested on a Pixel 7 from slot B (7.3.0-rc6): DSIM0 and the panel bind, the panel is taken over from the bootloader, the screen stays as it was on simplefb, and the backlight device appears. Brightness and display off/on over DCS then work (see the panel driver's commit). Assisted-by: Claude Opus 5.5 Signed-off-by: Alejandro Garcia <skipper.pelygro@gmail.com>
9f3b8c0 to
6248800
Compare
|
Thanks for the careful check against Google's driver.
The new head ( 🤖 Generated with Claude Code |
|
Thank you, @nesmeck. Both points are in: the comment and the commit message now name LDO27M and BUCKA, as Google's tree does, and the smoke report is in the description. The range-diff shows the binding and driver unchanged. I've re-run our gate on today's Putting the handed-over panel's state at the start of the gs-decon series is fine with me. That's the PR where Merged; omarchy-mobile#258 goes in right after it. Thanks again. I'm looking forward to seeing the Pixel 7's screen driven by gs-decon. |
Brightness and display off/on for the Pixel 7, as the Pixel 7 Pro has them: a driver for its panel, the Samsung S6E3FC3 "P10", and the DSI command path in panther's board file. DECON0 stays disabled, so simplefb keeps scanning out.
gs-deconfor panther's 1080x2400 panel is a later step.samsung,s6e3fc3-p10. This is the compatible string the Pixel 7's own device tree uses for the panel under DSIM0. I'm listed in the binding'smaintainers:and, as with the FT3658, not in MAINTAINERS. That's the reason for checkpatch's two "does MAINTAINERS need updating?" warnings.panel-samsung-s6e3fc3-p10.c(kernel/google-modules/display/samsung,panel/, branchandroid-gs-pantah-6.1-android16), limited to the EVT1 and later panels that ship in phones.cmu_disp,cmu_dpuanddsi0, with the panel on reset gpa7-1, as in the live tree. The supplies, vci on S2MPG12 LDO27 and vddi on S2MPG13 BUCKA (Google'sgs201-panther-display.dtsi), have no driver yet and stay as ABL leaves them.Tested on a Pixel 7 (slot B,
7.3.0-rc6-omamobile-push1-g54fb87ae5295: today'somamobilewith #133, #171, #170 and this branch). One change per boot: the boot before it ran the same tree without this branch.gs_dsim_cmd allow_tx=0):/sys/class/backlight/1c2c0000.dsi.0appears;gs_dsim_rates[](UNDERRUN_CTRL 0x1cf8), sogs-dsim-cmdlogs "no rate switching" and stays at 60 Hz, as intended.allow_tx=1on the running kernel:bl_power4 turned the display off, and 0 turned it back on with the picture intact and touch working;dmesg.omamobile-device-panther0.1.4 shipsoptions gs_dsim_cmd allow_tx=1, in derekross/omarchy-mobile#258.Checks:
tools/kernel-pr-check --build OUT --merge origin/omamobilepasses everything:dt_binding_checkon the new binding;tools/phone-smokefrom the D1/D2 boot (…-g54fb87ae5295)phone-smoke: panther
Kernel
7.3.0-rc6-omamobile-push1-g54fb87ae5295, tools at19805f0, 2026-11-01T15:59Z.Packages: hyprland 0.56.2-5.1, libcamera 0.7.2-4.21, mesa 1:26.2.4-1.4, omacam 0.3.3-1, omamobile-apps 0.2.0-1, omamobile-device-panther 0.1.4-1, omamobile-firstboot 0.1.2-1, omamobile-keyring 20261026-1, omamobile-mirror 0.1.1-1, omamobile-omarchy 0.1.12-1, omamobile-owl-widgets 0.1.1-1, omamobile-shell 0.2.28-1, omarchy 4.0.6-1, quickshell 0.3.2.r7.g2b4501a-1
🤖 Generated with Claude Code