Skip to content

omamobile.config: enable the BOE NT37290 panel driver - #262

Closed
haudamekki wants to merge 1 commit into
derekross:mainfrom
haudamekki:boe-panel-config
Closed

haudamekki wants to merge 1 commit into
derekross:mainfrom
haudamekki:boe-panel-config

Conversation

@haudamekki

Copy link
Copy Markdown

Companion to derekross/linux-omarchy-mobile#174 (merged together per review point 6): adds CONFIG_DRM_PANEL_BOE_NT37290=m to kernel/configs/omamobile.config, right next to CONFIG_DRM_PANEL_SAMSUNG_S6E3HC4=m, so the release kernel carries the driver for BOE-variant Pixel 7 Pro units.

The driver binds only to its boe,nt37290 compatible and, at probe, additionally requires the bootloader's exynos_drm.panel_name= to name it (or the DT to name it explicitly). Samsung-panel reference devices are unaffected.

Signed-off-by: Adrian Schupp as@satware.com
Assisted-by: LLM opencode

The BOE-variant Pixel 7 Pro panel (the ABL names it on the kernel
command line as boe-nt37290): port of google-modules/display's
panel-boe-nt37290.c in linux-omarchy-mobile. Binds only to its
compatible; the Samsung driver covers the sdc-s6e3hc4 reference
devices.

Signed-off-by: Adrian Schupp <as@satware.com>
Assisted-by: LLM opencode
@derekross

Copy link
Copy Markdown
Owner

Thank you, Adrian. This is the right place for the option: one line in the shared fragment, as a module that binds only to its own compatible, so the release kernel carries it for every BOE-panel Pixel 7 Pro. tools/pr-check is clean and it applies to today's main without conflict.

Two things:

  1. The comment cites a private tracker. "internal/omamobile issue adri/omamobile#9" doesn't mean anything to someone reading the public config. Please point at the public issue and the kernel PR instead, for example:

    # The BOE-variant Pixel 7 Pro panel (panel_name=boe-nt37290 via ABL);
    # port of Google's GPL panel-boe-nt37290.c (google-modules/display),
    # omarchy-mobile#215 and linux-omarchy-mobile#174. Binds only to its
    # compatible; the Samsung driver above covers the sdc-s6e3hc4 panels.
    

    I'm glad to make that edit myself if you prefer.

  2. Merge order. CONFIG_DRM_PANEL_BOE_NT37290 exists only in linux-omarchy-mobile#174 for now. Until that's merged the fragment would name an option the kernel doesn't have, which olddefconfig drops with nothing more than a warning in the build log. So this one merges right after device/cheetah, AGENTS: the charger at Full, and slot B needing its AVB footers #174, as you planned.

A heads-up: the Pixel 7's panel PR (#258) adds its own panel option on the same line of this file, right after CONFIG_DRM_PANEL_SAMSUNG_S6E3HC4=m. Whichever lands second gets a one-line conflict, and I'll resolve it when merging.

Thanks again for chasing the BOE corruption down to the panel.

@haudamekki

Copy link
Copy Markdown
Author

Please go ahead with the comment edit - your wording is exactly right, and that saves a force-push round trip.

Understood on the merge order too: this one lands right after linux-omarchy-mobile#174. And thanks for the heads-up on the Pixel 7 PR (#258) touching the same line.

@derekross

Copy link
Copy Markdown
Owner

Thanks, Adrian. I'll make the edit when I merge, right after linux-omarchy-mobile#174. One small change from the wording I suggested: since the Pixel 7's panel option will sit next to it, "the Samsung driver above" becomes "DRM_PANEL_SAMSUNG_S6E3HC4 covers the sdc-s6e3hc4 panels", so it can't be read as the wrong Samsung driver. Nothing else for you to do.

@derekross derekross closed this in d43957b Nov 1, 2026
@derekross

Copy link
Copy Markdown
Owner

Landed on main as d43957b (squashed, authored by you), after kernel #174, with the comment pointing at #215 and kernel #174 and saying the driver binds when ABL names boe-nt37290. I checked it on my Samsung-panel 7 Pro first: the Samsung driver keeps the panel and the BOE one steps aside. Thanks, Adrian.

robertzas pushed a commit to robertzas/omarchy-mobile that referenced this pull request Nov 14, 2026
Builds the BOE NT37290 panel driver (linux-omarchy-mobile#174) as a
module in the shared fragment, so the release kernel carries it for every
Pixel 7 Pro with the BOE panel (omarchy-mobile#215). The driver binds when
ABL names boe-nt37290 and steps aside otherwise; checked on a Samsung-panel
Pixel 7 Pro, where panel-samsung-s6e3hc4 keeps the panel.

Maintainer edit at merge: the config comment cites the public issue and
kernel PR instead of a private tracker.

Closes derekross#262

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants