Repository navigation
Conversation
|
Heads-up: #193 just merged as omamobile-shell 0.2.52, so this will need the next free version when it lands. |
c4ea91b to
ef03da5
Compare
|
Rebased onto today's main (0.2.56) and moved to 0.2.57, including the interop plan's mention. The change itself is the same. |
|
Second commit, same version: a deliberate quit no longer counts either. |
|
Thanks for this. Losing three good widgets to a run of kernel pushes is exactly the false positive the guard shouldn't produce, and the clean-quit handler is a nice find. The code reads well: an old file without a boot id keeps the strict behaviour, and the writes stay atomic. One design question before it merges. With the boot-id rule, a widget that brings down the whole phone (say a GPU fault that ends in a watchdog reset) is no longer held back: it loads again at every boot, where before the guard caught it after the first reset. If quickshell quits cleanly on the SIGTERM it gets when the session is torn down for a reboot, your Main is at omamobile-shell 0.2.62 (0.2.63 is about to be taken by voice), so I'll set the next free version myself at merge, including the mention in the interop plan. |
…ts one retry, and the quit hook that runs Review of derekross#217. A widget still loading from another boot now loads once more as a suspect and is held back if it is still loading at the next start, so a widget that takes the whole system down is still stopped after its second reset. Quickshell 0.3 never delivers Qt.application's aboutToQuit to QML and dies on SIGTERM without tearing down, so the deliberate-quit hook is Home's Component.onDestruction, which quickshell kill runs. test/widget-guard runs the real guard block in Quickshell across starts and boots.
e7b5843 to
67d9280
Compare
|
I checked, and quickshell doesn't quit cleanly on SIGTERM. Worse, my
So the session teardown at a reboot is unclean, and the boot-id rule really is what covers ordinary reboots. The quit hook is now Home's I took the suspect idea. An entry from another boot loads once more and goes under There's a new |
|
|
…ts one retry, and the quit hook that runs Review of derekross#217. A widget still loading from another boot now loads once more as a suspect and is held back if it is still loading at the next start, so a widget that takes the whole system down is still stopped after its second reset. Quickshell 0.3 never delivers Qt.application's aboutToQuit to QML and dies on SIGTERM without tearing down, so the deliberate-quit hook is Home's Component.onDestruction, which quickshell kill runs. test/widget-guard runs the real guard block in Quickshell across starts and boots.
61abffd to
992bc9b
Compare
|
Thank you, this is a careful answer to my question. The table showing that Quickshell dies on SIGTERM without
Nothing more is needed from you. On my side before I merge:
|
The crash guard records each user widget in widget-guard.json while it loads, and an entry still there at the next start marked the widget as having crashed the shell. A reboot, a shutdown or a dead battery during the first seconds of the home screen left those entries behind too, so after a few kernel pushes on the Pixel 9a three widgets were switched off with "This widget crashed the shell" although their code was fine. The guard file now carries the boot id it was written in. At start, entries still loading from another boot are dropped with their own log line; entries from the same boot are still a shell death and are held back as before. The package test checks the three pieces, and the interop plan's crash-guard section says so.
…oading list omarchy-restart-shell stops the shell with quickshell kill, a clean quit, and widgets still loading at that moment were marked as having crashed the shell at the next start: on the Pixel 9a, two restarts in a row switched off all four user widgets. A clean quit emits aboutToQuit and a crash never does, so the guard now clears what was loading on its way out.
…ts one retry, and the quit hook that runs Review of derekross#217. A widget still loading from another boot now loads once more as a suspect and is held back if it is still loading at the next start, so a widget that takes the whole system down is still stopped after its second reset. Quickshell 0.3 never delivers Qt.application's aboutToQuit to QML and dies on SIGTERM without tearing down, so the deliberate-quit hook is Home's Component.onDestruction, which quickshell kill runs. test/widget-guard runs the real guard block in Quickshell across starts and boots.
…y when there is none Over an SSH login on the palmtop there was no XDG_RUNTIME_DIR, and Quickshell crashed at start because it could not create its instance directory.
992bc9b to
ad914f3
Compare
|
Merged as 7ea8ab5, renumbered to omamobile-shell 0.2.66 (0.2.63-0.2.65 went to the voice and keyboard releases and the 8 Pro's panel row). On my Pixel 7 Pro: a reboot and three shell restarts, one shell each time, home widgets back, and |
…ith one retry for a suspect (derekross#217) A reboot while home widgets load is no longer taken for a widget crash: the guard file carries the boot id it was written in, a widget left loading in an earlier boot counts once as a suspect and is retried, and only a second failure keeps it off, so a widget that crashes the shell at every boot still gets caught. test/widget-guard runs the real guard block from Home.qml (W4HO-ham). Renumbered to 0.2.66 at merge. Checked on the Pixel 7 Pro on 2026-11-01: a reboot and three shell restarts, one shell each time, and the guard file kept no crashed or suspect widgets. Closes derekross#217 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The home screen's crash guard writes each user widget into
widget-guard.jsonwhile it loads, and an entry still there at the next start meant the shell had died with that widget, so the widget was switched off with "This widget crashed the shell, so it's off". A reboot during the home screen's first seconds leaves the same entries behind. On the palmtop, four kernel pushes in a row this morning switched off three widgets whose code was fine (checked withomamobile-widget check, no QML error anywhere in the journal).The guard file now carries the boot id (
/proc/sys/kernel/random/boot_id) it was written in. Entries still loading from another boot are dropped with their own log line ("was loading when the system went down last boot; not a crash"); entries from the same boot are a shell death and are held back exactly as before. The package test checks the three pieces, and the interop plan's crash-guard section (§2.7) records the rule.Tested:
packages/omamobile-shell/test/allpasses here. On the palmtop the same change was applied to the installed 0.2.41'sHome.qmlby hand and the shell restarted: the guard file gained the boot id and the three widgets load again; a hand edit, so the next package upgrade replaces it with this.