Repository navigation
Conversation
|
Thanks, @W4HO-ham. Icons that grow with the cell make sense, and your 9a numbers check out: about 63 px at 8/3 as before, 84 px at scale 2. The shell is shared, though, so this changes the Pixel 7 Pro's home screen too, and our rule for shared code means I'll look at it on my phone before it merges. Taking the 7 Pro's cells from our home-screen render (120x148 upright at 4x6, 173x82 on its side at 6x4):
The half-height limit is stricter than the layout needs. The icon's bottom sits at the middle of the cell plus 18% of its width, so its top stays inside the cell up to about 0.61 of the height, and the name still fits underneath at 0.6 for any cell taller than about 61 px. Would you try On the version: one of my own branches already uses 0.2.36. Keep yours; I'll move mine up. This has to merge after #117 (0.2.35) so that the versions land in order. It merges cleanly with my touch batch 5 (#123), which also edits |
|
Done: |
563f2dd to
e438c8e
Compare
|
Thanks, @W4HO-ham, that's exactly the formula, and the commit message now gives the numbers for both phones. I re-checked them: on the 7 Pro, 74 px upright (120x148 cells) and 49 px on its side (173x82). With 8 rows upright it's now 67 px rather than 64, so nothing shrinks there any more. On the 9a upright the width still sets the size (about 63 px at 8/3), so your earlier run on the palmtop still shows what this version draws. The package tests pass here, also merged with #99, #115, #117 and my touch batch (#123), which also edits What's left is on my side and in the order:
One small thing for the description, when you next touch it: CONTRIBUTING asks for a |
Review: the device tree and the RT9470 module moved to the kernel bring-up branch (derekross/linux-omarchy-mobile#127). This leaves the plan with what the setup builds on, the dead-man and curated autostart explained, a runbook with the unbind and reset-without-shutdown measurements for derekross#124, and the early RT9470 read as a one-boot unit.
|
Merged tonight's main, version to 0.2.51. Only the version conflicted; this branch is independent of my other shell PRs and still touches just AppTile.qml. Nothing dropped: your 0.2.44 and 0.2.45 changed the home screen elsewhere, not the icon size. pr-check passes and all 238 package checks pass. |
|
I tried this on my Pixel 7 Pro (on top of main and #193): the icons grow from 64 to about 74 px there, and Chromium's icon goes visibly soft, because the icon the shell gets is apparently a smaller size scaled up. Our rule for shared shell changes is that the 7 Pro stays as it is unless there's a 7 Pro reason, so could you keep the 64 px cap where it applies today and lift it only for the cases you need: the 9a's scale, scale 2, or the 3-column grid? For example, cap at 64 logical px unless the cell is wider than some threshold. I'll look into the soft icons separately, since they'll matter whenever icons are drawn larger. |
bb6c699 to
4c1390c
Compare
|
Done as you suggested. Up to a 128 px cell the icon is exactly the old expression, For reference, the 9a at its scale of 2.667 has about 101 px cells in the 4-column grid, so it's unchanged too. Only a 3-column grid (about 135 px) lifts the cap there. I rebuilt the branch on today's main as one commit, at 0.2.58 (0.2.57 is #217's). |
4c1390c to
99d0c1a
Compare
|
Thanks for reworking this the way I suggested. Keeping the old expression word for word for narrow cells makes the portrait 7 Pro easy to check, and the two new test lines are a good idea. I worked through the numbers once more and found one case that still changes on the 7 Pro, and it's my fault for suggesting a plain threshold. Turned on its side, the 7 Pro's home cells are wider than 128 px but short (about 82 px high). Today they get Could you make the wide branch take the larger of the two, so it can only grow? width: tile.width > 128
? Math.max(Math.min(64, Math.max(40, Math.min(tile.width, tile.height) * 0.62)),
Math.min(tile.width * 0.62, tile.height * 0.6))
: Math.min(64, Math.max(40, Math.min(tile.width, tile.height) * 0.62))Then portrait 7 Pro and the 9a's 4-column grid stay exactly as they are, landscape stays at 51 px, and scale 2 and the 3-column grid still get the bigger icon. A test line for the Two housekeeping things:
Once that's in, I'll run it on my 7 Pro upright and on its side before I merge. |
A home-screen icon is capped at 64 px. In a cell wider than 128 px (scale 2, or the 3-column grid) it now takes the cell's 62 %, limited by the cell's height; narrower cells, the 7 Pro's and the 9a's default grids among them, keep the old size exactly.
99d0c1a to
01b3929
Compare
|
Thanks for the rebase. The latest push only changes the version, so the two things from my last comment are still open:
If it's easier, I can make the formula change myself when I merge (the branch allows maintainer edits). Just tell me which you prefer. Main is now at 0.2.66 (#217 took it), so the version conflicts again, but leave that: I'll set the next free number and the title at merge. After that I'll check the home screen on my 7 Pro, upright and on its side, and merge. |
…d the cell-following size On its side the 7 Pro's cells are wider than 128 px but about 82 px high, so the cell-following size alone dropped its icon from 51 to 49 px. Taking the larger of the two means the change only ever grows an icon. A test line keeps the Math.max form.
|
Done in 944f6a3: the wide branch is your |
|
Landed on main as 15d6b24 (squashed, authored by you), after I checked it on my 7 Pro: the icons keep their sizes upright and on its side. Thank you. |
Home-screen app icons were capped at 64 px, so at scale 2 or on a 3-column grid they sat small in big cells. Up to a 128 px cell the icon is exactly as before (62 % of the cell, 40-64 px). In a wider cell it takes the larger of that and the cell-following size (62 % of the width, at most 60 % of the height, so the name still fits), so it can only grow. Checked on the Pixel 7 Pro upright and on its side: the icons keep their sizes. test/all has a line for the Math.max form. Maintainer edit at merge: version 0.2.72 (main moved on). Closes derekross#124 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Home-screen app icons were capped at 64 px, so at scale 2 or on a 3-column grid they sat small in big cells. Up to a 128 px cell the icon is exactly as before (62 % of the cell, 40-64 px). In a wider cell it takes the larger of that and the cell-following size (62 % of the width, at most 60 % of the height, so the name still fits), so it can only grow: the 7 Pro upright and on its side and the 9a's 4-column grid keep their sizes, and scale 2 and the 3-column grid get the bigger icon.
test/all(with a line for theMath.maxform) andtools/pr-checkpass. The 9a ran the earlier version of this change on its 4-column grid, where the formula gives the same size.