Skip to content

omamobile-shell 0.2.66: home icons follow a wide cell - #124

Closed
W4HO-ham wants to merge 3 commits into
derekross:mainfrom
W4HO-ham:shell-home-icon-size
Closed

W4HO-ham wants to merge 3 commits into
derekross:mainfrom
W4HO-ham:shell-home-icon-size

Conversation

@W4HO-ham

@W4HO-ham W4HO-ham commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Home-screen app icons were capped at 64 px, so at scale 2 or on a 3-column grid they sat small in big cells. Up to a 128 px cell the icon is exactly as before (62 % of the cell, 40-64 px). In a wider cell it takes the larger of that and the cell-following size (62 % of the width, at most 60 % of the height, so the name still fits), so it can only grow: the 7 Pro upright and on its side and the 9a's 4-column grid keep their sizes, and scale 2 and the 3-column grid get the bigger icon.

test/all (with a line for the Math.max form) and tools/pr-check pass. The 9a ran the earlier version of this change on its 4-column grid, where the formula gives the same size.

@derekross

Copy link
Copy Markdown
Owner

Thanks, @W4HO-ham. Icons that grow with the cell make sense, and your 9a numbers check out: about 63 px at 8/3 as before, 84 px at scale 2.

The shell is shared, though, so this changes the Pixel 7 Pro's home screen too, and our rule for shared code means I'll look at it on my phone before it merges. Taking the 7 Pro's cells from our home-screen render (120x148 upright at 4x6, 173x82 on its side at 6x4):

  • upright, the icons go from 64 to 74 px. That's fine: your reason holds on the 7 Pro too;
  • on its side, they shrink from 51 to 41 px, because half of an 82 px cell is the limit. The same happens upright with 8 rows (64 to 56).

The half-height limit is stricter than the layout needs. The icon's bottom sits at the middle of the cell plus 18% of its width, so its top stays inside the cell up to about 0.61 of the height, and the name still fits underneath at 0.6 for any cell taller than about 61 px. Would you try Math.max(40, Math.min(tile.width * 0.62, tile.height * 0.6))? On the 7 Pro that gives 74 px upright, as yours does, and 49 px on its side, close to today's 51. On the 9a nothing changes.

On the version: one of my own branches already uses 0.2.36. Keep yours; I'll move mine up. This has to merge after #117 (0.2.35) so that the versions land in order. It merges cleanly with my touch batch 5 (#123), which also edits AppTile.qml (the "Not installed" label).

derekross added a commit that referenced this pull request Oct 28, 2026
…ry work

Open PRs hold device-cheetah 0.1.35 (#102) and omamobile-shell 0.2.33
to 0.2.36 (#99, #115, #117, #124); this branch takes the next free ones.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
derekross added a commit that referenced this pull request Oct 28, 2026
0.2.33 to 0.2.37 are held by #99, #115, #117, #124 and the low-battery
branch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
derekross added a commit that referenced this pull request Oct 28, 2026
…ry work

Open PRs hold device-cheetah 0.1.35 (#102) and omamobile-shell 0.2.33
to 0.2.36 (#99, #115, #117, #124); this branch takes the next free ones.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@W4HO-ham

Copy link
Copy Markdown
Contributor Author

Done: Math.max(40, Math.min(tile.width * 0.62, tile.height * 0.6)), amended into the one commit. On the 9a it's the same 63 px at 8/3 (84 px at scale 2), and by your numbers the 7 Pro gets 74 px upright and 49 px on its side. test/all passes. Fine to merge after #117.

@W4HO-ham
W4HO-ham force-pushed the shell-home-icon-size branch from 563f2dd to e438c8e Compare October 28, 2026 19:01
@derekross

Copy link
Copy Markdown
Owner

Thanks, @W4HO-ham, that's exactly the formula, and the commit message now gives the numbers for both phones. I re-checked them: on the 7 Pro, 74 px upright (120x148 cells) and 49 px on its side (173x82). With 8 rows upright it's now 67 px rather than 64, so nothing shrinks there any more. On the 9a upright the width still sets the size (about 63 px at 8/3), so your earlier run on the palmtop still shows what this version draws. The package tests pass here, also merged with #99, #115, #117 and my touch batch (#123), which also edits AppTile.qml, and the two don't touch the same lines.

What's left is on my side and in the order:

One small thing for the description, when you next touch it: CONTRIBUTING asks for a tools/phone-smoke report from the phone a package change runs on, with uname -r. A report from the 9a running this 0.2.36, plus a line saying you looked at the home screen upright and on its side, would complete it.

W4HO-ham added a commit to W4HO-ham/omarchy-mobile that referenced this pull request Oct 29, 2026
Review: the device tree and the RT9470 module moved to the kernel bring-up branch (derekross/linux-omarchy-mobile#127). This leaves the plan with what the setup builds on, the dead-man and curated autostart explained, a runbook with the unbind and reset-without-shutdown measurements for derekross#124, and the early RT9470 read as a one-boot unit.
@W4HO-ham

Copy link
Copy Markdown
Contributor Author

Merged tonight's main, version to 0.2.51. Only the version conflicted; this branch is independent of my other shell PRs and still touches just AppTile.qml. Nothing dropped: your 0.2.44 and 0.2.45 changed the home screen elsewhere, not the icon size. pr-check passes and all 238 package checks pass.

@derekross

Copy link
Copy Markdown
Owner

I tried this on my Pixel 7 Pro (on top of main and #193): the icons grow from 64 to about 74 px there, and Chromium's icon goes visibly soft, because the icon the shell gets is apparently a smaller size scaled up. Our rule for shared shell changes is that the 7 Pro stays as it is unless there's a 7 Pro reason, so could you keep the 64 px cap where it applies today and lift it only for the cases you need: the 9a's scale, scale 2, or the 3-column grid? For example, cap at 64 logical px unless the cell is wider than some threshold. I'll look into the soft icons separately, since they'll matter whenever icons are drawn larger.

@W4HO-ham
W4HO-ham force-pushed the shell-home-icon-size branch from bb6c699 to 4c1390c Compare November 1, 2026 00:23
@W4HO-ham W4HO-ham changed the title omamobile-shell 0.2.36: home icons follow the cell size omamobile-shell 0.2.58: home icons follow a wide cell Nov 1, 2026
@W4HO-ham

W4HO-ham commented Nov 1, 2026

Copy link
Copy Markdown
Contributor Author

Done as you suggested. Up to a 128 px cell the icon is exactly the old expression, Math.min(64, Math.max(40, Math.min(tile.width, tile.height) * 0.62)), so the 7 Pro's about 120 px cells stay at 64. Above 128 px, which means scale 2 or the 3-column grid, the icon takes the cell's 62 % with no cap, limited by the cell's height so the name still fits.

For reference, the 9a at its scale of 2.667 has about 101 px cells in the 4-column grid, so it's unchanged too. Only a 3-column grid (about 135 px) lifts the cap there.

I rebuilt the branch on today's main as one commit, at 0.2.58 (0.2.57 is #217's). test/all gains two checks, one for the unchanged narrow path and one for the wide one, and it passes along with tools/pr-check.

@W4HO-ham W4HO-ham changed the title omamobile-shell 0.2.58: home icons follow a wide cell omamobile-shell 0.2.65: home icons follow a wide cell Nov 1, 2026
@W4HO-ham
W4HO-ham force-pushed the shell-home-icon-size branch from 4c1390c to 99d0c1a Compare November 1, 2026 15:23
@derekross

Copy link
Copy Markdown
Owner

Thanks for reworking this the way I suggested. Keeping the old expression word for word for narrow cells makes the portrait 7 Pro easy to check, and the two new test lines are a good idea.

I worked through the numbers once more and found one case that still changes on the 7 Pro, and it's my fault for suggesting a plain threshold. Turned on its side, the 7 Pro's home cells are wider than 128 px but short (about 82 px high). Today they get min(64, max(40, 82 * 0.62)), about 51 px. With the wide branch they get max(40, min(w * 0.62, 82 * 0.6)), about 49 px. So in landscape the icons shrink a little, and a change that's meant only to let icons grow shouldn't shrink anything.

Could you make the wide branch take the larger of the two, so it can only grow?

width: tile.width > 128
       ? Math.max(Math.min(64, Math.max(40, Math.min(tile.width, tile.height) * 0.62)),
                  Math.min(tile.width * 0.62, tile.height * 0.6))
       : Math.min(64, Math.max(40, Math.min(tile.width, tile.height) * 0.62))

Then portrait 7 Pro and the 9a's 4-column grid stay exactly as they are, landscape stays at 51 px, and scale 2 and the 3-column grid still get the bigger icon. A test line for the Math.max( form would keep it that way.

Two housekeeping things:

  • The branch conflicts with main again, only in version. Main is at omamobile-shell 0.2.62, voice takes 0.2.63, and omamobile-shell 0.2.65: a reboot while widgets load is not a crash, with one retry #217 is lined up for the next one, so please rebase and put any version in. I'll set the next free number at merge, in the title too.
  • The description still has the 0.2.36 smoke report and the old "drops the fixed cap" summary. A two-line update saying what the change is now would help anyone reading the merged commit.

Once that's in, I'll run it on my 7 Pro upright and on its side before I merge.

A home-screen icon is capped at 64 px. In a cell wider than 128 px (scale 2, or the 3-column grid) it now takes the cell's 62 %, limited by the cell's height; narrower cells, the 7 Pro's and the 9a's default grids among them, keep the old size exactly.
@W4HO-ham
W4HO-ham force-pushed the shell-home-icon-size branch from 99d0c1a to 01b3929 Compare November 1, 2026 16:26
@W4HO-ham W4HO-ham changed the title omamobile-shell 0.2.65: home icons follow a wide cell omamobile-shell 0.2.66: home icons follow a wide cell Nov 1, 2026
@derekross

Copy link
Copy Markdown
Owner

Thanks for the rebase. The latest push only changes the version, so the two things from my last comment are still open:

  • the wide branch taking the larger of the two sizes, so the 7 Pro on its side keeps its 51 px icon instead of dropping to 49 px (the Math.max(...) form in my last comment, plus a test line for it);
  • a short update to the description: it still describes the 0.2.36 "drops the fixed cap" version and its smoke report.

If it's easier, I can make the formula change myself when I merge (the branch allows maintainer edits). Just tell me which you prefer. Main is now at 0.2.66 (#217 took it), so the version conflicts again, but leave that: I'll set the next free number and the title at merge. After that I'll check the home screen on my 7 Pro, upright and on its side, and merge.

…d the cell-following size

On its side the 7 Pro's cells are wider than 128 px but about 82 px high, so the cell-following size alone dropped its icon from 51 to 49 px. Taking the larger of the two means the change only ever grows an icon. A test line keeps the Math.max form.
@W4HO-ham

W4HO-ham commented Nov 1, 2026

Copy link
Copy Markdown
Contributor Author

Done in 944f6a3: the wide branch is your Math.max(...) form, with a test line for it, and the description now says what the change is. I'll leave the version and title to you at merge, as you said.

@derekross derekross closed this in 15d6b24 Nov 2, 2026
@derekross

Copy link
Copy Markdown
Owner

Landed on main as 15d6b24 (squashed, authored by you), after I checked it on my 7 Pro: the icons keep their sizes upright and on its side. Thank you.

robertzas pushed a commit to robertzas/omarchy-mobile that referenced this pull request Nov 14, 2026
Home-screen app icons were capped at 64 px, so at scale 2 or on a
3-column grid they sat small in big cells. Up to a 128 px cell the icon
is exactly as before (62 % of the cell, 40-64 px). In a wider cell it
takes the larger of that and the cell-following size (62 % of the width,
at most 60 % of the height, so the name still fits), so it can only
grow. Checked on the Pixel 7 Pro upright and on its side: the icons keep
their sizes. test/all has a line for the Math.max form.

Maintainer edit at merge: version 0.2.72 (main moved on).

Closes derekross#124

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants