Repository navigation
Conversation
This was referenced Oct 27, 2026
W4HO-ham
force-pushed
the
tegu-hsi1-clocks
branch
from
October 27, 2026 16:31
88f6888 to
ccf544a
Compare
Owner
|
HSI1 checks out against the CAL (the TOP branch at 0x10a4/0x20cc/0x189c, the user muxes, the local NoC mux, the ALT divider from its gate from the 400 MHz input, the GPIO and CMU gates), and the |
CMU_G3D clocks the Tensor G4's Mali GPU: two PLLs (the stacks' and the L2's), user muxes for CMU_TOP's G3D NoC, global and switch clocks, and the GPU's core, coregroup and stacks clocks. Describe it in the common Tensor G4 clock binding with its four inputs, and add CMU_TOP's three G3D branches (mux, gate and divider each) and the SHARED0 and SHARED1 halves and thirds those branches select at the end of the TOP block and the 19 CMU_G3D identifiers in a new block, leaving the existing ones unchanged. Link: https://android.googlesource.com/kernel/google-modules/soc/gs/+/204078758737776959ecc85c527a00fd2cabb62f/drivers/soc/google/cal-if/zuma/cmucal-node.c Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Register CMU_G3D, the Mali GPU's clock unit, on the common exynos_arm64_register_cmu() path with its bus input, and CMU_TOP's three G3D branches it takes its inputs from. Firmware sets G3D up and keeps its domain on: the two PLLs (PLL0822x, no rate table), the muxes and the dividers are read-only, and the GPU's core, coregroup and stacks gates and the CMU's own gate are read-only gates, as are CMU_TOP's three G3D gates. The STACKS and L2_GLB dividers have no ratio field in the CAL (only busy and auto-gating bits), so they are 1:1 factors. The GPU's rate changes go through the ACPM firmware, not this CMU. Every offset, width and parent list was checked against zuma's cmucal- sfr.c and cmucal-node.c. On the Pixel 9a the integration kernel 7.3.0-rc6-omamobile-tegu-s2mpg15-m1-g991042e2eff3-dirty, whose clk- zumapro.c (blob ae4948e0dd60) has these G3D and CMU_TOP G3D tables, registers the 30 G3D clocks and runs Panthor on the core, coregroup and stacks gates (fout_g3d at 149.9 MHz, gout_g3d_core at 159.7 MHz). CMU_TOP's G3D GLB and SWITCH muxes also select SHARED0 and SHARED1 divided by 2 and 3, which the driver didn't register, so a mux left on one of them would be an orphan reading 0 Hz. Add the four fixed factors (the CAL's PLL_SHARED0_D2 and _D3, PLL_SHARED1_D2 and _D3). On the Pixel 9a the bootloader leaves the GLB mux on SHARED0_D2: mout/gout_g3d_glb read 1065.984 MHz and dout_g3d_glb 532.992 MHz; NOCD and SWITCH are on SHARED2 (798.72 MHz), dout_g3d_nocd 133.12 and dout_g3d_switch 266.24 MHz. Link: https://android.googlesource.com/kernel/google-modules/soc/gs/+/204078758737776959ecc85c527a00fd2cabb62f/drivers/soc/google/cal-if/zuma/cmucal-sfr.c Link: https://android.googlesource.com/kernel/google-modules/soc/gs/+/204078758737776959ecc85c527a00fd2cabb62f/drivers/soc/google/cal-if/zuma/cmucal-node.c Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
CMU_HSI1 clocks the HSI1 block's GPIO bank (the modem's control lines, the haptics reset). Describe it in the common Tensor G4 clock binding with its three inputs: the oscillator, CMU_TOP's HSI1 NoC clock and the board's 400 MHz ALT fixed clock. Allow a power domain for it as for HSI0, which firmware keeps on today. Add CMU_TOP's HSI1 branch at the end of the TOP block and the 7 CMU_HSI1 identifiers in a new block, leaving the existing ones unchanged. Link: https://android.googlesource.com/kernel/google-modules/soc/gs/+/204078758737776959ecc85c527a00fd2cabb62f/drivers/soc/google/cal-if/zuma/cmucal-node.c Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
Register CMU_HSI1 on the common exynos_arm64_register_cmu() path with its bus input, and CMU_TOP's HSI1 NoC branch. Firmware keeps the domain powered and owns its setup: the NoC and ALT user muxes, the local NoC mux and the ALT divider are read-only, and the ALT, GPIO and CMU gates are read-only gates. Only the GPIO bank's clock path is described; the PCIe channel 0 clocks are not. The ALT gate's parent is the board's 400 MHz hsi1-alt fixed clock, found by name as HSI0's ALT and TCXO inputs are. Every offset, width and parent list was checked against zuma's cmucal-sfr.c and cmucal-node.c. Booted on the Pixel 9a: 7.3.0-rc6-omamobile-tegu-s2mpg15-m1-g991042e2eff3-dirty, whose clk-zumapro.c (blob c1db3a4a7736) carries these clocks under that tree's own clock ids. Link: https://android.googlesource.com/kernel/google-modules/soc/gs/+/204078758737776959ecc85c527a00fd2cabb62f/drivers/soc/google/cal-if/zuma/cmucal-sfr.c Link: https://android.googlesource.com/kernel/google-modules/soc/gs/+/204078758737776959ecc85c527a00fd2cabb62f/drivers/soc/google/cal-if/zuma/cmucal-node.c Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
W4HO-ham
force-pushed
the
tegu-hsi1-clocks
branch
from
October 27, 2026 18:46
ccf544a to
5d88bfa
Compare
Owner
|
Landed through #79, which carried this commit with the rest of the stack. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #73 (G3D). Rebased onto
omamobileafter #40's merge. Only the last two commits are new:dt-bindings: clock: google,zumapro: Add CMU_HSI1andclk: samsung: zumapro: Add CMU_HSI1. I'll rebase as the others go in.CMU_HSI1 clocks the HSI1 GPIO bank, which carries the modem's control lines and the haptics reset. It's built the same way as #40 and #73:
exynos_arm64_register_cmu()with thebusinput, and no PMU check. Firmware keeps the domain on, and Linux has no power-domain driver that could turn it off.hsi1-altfixed clock, found by name like HSI0's inputs.google,zumapro-cmu-hsi1withoscclk,busandalt.power-domainsis now optional on HSI0 and HSI1 and refused on the rest, through onenot: enumrule instead of HSI0'selse.I checked every offset, width and parent list against zuma's CAL, the same commit as #40. That includes
I_CLK_HSI1_ALTas a 400 MHz fixed rate behindGATE_CLK_HSI1_ALTand the 4-bitDIV_CLK_HSI1_ALT.Boot: our integration kernel used to register HSI1 through a private probe with PMU checks. For this PR I replaced that with exactly this commit's tables on the common path and booted the palmtop. HSI1's clocks registered,
zumapro_gout_gpio_hsi1reads 400 MHz with12040000.pinctrlas its consumer, and the HSI1 pin controller bound. Haptics, which resets through that bank, came up.checkpatch --strict is clean on both commits,
clk-zumapro.obuilds with W=1, anddt_binding_checkpasses for the binding.