Repository navigation
power: sequencing: qcom-wcn: Wait for optional AoC readiness - #253
latentoperator wants to merge 5 commits into
Conversation
GSA may defer until its Trusty IPC channel is available. Preserve that error from find_gsa_device() so the driver core can retry AoC instead of turning a supplier dependency into a permanent invalid-argument failure. The combined lynx test stack reached 82 services on November 13. The error propagation also changes shared AoC probe behavior; reference-phone startup must be requalified before merge. Assisted-by: OpenAI Codex Signed-off-by: Chris Gray <chrisgray70@gmail.com>
The exynos-chipid driver already owns the read-only chip-ID resource. AoC needs a mapping of the same range, so keep resource lookup and error handling but do not reserve the range a second time. The combined lynx test stack reached AoC online with this mapping. This is shared code and still requires Pixel 7 Pro startup validation; the rebased preparation has not run on either phone. Assisted-by: OpenAI Codex Signed-off-by: Chris Gray <chrisgray70@gmail.com>
WLAN power on lynx must wait for the specified AoC firmware to be online, not just for the platform device to exist. Export a read-only state query and an optional phandle check which fails closed for an invalid or offline supplier. Boards without the dependency keep their existing consumer path. This is a point-in-time readiness check, not a lifetime guarantee across AoC crashes or removal. It supports the attended manual lab sequence; automatic startup, retry notification and restart handling need review. The combined local stack passed once; this rebase is not runtime-tested. Assisted-by: OpenAI Codex Signed-off-by: Chris Gray <chrisgray70@gmail.com>
Describe the optional AoC firmware supplier used by lynx before WLAN power assertion. The existing WCN6855 Bluetooth path does not gain the property by default; it will be applied only by the attended test overlay. This binding accompanies experimental sequencing code and does not enable hardware or redistribute firmware. Assisted-by: OpenAI Codex Signed-off-by: Chris Gray <chrisgray70@gmail.com>
When an AoC phandle is supplied, defer before GPIO acquisition and check readiness again before asserting WLAN_EN. Initialize that WLAN GPIO low. Consumers without the property retain GPIOD_ASIS and their existing path. Use the tristate dependency to avoid a built-in consumer referencing a modular AoC symbol. This limits that configuration combination globally and must be considered when reviewing the cross-subsystem dependency. One combined lynx connection passed; Bluetooth coexistence, unattended startup and the rebased source remain unqualified. Assisted-by: OpenAI Codex Signed-off-by: Chris Gray <chrisgray70@gmail.com>
|
Thank you, Chris. The first three commits are #252's, and I've answered those there. On the two that are this PR's own: They don't touch the Pixel 7 Pro, which has no WCN node. What I'd change before this leaves draft is the link between the two drivers. With both built as modules, as our config has them, Two ways I can see, and you may have a better one:
And please give the source for the order in the binding commit: the stock DT line or the place in Google's driver that ties WLAN power to the AoC. "Supplying the WLAN boot strap" needs a citation. I haven't built this on today's base or run the binding check myself; CI did both on the older base. |
What and why
Two topic commits, binding then driver, stacked on the three AoC prerequisite
commits. Merge the AoC topic first, then drop its rebased copies so this PR lands
only its own two commits.
An optional
google,aocdependency checks firmware readiness before GPIOacquisition and WLAN assertion; the lab WLAN GPIO starts low. Nodes without the
property retain their existing GPIO behavior. No shipping PMU gets this property.
The
GS201_AOC || !GS201_AOCrelationship prevents a built-in consumer referencinga modular provider but also constrains that configuration globally; this is an
explicit cross-subsystem tradeoff for review.
Evidence and limits
The source was split from the local experimental stack that passed one guarded
Pixel 7a connection on November 13, documented in
mobile #751.
That test used
7.3.0-rc6-omamobile-lynx-msi-20261113+on published base2db2bc35bplus local changes. It does not qualify these revised commits.An earlier readiness-corrected connection stalled WMI/TX and lost USB; the
bounded guard recovered the phone. One later pass does not establish the
failure's cause or a stable fix.
Combined offline preparation on published
omamobilebase82f31d3a7a3511f9c5a6d1e7c855358762ed3f58: six touched C objects and ten DTBsbuild with W=1 and no new diagnostics; nine non-lynx DTBs including cheetah are
byte-identical. Both changed bindings pass documentation validation; full
schema checks add no diagnostics over base, including the lab overlays.
AoC absent/module/built-in consumer reachability checks pass. Strict checkpatch
has no errors, only the new-header MAINTAINERS warning. Independent source
review caught and rechecked late-link MSI readiness, runtime MSI disablement,
and the binding's required AoC dependency.
This is combined source/build evidence, not a standalone build or runtime
qualification of every topic/intermediate commit. No complete new kernel/module
link or fresh phone-smoke report is claimed. The full historical smoke table is
in #751; all six required checks passed on that earlier boot. Optional CMA/GPU
failures remain recorded there. No device operation was performed to prepare
these commits. Firmware and private captures are not included.
Before merge
Keep this draft while reference-device and revised-source qualification remain
open. Shared Trusty/AoC behavior must run on the Pixel 7 Pro before merge;
unchanged DTBs do not establish unchanged shared C behavior. A complete matched
kernel/module/image set and a new reviewed, identity-pinned watchdog/recovery
runbook are required before an attended lynx trial. Automatic firmware-ready
reprobe and lifetime handling, sustained traffic, reconnect, suspend/resume and
Bluetooth coexistence remain unqualified. The new board path stays disabled.
Human DCO certification was completed on November 14 and independently verified
against the frozen review inputs: 25 commit objects across the five topic and
integration refs, representing ten logical patches. The signed source trees,
per-commit diffs, author identities and author dates are unchanged.
Published topic head:
34f6d8d3585fbb4952d51bc68d942a19893d503e(5 commits including any prerequisites).The exact signed head passes local
tools/kernel-pr-check --mergeagainst82f31d3a7: clean merge, author sign-offs, prefixes, checkpatch and privacy/blobpolicy. Hosted exact-head CI now passes sign-offs, checkpatch, W=1 and device-tree checks. No merge or release enablement is
requested.
Related work