Skip to content

soc: google: aoc: Preserve probe deferral and expose readiness - #252

Draft
latentoperator wants to merge 3 commits into
derekross:omamobilefrom
latentoperator:omamobile-lynx-aoc-20261114
Draft

latentoperator wants to merge 3 commits into
derekross:omamobilefrom
latentoperator:omamobile-lynx-aoc-20261114

Conversation

@latentoperator

@latentoperator latentoperator commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

What and why

Three commits: preserve GSA's deferred-probe error, map the chip-ID range without
claiming it again from exynos-chipid, and expose a read-only AoC-online snapshot
for optional WLAN dependencies.

Source-independent of the Trusty topic, but the combined lynx startup evidence
uses both. The probe fixes intentionally change shared AoC behavior. The query
is not a firmware-lifetime lease, and asynchronous ONLINE does not guarantee a
consumer reprobe. This supports an attended manual experiment only.

Evidence and limits

The source was split from the local experimental stack that passed one guarded
Pixel 7a connection on November 13, documented in
mobile #751.
That test used 7.3.0-rc6-omamobile-lynx-msi-20261113+ on published base
2db2bc35b plus local changes. It does not qualify these revised commits.
An earlier readiness-corrected connection stalled WMI/TX and lost USB; the
bounded guard recovered the phone. One later pass does not establish the
failure's cause or a stable fix.

Combined offline preparation on published omamobile base
82f31d3a7a3511f9c5a6d1e7c855358762ed3f58: six touched C objects and ten DTBs
build with W=1 and no new diagnostics; nine non-lynx DTBs including cheetah are
byte-identical. Both changed bindings pass documentation validation; full
schema checks add no diagnostics over base, including the lab overlays.
AoC absent/module/built-in consumer reachability checks pass. Strict checkpatch
has no errors, only the new-header MAINTAINERS warning. Independent source
review caught and rechecked late-link MSI readiness, runtime MSI disablement,
and the binding's required AoC dependency.

This is combined source/build evidence, not a standalone build or runtime
qualification of every topic/intermediate commit. No complete new kernel/module
link or fresh phone-smoke report is claimed. The full historical smoke table is
in #751; all six required checks passed on that earlier boot. Optional CMA/GPU
failures remain recorded there. No device operation was performed to prepare
these commits. Firmware and private captures are not included.

Before merge

Keep this draft while reference-device and revised-source qualification remain
open. Shared Trusty/AoC behavior must run on the Pixel 7 Pro before merge;
unchanged DTBs do not establish unchanged shared C behavior. A complete matched
kernel/module/image set and a new reviewed, identity-pinned watchdog/recovery
runbook are required before an attended lynx trial. Automatic firmware-ready
reprobe and lifetime handling, sustained traffic, reconnect, suspend/resume and
Bluetooth coexistence remain unqualified. The new board path stays disabled.

Human DCO certification was completed on November 14 and independently verified
against the frozen review inputs: 25 commit objects across the five topic and
integration refs, representing ten logical patches. The signed source trees,
per-commit diffs, author identities and author dates are unchanged.

Published topic head: e987c125176c1983983ce4479cd3dcad15d74432 (3 commits including any prerequisites).
The exact signed head passes local tools/kernel-pr-check --merge against
82f31d3a7: clean merge, author sign-offs, prefixes, checkpatch and privacy/blob
policy. Hosted exact-head CI now passes sign-offs, checkpatch, W=1 and device-tree checks. No merge or release enablement is
requested.

Related work

GSA may defer until its Trusty IPC channel is available. Preserve that
error from find_gsa_device() so the driver core can retry AoC instead of
turning a supplier dependency into a permanent invalid-argument failure.

The combined lynx test stack reached 82 services on November 13. The
error propagation also changes shared AoC probe behavior; reference-phone
startup must be requalified before merge.

Assisted-by: OpenAI Codex
Signed-off-by: Chris Gray <chrisgray70@gmail.com>
The exynos-chipid driver already owns the read-only chip-ID resource.
AoC needs a mapping of the same range, so keep resource lookup and error
handling but do not reserve the range a second time.

The combined lynx test stack reached AoC online with this mapping. This
is shared code and still requires Pixel 7 Pro startup validation; the
rebased preparation has not run on either phone.

Assisted-by: OpenAI Codex
Signed-off-by: Chris Gray <chrisgray70@gmail.com>
WLAN power on lynx must wait for the specified AoC firmware to be online,
not just for the platform device to exist. Export a read-only state query
and an optional phandle check which fails closed for an invalid or offline
supplier. Boards without the dependency keep their existing consumer path.

This is a point-in-time readiness check, not a lifetime guarantee across
AoC crashes or removal. It supports the attended manual lab sequence;
automatic startup, retry notification and restart handling need review.
The combined local stack passed once; this rebase is not runtime-tested.

Assisted-by: OpenAI Codex
Signed-off-by: Chris Gray <chrisgray70@gmail.com>
@derekross

Copy link
Copy Markdown
Owner

Thank you, Chris. I read the three commits one by one, with the Pixel 7 Pro in mind, since it starts the AoC with this driver at every boot (and so does the Pixel 9a).

  1. "Preserve GSA probe deferral" is right in itself: gsa_get_device() already returns -EPROBE_DEFER, and the probe was throwing it away. On the 7 Pro the start script loads gsa first, and I can't find the old error once in about a thousand saved logs, so the branch has never run there. It still changes what a not-ready GSA leads to (a quiet wait in place of a failure), so it gets a run on my phone before it merges.
  2. "Map chip ID without a second resource claim": I can't find the second owner. On the published omamobile nothing but the AoC node names 0x10000000 on gs201 or zumapro; gs101.dtsi has efuse@10000000, but gs101 has no AoC node. So the claim succeeds today, on every boot of the 7 Pro. Which node took the range on your test tree? If it's one that isn't published, this commit belongs with the PR that adds it; here it changes two phones' probe for a conflict they don't have.
  3. "Expose firmware readiness" changes nothing on a phone by itself (nothing calls it yet). Its shape matters for power: sequencing: qcom-wcn: Wait for optional AoC readiness #253 and PCI: dwc: gs201: Add guarded lynx combined MSI support #254, though: a module that calls it depends on aoc_core, and I've written about that on power: sequencing: qcom-wcn: Wait for optional AoC readiness #253. I'd keep this commit with whichever of those ends up using it.

Before it leaves draft I'd like the answer to point 2, and one run of these commits on your 7a on today's base without the PCIe and power changes. I haven't built or compared objects yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants