Skip to content

arm64: dts: exynos: google: lynx: Describe disabled WLAN PCIe - #255

Draft
latentoperator wants to merge 10 commits into
derekross:omamobilefrom
latentoperator:omamobile-lynx-wifi-dt-20261114
Draft

latentoperator wants to merge 10 commits into
derekross:omamobilefrom
latentoperator:omamobile-lynx-wifi-dt-20261114

Conversation

@latentoperator

@latentoperator latentoperator commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

What and why

One board topic commit following all nine driver/binding prerequisites. The
current branch therefore shows the complete ten-commit integration. Merge the
Trusty, AoC, power and PCIe topics first, then rebase this PR to its single board
commit. Do not merge the duplicate prerequisite copies as another series.

Describe the WCN6855 endpoint/supplies and select the lynx controller variant with
PCIe explicitly disabled. Define the low WLAN pin state without selecting it.
The existing enabled Bluetooth PMU gets no AoC dependency or WLAN GPIO; a separate
attended lab overlay supplies those optional properties. No descriptor or package
enables this path, and no default Wi-Fi startup is proposed.

Evidence and limits

The source was split from the local experimental stack that passed one guarded
Pixel 7a connection on November 13, documented in
mobile #751.
That test used 7.3.0-rc6-omamobile-lynx-msi-20261113+ on published base
2db2bc35b plus local changes. It does not qualify these revised commits.
An earlier readiness-corrected connection stalled WMI/TX and lost USB; the
bounded guard recovered the phone. One later pass does not establish the
failure's cause or a stable fix.

Combined offline preparation on published omamobile base
82f31d3a7a3511f9c5a6d1e7c855358762ed3f58: six touched C objects and ten DTBs
build with W=1 and no new diagnostics; nine non-lynx DTBs including cheetah are
byte-identical. Both changed bindings pass documentation validation; full
schema checks add no diagnostics over base, including the lab overlays.
AoC absent/module/built-in consumer reachability checks pass. Strict checkpatch
has no errors, only the new-header MAINTAINERS warning. Independent source
review caught and rechecked late-link MSI readiness, runtime MSI disablement,
and the binding's required AoC dependency.

This is combined source/build evidence, not a standalone build or runtime
qualification of every topic/intermediate commit. No complete new kernel/module
link or fresh phone-smoke report is claimed. The full historical smoke table is
in #751; all six required checks passed on that earlier boot. Optional CMA/GPU
failures remain recorded there. No device operation was performed to prepare
these commits. Firmware and private captures are not included.

Before merge

Keep this draft while reference-device and revised-source qualification remain
open. Shared Trusty/AoC behavior must run on the Pixel 7 Pro before merge;
unchanged DTBs do not establish unchanged shared C behavior. A complete matched
kernel/module/image set and a new reviewed, identity-pinned watchdog/recovery
runbook are required before an attended lynx trial. Automatic firmware-ready
reprobe and lifetime handling, sustained traffic, reconnect, suspend/resume and
Bluetooth coexistence remain unqualified. The new board path stays disabled.

Human DCO certification was completed on November 14 and independently verified
against the frozen review inputs: 25 commit objects across the five topic and
integration refs, representing ten logical patches. The signed source trees,
per-commit diffs, author identities and author dates are unchanged.

Published topic head: dfdf8ce251c89d3cd05a6325c61ed7ea1c61a741 (10 commits including any prerequisites).
The exact signed head passes local tools/kernel-pr-check --merge against
82f31d3a7: clean merge, author sign-offs, prefixes, checkpatch and privacy/blob
policy. Hosted exact-head CI now passes sign-offs, checkpatch, W=1 and device-tree checks. No merge or release enablement is
requested.

Related work

Trusty IPC allocates and shares message storage before queuing it. The
virtqueue descriptor must carry that shared-memory handle, not the
address of the message-buffer bookkeeping structure. Set the scatterlist
DMA fields explicitly and use the premapped virtqueue helpers for TX,
initial RX and recycled RX. Remove the transport's private DMA override.

The combined local stack passed Trusty IPC and AoC startup on lynx on
November 13. This changes the shared transport on every Trusty board;
Pixel 7 Pro IPC, AoC and dependent-service regression testing is required.
This preparation is rebased and has not run on hardware.

Assisted-by: OpenAI Codex
Signed-off-by: Chris Gray <chrisgray70@gmail.com>
GSA may defer until its Trusty IPC channel is available. Preserve that
error from find_gsa_device() so the driver core can retry AoC instead of
turning a supplier dependency into a permanent invalid-argument failure.

The combined lynx test stack reached 82 services on November 13. The
error propagation also changes shared AoC probe behavior; reference-phone
startup must be requalified before merge.

Assisted-by: OpenAI Codex
Signed-off-by: Chris Gray <chrisgray70@gmail.com>
The exynos-chipid driver already owns the read-only chip-ID resource.
AoC needs a mapping of the same range, so keep resource lookup and error
handling but do not reserve the range a second time.

The combined lynx test stack reached AoC online with this mapping. This
is shared code and still requires Pixel 7 Pro startup validation; the
rebased preparation has not run on either phone.

Assisted-by: OpenAI Codex
Signed-off-by: Chris Gray <chrisgray70@gmail.com>
WLAN power on lynx must wait for the specified AoC firmware to be online,
not just for the platform device to exist. Export a read-only state query
and an optional phandle check which fails closed for an invalid or offline
supplier. Boards without the dependency keep their existing consumer path.

This is a point-in-time readiness check, not a lifetime guarantee across
AoC crashes or removal. It supports the attended manual lab sequence;
automatic startup, retry notification and restart handling need review.
The combined local stack passed once; this rebase is not runtime-tested.

Assisted-by: OpenAI Codex
Signed-off-by: Chris Gray <chrisgray70@gmail.com>
Describe the optional AoC firmware supplier used by lynx before WLAN
power assertion. The existing WCN6855 Bluetooth path does not gain the
property by default; it will be applied only by the attended test overlay.

This binding accompanies experimental sequencing code and does not enable
hardware or redistribute firmware.

Assisted-by: OpenAI Codex
Signed-off-by: Chris Gray <chrisgray70@gmail.com>
When an AoC phandle is supplied, defer before GPIO acquisition and check
readiness again before asserting WLAN_EN. Initialize that WLAN GPIO low.
Consumers without the property retain GPIOD_ASIS and their existing path.

Use the tristate dependency to avoid a built-in consumer referencing a
modular AoC symbol. This limits that configuration combination globally
and must be considered when reviewing the cross-subsystem dependency.
One combined lynx connection passed; Bluetooth coexistence, unattended
startup and the rebased source remain unqualified.

Assisted-by: OpenAI Codex
Signed-off-by: Chris Gray <chrisgray70@gmail.com>
Describe the lynx controller variant and its AoC firmware supplier. The
variant uses the wrapper's combined DWC MSI interrupt; the existing gs201
compatible retains its INTx implementation. Hardware remains disabled in
the board preparation.

Assisted-by: OpenAI Codex
Signed-off-by: Chris Gray <chrisgray70@gmail.com>
Select the DWC MSI host setup for the lynx compatible and dispatch it
from the shared ELBI handler. Publish the initialized domain before IRQ
enablement, restore the MSI rising-edge enable after link reset, and
synchronize MSI teardown before destroying its domain. Export the DWC
handler for a modular gs201 host.

Check the optional AoC supplier before probe and host initialization.
The existing compatible retains its INTx host operations; the optional
supplier is absent on reference boards. Shared functions and the Kconfig
relationship still need reference-device review.

Firmware and scan passed in the local lynx stack. That earlier stack
later stalled during connection, so this commit is not a qualified
connection fix. No rebased candidate has booted.

Assisted-by: OpenAI Codex
Signed-off-by: Chris Gray <chrisgray70@gmail.com>
A vector arriving behind the DWC dispatch snapshot can leave the MSI
output asserted after the wrapper has consumed its rising edge. Pulse
the DWC masks under its IRQ-chip lock, preserving Linux's current masks,
so pending status can assert a new edge. This follows the mask-pulse
mechanism in Google's GPL combined-MSI handler.

One guarded connection and verified HTTPS request passed on lynx with
this candidate on November 13. An earlier WMI/TX stall remains unexplained;
the result does not establish that this change fixes it. Keep this
candidate separate for review, stress testing and possible rejection.
It is selected only by the new lynx compatible.

Assisted-by: OpenAI Codex
Signed-off-by: Chris Gray <chrisgray70@gmail.com>
Describe the WCN6855 endpoint, virtual PMU supplies and lynx controller
variant, keeping PCIe explicitly disabled. Define but do not select the
low WLAN_EN pin state. Label the existing PMU for the separate lab overlay.

Do not add an AoC dependency or WLAN GPIO to the existing enabled PMU in
the shipping tree: that would alter its already working Bluetooth path.
The mobile bring-up overlay opts into those experimental properties and
the low pin state only for an attended test.

The local November 13 stack provides the underlying one-run evidence;
this disabled-by-default revision is a new preparation and has not booted.
No boot-time Wi-Fi enablement or firmware is included.

Assisted-by: OpenAI Codex
Signed-off-by: Chris Gray <chrisgray70@gmail.com>
@derekross

Copy link
Copy Markdown
Owner

Thank you, Chris. Nine of the ten commits here are the copies from #251 to #254, and I've answered those on their own PRs, so this is only about the board commit. It conflicts with today's omamobile through the PCIe commits it carries; as you say, it rebases down to one commit once the others are settled.

The shape is right: the PCIe node stays disabled, the Bluetooth PMU is left exactly as it is, and the low WLAN_EN pin state is defined in the board file without being selected, which is where Samsung's pin controller needs it.

One thing I need before this leaves draft: something that confines the Wi-Fi chip's DMA. The WCN6855 runs vendor firmware and is a bus master, and on the 7a nothing sits in front of pcie_1. The Pixel 7 Pro's Wi-Fi node has memory-region = <&wifi_dma_pool> (a restricted DMA pool), and your own bluejay work did the same for the Broadcom endpoint. Please give wifi@0,0 a restricted pool too, with its size reasoned in the message, and tell me whether ath11k runs from one; if it can't, say so in the node's comment and it stays a bench-only node.

Smaller: the stock DT lines for the WLAN GPIO, the endpoint and the nine supplies belong in the message, and google,aoc on &pcie_1 goes away if #254 ends up keeping the order in the start script.

I haven't validated the node against the bindings on today's base; that needs the rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants