Repository navigation
Conversation
|
Thanks for posting this early as a draft, and for saying on #36 what you were working on; that's exactly how we avoid duplicate work. A real panel on lynx would be a big step. Some notes for when it leaves draft:
|
|
Thanks for the notes, and for the clear shared-device constraints.
The phone is on stock Android right now, so the panel name and smoke/evidence runs need one Arch cycle after the patches are review-shaped. Assisted-by: DeepSeek |
|
You were right about the Panthor clamp: it breaks the 7 Pro and lynx alike. Live evidence on the Pixel 7a:
With the clamp removed, Panthor initializes normally,
So the reserved display pool was already sufficient; the 32-bit mask was the bug, not the fix. I removed it and kept only &gpu { status = "okay"; } on lynx. The remaining #202 work is the mode-from-panel change, the binding, the overlay/disabled-by-default rule, and the per-commit cleanup. Assisted-by: DeepSeek |
|
Mode now comes from the panel. gs-dsim exposes the panel's get_modes, and DECON's connector uses those first, keeping the SoC table only as a fallback when no panel is attached. Verified on the 7a:
So the hard-coded lynx mode is no longer what drives the connector. I will remove gs201_lynx_decon_modes/the lynx DECON compatible and move the remaining nodes to disabled-by-default + overlay in the next pass. Assisted-by: DeepSeek |
|
Cleaned the series to four signed-off commits:
The tree is unchanged from the tested build except CRLF normalization. Remaining warnings are the gs201-decon-lynx compatible documentation and the panel Kconfig help text; I will address those with the mode-from-panel cleanup. Assisted-by: DeepSeek |
|
Full local check now passes with the build stage: ` ok - 4 commits signed off by their authors, none by an AI Remaining checkpatch warnings are the gs201-decon-lynx compatible documentation, the panel Kconfig help length, and spacing; I will address the compatible with the mode-from-panel cleanup. Assisted-by: DeepSeek |
|
Corrected the panel Kconfig commit: it had picked up one-character truncations on unrelated lines. The file is now the branch-base version plus only the DRM_PANEL_SAMSUNG_S6E3FC5 entry, with a fuller help paragraph. Full kernel-pr-check --build passes again:
Assisted-by: DeepSeek |
|
Thanks for all the work since my last note. Removing the panthor clamp and finding out on the phone that it was the cause rather than the fix was a good catch, and the series now has a binding, sign-offs and clean line endings. It's still a draft, so here's what I found reading the new head, roughly in order of importance:
Smaller: the binding's supplies should take the hardware names ( None of this takes away from how far you've got. A lynx panel taking over from simpledrm is real progress. Once the driver sends the S6E3FC5's own commands on its own reset line, #438's switch can go in with it. |
11239a3 to
7c6c851
Compare
|
Rebased onto 5c8b9e5 and fixed the two panel issues from the last review:
Kernel builds (gs201-lynx.dtb and the panel module). Head is 67c6adf. Next is flashing Arch and testing panel reset, touch unreset, brightness/DPMS and the 60/90 switch on the phone. Assisted-by: DeepSeek |
|
Tested on the phone with the new driver and DT:
The GPIO change is what unblocked it: the panel now uses gpa7 1, and the touchscreen stays at event0 across the panel handover instead of being reset through gpp23 2. Only 60 Hz is exposed: gs-decon logs unknown DSIM timers: 60 Hz only, so the connector filters to 60 despite the panel driver's 90 Hz sequence. dpms writes still return EPERM from userspace, so panel sleep/reset could not be exercised that way. Head 67c6adf. Assisted-by: DeepSeek |
ad9af10 to
fdebdfd
Compare
d29d9ad to
3ecc2b2
Compare
The Pixel 7a's display path for the mainline kernel.
Five commits
dt-bindings: display: panel: samsung-s6e3fc5: add the panel- binding and MAINTAINERS.drm/panel: samsung-s6e3fc5: add the panel driver- takes the bootloader's panel over, Google's init/on/off sequences, brightness, local HBM (off by default), 60/90 Hz setting.drm: google: gs-decon: add the lynx display path- lynx DECON board data, DSIM link, and the panel's own mode list.arm64: dts: exynos: google: gs201-lynx: enable the display- panel, rails, DECON0, display clocks (nodes disabled until the overlay enables them).arm64: dts: exynos: google: gs201-lynx: enable the GPU.State
Tested-on:are in each body and the trailer block ends withAssisted-by:andSigned-off-by:.61e15599a196: DECON0 binds, panel gates DSI commands, brightness works, display up at 60 Hz.Rebase on #181
lynx-display-181is rebased and building: one 1080x2400 mode set for the 7a, the panel-child pick wins over #181's size match, and probed modes abovedc->max_hzare removed so the 90 Hz mode cannot be selected yet.After #181 lands I will force-push that head and post the cold-boot report, including
gs-dsim-cmd's timer line, the connector's modes and the running refresh rate.