Repository navigation
Conversation
The ST54L in the Google Pixel 9a speaks plain NCI over I2C with an enable line and an interrupt, the transport the nxp-nci driver implements, rather than the NDLC framing of ST's ST21NFCB family (st,st21nfcb-i2c), whose initialisation timed out on it. Add it as a compatible with nxp,nxp-nci-i2c as the fallback. Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
The ST54L answers NCI on nxp-nci's transport and polls, but never reports a target: in 25 s of discovery with a contactless card held on the Pixel 9a, no RF_INTF_ACTIVATED_NTF came. ST's HAL sends a CORE_SET_CONFIG after CORE_INIT (proprietary parameters 0xa1, 0xa2 and 0x80, and TOTAL_DURATION 500 ms, as the 9a's own HAL configuration sets them). Send the same from post_setup when the device is st,st54l. Tested on the Pixel 9a (7.3.0-rc6-omamobile-tegu-s2mpg15-m1, with the same command behind a module parameter in a debug build): the set-config answers status 0, and the held card activates (ISO-DEP over NFC-A, 15 activations in 45 s) and neard lists it as a tag. Signed-off-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
W4HO-ham
force-pushed
the
tegu-nfc-st54l
branch
from
October 28, 2026 01:04
9f8cd9f to
1b8fd3e
Compare
This was referenced Oct 28, 2026
Owner
|
Thank you, this is a neat fix: one CORE_SET_CONFIG from The checks pass on today's Three things:
|
This was referenced Oct 29, 2026
Owner
|
Closing as landed: these commits went in with #131, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the Pixel 9a's ST54L read cards.
The ST54L speaks plain NCI over I2C, nxp-nci's transport (the 9a's NFC node uses it today as
nxp,nxp-nci-i2c). It polls but never reports a target: with a contactless card held on the back, 25 s of discovery passed with no RF_INTF_ACTIVATED_NTF. ST's HAL sends a CORE_SET_CONFIG after CORE_INIT: proprietary 0xa1, 0xa2 and 0x80, and TOTAL_DURATION 500 ms, with the values the 9a's own HAL configuration sets. With the same command sent frompost_setup, the card activates (ISO-DEP over NFC-A, 15 activations in 45 s) and neard lists it as a tag. That holds with no other workaround: the periodic discovery restart I'd carried locally isn't needed.st,st54l, withnxp,nxp-nci-i2cas the fallback, plus a description sentence saying the binding covers this transport.post_setup, only forst,st54l.Tested on the 9a with 7.3.0-rc6-omamobile-tegu-s2mpg15-m1, using an equivalent change: the same bytes from
post_setupbehind a module parameter, in a debug build. I'll boot this exact driver with the DT compatible at the palmtop's next DTB round and post the result here. checkpatch --strict, the W=1 build of core.c and dt_binding_check are clean.The 9a's NFC also needs the SoC's NFC clock pad (PMU 0x3e84 bit 16, Google's
st,extpad_control_en), which I set from a local module today. Its upstream form, and the 9a's NFC DT node, come separately.