Repository navigation
Wave 1: frontend-stack modernization + structured tmux model in agentd (Frontend Command Center UX program) - #86
Conversation
…oard, wave 1 briefs Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ind-merge 3, lucide 1.x (FW1-MODERN 76d3c5e) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ecutor, stale-channel supersede, scrollback paging proof, protocol fixtures (FW1-TMUX-GO eaadfe9) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…rection round Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ne, stale viewer TTL sweep (FW1-TMUX-GO-R2 7a8e6ee) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 37 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughThis PR adds structured tmux topology reporting, hook-based reconciliation, window and pane commands, stale terminal recovery, protocol fixtures, frontend ESLint and TypeScript modernization, control-plane cleanup, and Wave 1 planning and handoff documentation. ChangesStructured tmux control and lifecycle
Frontend toolchain modernization
Control-plane cleanup
Frontend UX program records
Estimated code review effort: 5 (Critical) | ~120 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
agents/agentd/internal/tmux/tmux_test.go (1)
182-233: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick winAdd a timeout to the blocking
wait-forcall.Line 193's
exec.Command(tmuxCommand, "wait-for", signal)blocks indefinitely if the in-pane background job never signals, unlike other waits in this file which useselect/time.After. A regression here would hang the test until the suite-level timeout instead of failing fast.🕐 Suggested fix
- if output, err := exec.Command(tmuxCommand, "wait-for", signal).CombinedOutput(); err != nil { - t.Fatalf("wait for pane history: %v: %s", err, output) - } + waitCtx, cancel := context.WithTimeout(context.Background(), 5*time.Second) + defer cancel() + if output, err := exec.CommandContext(waitCtx, tmuxCommand, "wait-for", signal).CombinedOutput(); err != nil { + t.Fatalf("wait for pane history: %v: %s", err, output) + }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@agents/agentd/internal/tmux/tmux_test.go` around lines 182 - 233, Update TestCapturePaneRangePagesStableContiguousHistory so the blocking tmux wait-for invocation has a bounded timeout, using the file’s existing wait/select/time.After pattern or an equivalent command context timeout. Fail the test promptly with a clear timeout error if the pane job never signals, while preserving the successful signal-handling path.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@agents/agentd/cmd/agentd/main.go`:
- Around line 480-488: In the topology initialization flow around
StartTopologyHooks, only register and defer-close tmux topology hooks when
cfg.Tmux.TopologyEvents is enabled. When disabled, skip StartTopologyHooks
entirely while preserving the existing poll-based reconciliation fallback;
retain the current error and success logging for the enabled path.
In `@tasks/2026-07-20-fw1-tmux-go-brief.md`:
- Line 19: Update the tmux hook list in the “tmux hooks” section to remove
invalid after-kill-pane and after-resize-pane entries, and use the master plan’s
verified pane-exited, window-linked, window-unlinked, and client-session-changed
hooks instead. Preserve the existing feature detection, additive registration,
restoration, fallback polling, and reconciliation requirements.
In `@tests/fixtures/protocol/commands-dispatch-new-window.json`:
- Line 1: Replace the personal absolute path in the new_window command fixture’s
cwd field with a generic, non-user-specific placeholder path, while preserving
the rest of the fixture payload unchanged.
---
Nitpick comments:
In `@agents/agentd/internal/tmux/tmux_test.go`:
- Around line 182-233: Update TestCapturePaneRangePagesStableContiguousHistory
so the blocking tmux wait-for invocation has a bounded timeout, using the file’s
existing wait/select/time.After pattern or an equivalent command context
timeout. Fail the test promptly with a clear timeout error if the pane job never
signals, while preserving the successful signal-handling path.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 43811166-aed7-4ed8-bba8-bd33211603fe
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (61)
.eslintrc.cjsagents/agentd/cmd/agentd/main.goagents/agentd/cmd/agentd/main_terminal_test.goagents/agentd/cmd/agentd/main_tmux_commands_test.goagents/agentd/cmd/agentd/main_tmux_test.goagents/agentd/cmd/agentd/tmux_topology.goagents/agentd/config.example.yamlagents/agentd/internal/config/config.goagents/agentd/internal/config/config_test.goagents/agentd/internal/protocol/command.goagents/agentd/internal/protocol/messages.goagents/agentd/internal/protocol/session.goagents/agentd/internal/protocol/tmux.goagents/agentd/internal/tmux/hooks.goagents/agentd/internal/tmux/pty_bridge_test.goagents/agentd/internal/tmux/terminal.goagents/agentd/internal/tmux/tmux.goagents/agentd/internal/tmux/tmux_test.goagents/agentd/internal/tmux/viewer_pty.goagents/agentd/internal/ws/client.goagents/agentd/internal/ws/client_test.goagents/agentd/internal/ws/protocol_fixtures_test.goapps/dashboard/eslint.config.mjsapps/dashboard/package.jsonapps/dashboard/src/components/SessionList.tsxapps/dashboard/src/components/launch/MobileLaunchSheet.tsxapps/dashboard/src/types/react-three-fiber.d.tseslint.config.mjspackage.jsonpackages/ac-cli/package.jsonpackages/ac-cli/src/config.tspackages/ac-schema/package.jsonservices/control-plane/package.jsonservices/control-plane/src/db/automationMemory.tsservices/control-plane/src/db/index.tsservices/control-plane/src/services/automation.tsservices/control-plane/src/services/clawdbot.tstasks/2026-07-20-frontend-tmux-ux-master-plan.mdtasks/2026-07-20-frontend-ux-study-findings.mdtasks/2026-07-20-fw1-modern-brief.mdtasks/2026-07-20-fw1-tmux-go-brief.mdtasks/2026-07-20-fw1-tmux-go-corrections-brief.mdtasks/frontend-ux-acceptance-checklist.mdtasks/frontend-ux-handoffs/README.mdtasks/frontend-ux-handoffs/fw1-modern.mdtasks/frontend-ux-handoffs/fw1-tmux-go.mdtasks/frontend-ux-log.mdtasks/frontend-ux-metrics.jsonltasks/frontend-ux-status.mdtests/fixtures/protocol/commands-dispatch-kill-window.jsontests/fixtures/protocol/commands-dispatch-new-window.jsontests/fixtures/protocol/commands-dispatch-rename-window.jsontests/fixtures/protocol/commands-dispatch-resize-pane.jsontests/fixtures/protocol/commands-dispatch-select-pane.jsontests/fixtures/protocol/commands-dispatch-select-window.jsontests/fixtures/protocol/commands-dispatch-split-pane.jsontests/fixtures/protocol/commands-dispatch-zoom-pane.jsontests/fixtures/protocol/tmux-topology.jsontools/eslint-typescript-compat/eslint.config.mjstools/eslint-typescript-compat/package.jsontsconfig.base.json
💤 Files with no reviewable changes (1)
- .eslintrc.cjs
…rogram end Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…uilds, drop deleted .eslintrc.cjs Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…abled Addresses PR review: default-off config no longer mutates the user's tmux server hooks or triggers per-event ListPanes for dropped events. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Review threads addressed: (1) hook registration now gated on |
First wave of the Frontend Command Center UX program (
tasks/2026-07-20-frontend-tmux-ux-master-plan.md, owner-locked decisions 2026-07-20). Per-wave deploy cadence: this PR is intended to merge and deploy on its own.FW1-MODERN (frozen 76d3c5e, attempt 1)
@typescript/native-previewalias for Next route type-gen; lint parser isolated intools/eslint-typescript-compat).eslint-plugin-react-hooksunpinned to 7.1.1 (SessionList fixed properly; MobileLaunchSheet exhaustive-deps fixed).FW1-TMUX-GO (frozen eaadfe9 + R2 7a8e6ee, attempt 2)
tmux.topologysnapshots driven by tmux hooks with poll reconciliation.tmux.topology_events), hook snapshot filtering + startup cleanup of crash leftovers, stale-viewer TTL sweep.Verification chain
lint,typecheck,test:ci, dashboard smoke, production build,go build/vet/test) — green.Deploy notes
tmux.topology+ the new command schemas in Wave 2 (FW2-CONTRACTS). Binary rollout is deliberately deferred.Program state:
tasks/frontend-ux-status.md· log:tasks/frontend-ux-log.md· acceptance:tasks/frontend-ux-acceptance-checklist.md🤖 Generated with Claude Code
Summary by CodeRabbit