Repository navigation
Wave 6 + program close-out: mobile tmux UX (full-bleed terminal, key rail, attach-everywhere, letterbox grid, precision reading) + final report - #91
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedToo many files! This PR contains 136 files, which is 36 over the limit of 100. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (137)
You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughAdds a configurable mobile terminal key rail, sticky-Ctrl and touch cursor interactions, pinch-based font sizing, per-host tmux prefixes, Android paste fallbacks, connection-status propagation, and attached full-bleed terminal layouts with updated settings, accessibility, smoke tests, and Wave 6 records. ChangesMobile terminal UX refactor
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant MobileOperator
participant TerminalKeyRail
participant TerminalView
participant TerminalHost
MobileOperator->>TerminalKeyRail: tap, hold, swipe, or activate key
TerminalKeyRail->>TerminalView: emit terminal input or sticky-Ctrl event
TerminalView->>TerminalHost: send transformed terminal sequence
TerminalHost-->>TerminalView: report status and terminal updates
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…mechanisms, backlog assessment (for owner review) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…le key rail in keyboard inset, sticky-Ctrl, touch cursor drag, per-host prefix, Android paste (FW6-CANVAS a593fc6) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (1)
apps/dashboard/src/components/TerminalView.tsx (1)
228-278: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win
statusin the main controller effect's deps forces a full controller teardown/recreate on every connection-status transition.Because
statusis both baked into the controller literal (Line 231) and listed in the deps (Line 269), eachconnecting → connected → reconnecting …transition runs the cleanup (onControllerChange?.(null), clearingcontrollerRef/controllerInstanceRef) and then rebuilds the controller. The lightweight effect at Lines 272-278 already exists to mutatecontroller.statusin place without recreating, so this is redundant churn and pushes transientnullcontrollers intoterminalHostStoreon every reconnect.♻️ Suggested change
}, [ connect, controllerRef, copyAll, copyLastLines, copySelection, disconnect, onControllerChange, paste, terminalRef, suspend, takeControl, - status, ]);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/dashboard/src/components/TerminalView.tsx` around lines 228 - 278, Remove status from the main controller-creation effect’s dependency array so status transitions do not tear down and recreate the controller. Let the existing lightweight effect update controller.status in place, while preserving the initial status assignment in the controller literal and all other controller lifecycle behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/dashboard/src/components/mobile/terminalRailConfig.ts`:
- Around line 114-126: Strengthen the 'chord' branch of isBinding to validate
each chord's modifier against the supported ctrl, alt, and prefix values, and
require ctrl chords to contain exactly one trailing character. Align these
checks with resolveTerminalRailBinding so invalid chords are rejected by
parseTerminalRailConfig and surfaced through the existing railJsonError path
rather than failing during keypress handling.
In `@apps/dashboard/src/components/TerminalView.tsx`:
- Around line 213-215: Update handleVirtualInput to pass virtual rail input
through applyStickyCtrl before calling sendInput, matching the keyboard input
path so one-shot and locked Ctrl affect raw letter sequences emitted by
TerminalKeyRail.
In `@apps/dashboard/src/stores/settings.ts`:
- Around line 683-689: Update setTmuxPrefixForHost to validate the trimmed
prefix with the existing isValidTmuxPrefix helper before storing it in
tmuxPrefixByHost. Preserve removal of empty or DEFAULT_TMUX_PREFIX values, and
ensure invalid prefixes are not persisted so terminal and shortcut behavior
cannot use inert configuration.
In `@tasks/frontend-ux-final-report.md`:
- Around line 7-9: Update the accepted outcome in
tasks/frontend-ux-final-report.md at lines 7-9 to include completed Wave 6,
replacing the Wave 5-only wave count, final SHA, version, and PR range with the
latest values. Update the program-complete marker in tasks/frontend-ux-status.md
at line 57 to reflect Wave 6 completion, including its final commit SHA and
version.
In `@tests/smoke/dashboard.spec.ts`:
- Around line 1191-1197: Remove the duplicated state? member from the inline
settings-storage type assertions in tests/smoke/dashboard.spec.ts at lines
1191-1197 and 1231-1235; retain one state definition in each font-size read
block so the dashboard smoke spec type-checks.
---
Nitpick comments:
In `@apps/dashboard/src/components/TerminalView.tsx`:
- Around line 228-278: Remove status from the main controller-creation effect’s
dependency array so status transitions do not tear down and recreate the
controller. Let the existing lightweight effect update controller.status in
place, while preserving the initial status assignment in the controller literal
and all other controller lifecycle behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 04b72cfb-f4bf-4c7a-9fa0-e451b82a3ef8
📒 Files selected for processing (40)
apps/dashboard/src/app/(dashboard)/tmux/TmuxPageClient.tsxapps/dashboard/src/app/globals.cssapps/dashboard/src/components/TerminalView.tsxapps/dashboard/src/components/mobile/TerminalContextMenu.tsxapps/dashboard/src/components/mobile/TerminalKeyRail.tsxapps/dashboard/src/components/mobile/VirtualKeyboard.tsxapps/dashboard/src/components/mobile/stickyCtrl.test.tsapps/dashboard/src/components/mobile/stickyCtrl.tsapps/dashboard/src/components/mobile/terminalRailConfig.test.tsapps/dashboard/src/components/mobile/terminalRailConfig.tsapps/dashboard/src/components/session/SessionWorkbench.tsxapps/dashboard/src/components/settings/SessionDefaultsPanel.tsxapps/dashboard/src/components/terminal/PersistentTerminalHost.tsxapps/dashboard/src/components/terminal/TerminalSurface.tsxapps/dashboard/src/components/terminal/TerminalToolbar.tsxapps/dashboard/src/components/terminal/terminalHostStore.test.tsapps/dashboard/src/components/terminal/terminalHostStore.tsapps/dashboard/src/components/terminal/types.tsapps/dashboard/src/components/tmux/PromptComposer.tsxapps/dashboard/src/components/tmux/TmuxMobileShell.tsxapps/dashboard/src/components/tmux/TmuxTerminalWorkspace.tsxapps/dashboard/src/components/tmux/TmuxWindowStrip.tsxapps/dashboard/src/components/tmux/accessibilityContracts.test.tsapps/dashboard/src/hooks/useClipboard.tsapps/dashboard/src/hooks/useTerminalClipboard.tsapps/dashboard/src/hooks/useTerminalTouchScroll.test.tsapps/dashboard/src/hooks/useTerminalTouchScroll.tsapps/dashboard/src/hooks/useXtermTerminal.tsapps/dashboard/src/lib/tmuxKeys.test.tsapps/dashboard/src/lib/tmuxKeys.tsapps/dashboard/src/stores/settings.tstasks/2026-07-20-fw6-canvas-brief.mdtasks/2026-07-20-fw6-flow-brief.mdtasks/2026-07-20-mobile-tmux-ux-plan.mdtasks/frontend-ux-final-report.mdtasks/frontend-ux-handoffs/fw6-canvas.mdtasks/frontend-ux-log.mdtasks/frontend-ux-metrics.jsonltasks/frontend-ux-status.mdtests/smoke/dashboard.spec.ts
…oxed stable grid via agentd pinning, warm reattach, command-result reconciliation, + window here (FW6-FLOW 3f8a9fc; AI Lead reconciled with FW6-CANVAS: settings union, grid-context + hostId composition, font/letterbox integration, dual cleanup) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…r-gutter), attention overlay docks above key rail, align smoke choreography with auto-attach (batch-1 integration seams) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…nc blanked app on 404) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ip introduced a hidden text twin) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ns button, sheet Detach/Take-Control, status-row read-only pill) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…t var on common ancestor with teardown, orphan window-size release on crash sweep, one-shot Ctrl disarms on IME text, delete dead TmuxKeyBar Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…typing Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…iable in real Chromium) — closes FW6-VERIFY blocker; New-window-here action in pane sheet (launch trigger was hidden in full-bleed) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ke+journey harnesses (it intercepted rail taps — the FW6-VERIFY prefix blocker); record terminal input frames in smoke WS mock Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…exact-range copy, thumbnail switcher + swipe nav, spatial pane nav, triage chain, command marks (shell OSC133 + agent-turn heuristics), settings fail-soft (FW6-PRECISION adc996e) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…r-host prefix reached default in portal path — FW6-VERIFY resume-2 blocker) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…of, carried A9/A10/A11, Wave-6 docs pass, 0.4.1 changelog, S25 Ultra device checklist (FW6-VERIFY-R2 315c828) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…arks were inert), cancel context-menu timer on cursor-arm, no activation on pointercancel, cache perf query flag (per-frame parse) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…e, still allocation-free per frame) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…refix setter stores only usable values, Wave-6 addendum in final report + board; device corrected to S25 Ultra Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Review threads: (1) chord validation now rejects unknown modifiers and multi-char Ctrl chords at parse time; (2) rail bindings are literal by contract — sticky-Ctrl deliberately applies to OS-keyboard input only, and rail keys consume the one-shot (by design, verified in two adversarial reviews); (3) setTmuxPrefixForHost now stores only emittable C-x/M-x values; (4) final report + status board updated with the Wave-6 addendum; (5) the duplicated type member does not exist in the current tree (single member per literal — fixed in an earlier commit). |
Closing documentation for the completed program (all code shipped in PRs #86–#90): final report, log, metrics, status board. Docs only.
🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Bug Fixes
Tests