Repository navigation
fix: prioritize pane focus acknowledgements - #106
Conversation
|
Warning Review limit reached
Next review available in: 54 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughTerminal navigation results now travel through an unsequenced live channel without durable persistence, use server envelopes without sequence fields, and undergo authenticated host/channel validation before reaching the browser. ChangesTerminal navigation live path
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant agentd
participant wsClient
participant controlPlane
participant navigationHandler
participant browserChannel
agentd->>wsClient: SendUnsequenced terminal.navigation_result
wsClient->>controlPlane: Live WebSocket message with Seq 0
controlPlane->>navigationHandler: Payload and authenticated hostId
navigationHandler->>browserChannel: Verified navigation result
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@agents/agentd/internal/ws/client_test.go`:
- Around line 151-154: Update the priority-message assertion in the WebSocket
client test to verify that the seq field is absent, rather than only checking
message.Seq equals zero. Inspect the raw JSON object or decode seq as
json.RawMessage, assert the key is missing, and retain the existing type and
message-order checks.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f36db43e-ebe3-4880-a4fc-b409377d240e
📒 Files selected for processing (13)
agents/agentd/cmd/agentd/main.goagents/agentd/internal/ws/client.goagents/agentd/internal/ws/client_test.goagents/agentd/internal/ws/protocol_fixtures_test.godocs/operations.mdpackages/ac-schema/src/message.tspackages/ac-schema/tests/terminal.test.tsservices/control-plane/src/routes/terminal.tsservices/control-plane/src/ws/agent.tsservices/control-plane/tests/agentWebSocket.test.tsservices/control-plane/tests/terminalRoute.test.tstasks/lessons.mdtests/fixtures/protocol/terminal-navigation-result.json
What changed
Verification
Summary by CodeRabbit
Bug Fixes
Documentation