Skip to content

fix(local): build local commands on Windows and macOS again - #52

Merged
cu-e merged 2 commits into
masterfrom
fix/local-exec-off-linux
Nov 10, 2026
Merged

cu-e merged 2 commits into
masterfrom
fix/local-exec-off-linux

Conversation

@cu-e

@cu-e cu-e commented Nov 10, 2026

Copy link
Copy Markdown
Owner

What

  • crates/local/src/lib.rs no longer gates mod exec and pub use exec::LocalExec to Linux. MissingFd and Fcntl are gated to unix, the only place that builds them.
  • CI's Windows native job also runs cargo check -p nocterm; the job is renamed "Native build on …".

Why

Release validation for 4.0.0 (#51) failed: the Windows installer build stopped with cannot find module exec in nocterm-local.

When 0b2ca0a deleted the Linux-only mod containment; and its pub use, the #[cfg(target_os = "linux")] attributes in front of them stayed behind. They now gate mod exec; and pub use exec::LocalExec; instead. Off Linux the module disappeared while open_prepared still uses it.

No pull request job compiled the application for Windows, so release validation was the first to notice.

How it was verified

  • cargo check --target x86_64-pc-windows-gnu -p nocterm-local fails before the fix with the same error and passes after it, with no warnings.
  • A --keep-going Windows check of the whole workspace finds no other Rust error. Only C build scripts stop there (gpui, ring, tree-sitter): the sandbox has no Windows toolchain.
  • Linux: cargo clippy -p nocterm-local --all-targets -D warnings is clean and its 53 tests pass. cargo fmt is clean.
  • test-release-pipeline.cjs, the notice inputs and the architecture history pass.

Notes for the reviewer

Squash merge. The same fix goes to dev in a separate PR.


Generated by Claude Code

Removing the Linux-only containment module left its cfg(target_os =
"linux") attribute on the following lines, so mod exec and the LocalExec
export disappeared off Linux and the Windows installer stopped compiling.
Two error variants only built by the unix descriptor setup are now gated to
unix, which also clears the dead-code warning there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WAgRyZqRCp4XuUHFDB1w3k
Installers ship for Windows, but no pull request job compiled the
application there, so a Linux-only gate reached release validation first.
The Windows native job now also runs cargo check -p nocterm.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WAgRyZqRCp4XuUHFDB1w3k
@cu-e
cu-e merged commit 11b5265 into master Nov 10, 2026
10 checks passed
@cu-e
cu-e deleted the fix/local-exec-off-linux branch November 10, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants