Skip to content

fix(local): build local commands on Windows and macOS again - #53

Merged
cu-e merged 2 commits into
devfrom
fix/local-exec-off-linux-dev
Nov 10, 2026
Merged

cu-e merged 2 commits into
devfrom
fix/local-exec-off-linux-dev

Conversation

@cu-e

@cu-e cu-e commented Nov 10, 2026

Copy link
Copy Markdown
Owner

What

The same two commits as #52, for dev:

  • mod exec and LocalExec are no longer gated to Linux;
  • CI checks that the application builds for Windows.

Why

Without the fix, the Windows installer build fails with cannot find module exec in nocterm-local. A #[cfg(target_os = "linux")] attribute was left behind when the containment module was deleted. See #52.

How it was verified

As in #52, on the same files. The architecture history check against dev passes.

Notes for the reviewer

Rebase merge.


Generated by Claude Code

Removing the Linux-only containment module left its cfg(target_os =
"linux") attribute on the following lines, so mod exec and the LocalExec
export disappeared off Linux and the Windows installer stopped compiling.
Two error variants only built by the unix descriptor setup are now gated to
unix, which also clears the dead-code warning there.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WAgRyZqRCp4XuUHFDB1w3k
Installers ship for Windows, but no pull request job compiled the
application there, so a Linux-only gate reached release validation first.
The Windows native job now also runs cargo check -p nocterm.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WAgRyZqRCp4XuUHFDB1w3k
@cu-e
cu-e merged commit a961ec4 into dev Nov 10, 2026
10 checks passed
@cu-e
cu-e deleted the fix/local-exec-off-linux-dev branch November 10, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants