Repository navigation
fix(local): build local commands on Windows and macOS again - #53
Merged
Merged
Conversation
Removing the Linux-only containment module left its cfg(target_os = "linux") attribute on the following lines, so mod exec and the LocalExec export disappeared off Linux and the Windows installer stopped compiling. Two error variants only built by the unix descriptor setup are now gated to unix, which also clears the dead-code warning there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WAgRyZqRCp4XuUHFDB1w3k
Installers ship for Windows, but no pull request job compiled the application there, so a Linux-only gate reached release validation first. The Windows native job now also runs cargo check -p nocterm. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WAgRyZqRCp4XuUHFDB1w3k
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The same two commits as #52, for
dev:mod execandLocalExecare no longer gated to Linux;Why
Without the fix, the Windows installer build fails with
cannot find module execin nocterm-local. A#[cfg(target_os = "linux")]attribute was left behind when the containment module was deleted. See #52.How it was verified
As in #52, on the same files. The architecture history check against
devpasses.Notes for the reviewer
Rebase merge.
Generated by Claude Code