Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -357,8 +357,10 @@ jobs:
if: ${{ !cancelled() }}
run: cargo test --manifest-path vendor/gpui-component/Cargo.toml --locked --features test-support --lib menu::app_menu_bar

# Installers ship for Windows, so a pull request also checks that the whole application
# builds there; release validation would otherwise be the first to compile it.
device-unlock-native:
name: Device unlock on ${{ matrix.os }}
name: Native build on ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
Expand All @@ -383,6 +385,9 @@ jobs:
run: cargo clippy --locked -p nocterm-vault -p nocterm-vault-store -p nocterm-device-unlock --all-targets -- -D warnings
- name: Test portable envelope and native metadata without authentication prompts
run: cargo test --locked -p nocterm-vault -p nocterm-vault-store -p nocterm-device-unlock
- name: Check the application builds for Windows
if: runner.os == 'Windows'
run: cargo check --locked -p nocterm

# The one check to require in branch protection: it passes only when every
# job above passed or was skipped by design, so adding a job never needs a
Expand Down
4 changes: 2 additions & 2 deletions crates/local/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ use nocterm_session::{
use portable_pty::{CommandBuilder, PtySize as NativeSize, native_pty_system};

mod clock;
#[cfg(target_os = "linux")]
mod exec;
mod integration;
mod program_opener;
Expand All @@ -39,7 +38,6 @@ mod readiness;
mod recording;

pub use clock::SystemClock;
#[cfg(target_os = "linux")]
pub use exec::LocalExec;
pub use program_opener::{LocalProgramOpener, MAX_OPEN_PROGRAMS};
pub use recording::LocalOutputLogFactory;
Expand Down Expand Up @@ -208,8 +206,10 @@ enum LaunchError {
Source(#[from] nocterm_session::ConnectionSourceError),
#[error("native PTY error: {0}")]
Pty(String),
#[cfg(unix)]
#[error("native PTY has no file descriptor")]
MissingFd,
#[cfg(unix)]
#[error("file descriptor control error: {0}")]
Fcntl(String),
#[error("I/O error: {0}")]
Expand Down
Loading