Repository navigation
ci(release): detect whether the latest release checksums are signed (#1327) - #1472
Merged
Merged
Conversation
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| command -v jq >/dev/null 2>&1 || { echo "error: jq is required" >&2; exit 2; } | ||
|
|
||
| # Run a mutating gh command, or only print it under --dry-run. | ||
| mutate() { |
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Part 1 of 4 of the release-signature reminder (the earlier single PR #1463 was too large for the Cora reviewer and is being replaced by this series). This part is detection only.
scripts/release-signature-reminder.sh:--dry-runis the only one) and the environment (GH_REPO/GITHUB_REPOSITORY,REMINDER_AFTER_HOURSincluding leading-zero values,ghandjqpresent)^v[0-9]+\.[0-9]+\.[0-9]+$before it goes anywherechecksums-sha256.txt.bundle(those cannot be signed byscripts/sign-release.sh)checksums-sha256.txt.minisigand prints<tag> is signedor<tag> is unsignedmutate()helper for the later parts:--dry-runprints instead of running, and real calls get</dev/nullIt does not touch issues yet, and it changes nothing on GitHub.
scripts/tests/release-signature-reminder.test.sh: 20 checks with a stubgh.Why
Since #1462,
uteke upgradefails closed for a release without a.minisig, and the owner signs offline after each release. The reminder keeps that manual step from being forgotten. The series is small on purpose: each part stays within what the Cora CI reviewer can finish (it times out at 300 s on large diffs).Series: 1 detect (this PR), 2 issue lifecycle, 3 close reminders for superseded releases, 4 workflow and docs. The workflow that actually runs the script comes last, so nothing is scheduled until the whole logic is in.
Testing
bash scripts/tests/release-signature-reminder.test.sh: 20 checks pass. They cover a bad-tag table (v1.2.3; rm -rf,v1.2.3-rc.1, ...), pre-release, draft, no bundle, signed, unsigned, unknown and repeated arguments, and the hours validation (08, non-numeric).bash scripts/tests/sign-release.test.sh: passes.bash -nis clean on both scripts.releases/latestpayload and reports v0.21.0 as unsigned. Nothing is mutated.