Repository navigation
ci(release): run the signature reminder on a schedule (#1327) - #1476
Merged
Merged
Conversation
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Part 4 of 4 of the release-signature reminder (parts 1 to 3: #1472, #1473, #1474, merged).
.github/workflows/release-signature-reminder.yml: runsscripts/release-signature-reminder.shafter the Release workflow, every 6 hours (17 */6 * * *) and on manual dispatch. Permissions arecontents: readandissues: writeonly, no secrets beyond the built-in token, and a concurrency group so two runs never overlap.AGENTS.md: release step 6 describes the reminder (issue title, re-ping interval, self-closing, trusted authors, how to test it).CHANGELOG.md: entry under Unreleased.Why
This is the piece that makes the offline signing step hard to forget: until the
.minisigis on the latest release,uteke upgradefails closed for it (#1327). The reminder signs nothing and holds no key.Testing
bash scripts/tests/release-signature-reminder.test.sh: passes (the script itself was merged and tested in parts 1 to 3).gh workflow run), including the author login of the issue it creates.