Repository navigation
ci(release): open, re-ping and close the reminder issue (#1327) - #1473
Conversation
🔍 Cora AI Code ReviewReview powered by cora-code · BYOK · MIT |
|
Merging on the owner's explicit approval: the Cora job hits the gateway's 300 s limit (504) on this diff, twice. Local review with the configured model (glm/glm-5.3, same rules, 560 s limit) completed: 0 blocking issues; 2 minor + 3 info. Triage: failing create/jq already aborts under set -e (no silent success); the duplicate-from-concurrent-runs case is covered by the concurrency group added in part 4; the listing-limit comment was corrected in the last commit; the trust-list and grep-BRE notes need no change (the script runs on ubuntu with the Actions bot identity). 15/15 CI checks pass, test script passes. |
What
Part 2 of 4 of the release-signature reminder (part 1 is #1472, merged).
scripts/release-signature-reminder.shnow acts on the detection result:Sign release vX.Y.Z (minisign)assigned toRELEASE_SIGNER(defaultajianaz), or re-pings an existing one at most everyREMINDER_AFTER_HOURS(default 12)--search(the search index lags and caused duplicates)mutate(), so--dry-runchanges nothingThe test script grows with a stub
ghthat records mutations.Why
Part 1 only says signed or unsigned. This part turns that into the actual nag and the self-closing, which is what keeps the offline signing step (
scripts/sign-release.sh) from being forgotten.Testing
bash scripts/tests/release-signature-reminder.test.sh: all checks pass (create, re-ping before and after the interval, untrusted author ignored, close on signed, dry-run leaves no mutation, duplicate protection).bash -nis clean. No workflow is added yet (part 4), so nothing is scheduled by this PR.