Repository navigation
Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 44 files
You’re at about 96% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Apex Sentinel · ✅ ApproveSince the last review: 0 new · 0 still open · 0 no longer raised No open findings. Reviewed with this repository's own Sentinel configuration ( 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment Earlier reviewsReview of
|
| Where | Finding |
|---|---|
packages/capture-kit/src/snapshot/snapshot-audit.ts:131 |
🆕 Root-level link treated as inline against every root text node |
packages/capture-kit/src/snapshot/snapshot-audit.ts:211 |
Covered control under a covered plain container produces no finding at all |
Reviewed with this repository's own Sentinel configuration (cfe08502f0f6).
Review of 998e9cee · 16.11.2026 14:42 UTC
Apex Sentinel · ✅ Approve
2 finding(s): 2 minor.
🟡 Minor (2)
| Where | Finding |
|---|---|
packages/capture-kit/src/snapshot/snapshot-audit.ts:145 |
Small-target check ignores Android density for non-mobile targets, so tvOS skips every check |
packages/capture-kit/src/snapshot/snapshot-audit.ts:211 |
Covered control under a covered plain container produces no finding at all |
1 finding below minor hidden (user_settings.min_severity).
Reviewed with this repository's own Sentinel configuration (cfe08502f0f6).
There was a problem hiding this comment.
Apex Sentinel: 2 new findings on 998e9ce. The verdict and the full list are in the summary comment.
998e9ce to
d2c380d
Compare
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on d2c380d. The verdict and the full list are in the summary comment.
|
I reviewed d2c380d and found two problems that need fixes before merge. CI is green (25 checks, 0 failing) and there are no conflicts. First, Second, snapshot.ts:202 uses Not blocking, take or leave: both collapse rules in snapshot-audit.ts ( Could we keep the command and the pure module, publish the finding refs through The open inline threads that still apply: stale refs in tap test, Android timeout evidence, parent actionable check, covered parent suppression, optional detail fields, unknown becomes complete, inline link exemption, root link text, and covered-parent duplicate. Five lower-priority threads also still apply. One thread no longer applies and can be resolved: target checked before platform, which is no longer raised on d2c380d. Before merge, please fix the ref frame so stale plain refs stay refused after audit and keep unknown truncation unknown. Then run this on the new head, on an iOS simulator and an Android emulator: |
d2c380d to
521a20b
Compare
|
Thanks for the review. All of it is addressed at 521a20b (force-pushed; base stays #4594). 1. Ref frame. 2. Truncation. Take-or-leave items, all taken.
All 15 open threads have a reply and are resolved. Per the maintainer note, the "target checked before platform" thread is resolved without a change. Device evidence (this worktree's build, new head).
Both devices are closed with shutdown. Remaining risk: I did not rerun the earlier |
521a20b to
2e90b57
Compare
|
Most of the earlier findings (d2c380d) are fixed at 2e90b57, and one docs mismatch remains. The user doc at https://github.com/callstack/agent-device/blob/2e90b57/website/docs/docs/commands.md#L437 says a control that is the only child of a same-role control reports only through the parent. The code does not do that: collapseIntoParent drops a child finding only when the parent reports the same kind, so a sole child of a disabled, large, or ref-less same-role parent still reports, and the PR's own "keeps the child when the parent does not report that kind" test asserts it. An agent reading the doc would expect no findings on nested same-role children and misread the ones it gets. Please state the rule the code has: a sole child of a same-role control drops a finding only when the parent reports the same kind. Not blocking: the ref paragraph at commands.md#L439 covers only the expired-frame case, while an audit with findings also ends the snapshot's complete frame, so after snapshot then audit a ref outside the findings is refused (plain_ref_requires_complete_frame or ref_not_issued); one clause saying "take a new snapshot before using other refs" would cover it, and the stale platform: 'not-requested' in the daemon test fake can also be taken or left. Of the open inline threads, the threads from the earlier round are fixed at this head and can be resolved, and none still applies. This also covers the root-level link thread (#4592 (comment)) and the covered-child thread (#4592 (comment)). The target-before-platform thread (#4592 (comment)) does not apply, because the tv and desktop limitation is the intended result. CI is green with 25 checks and none failing, and there are no conflicts. Device evidence was taken on 521a20b, and the range-diff shows 2e90b57 is the identical patch on the moved base, so that evidence still covers this head. snapshotTruncationForResult returns false for non-xctest backends with absent truncation, such as an Android Appium-sourced tree; that is the existing helper's rule, shared with snapshot, so it is out of scope here. Before merge, the commands.md sentence needs to match collapseIntoParent. |
Stacked on #4594.
Summary
Adds
agent-device audit: one fresh capture of the current screen, then advisory accessibility findings with usable refs. 44 files, 1258 insertions. Gross diff is above the 1,000-line target but is one coherent change (it includes ~500 lines of tests and fixtures).small-target: enabled control under 44pt (iOS) or 48dp (Android, captured density). Unknown units report a limitation.missing-name: control with no accessible name. Identifiers, resource ids and typed values are not names.covered-control: controls and rows the existing occlusion pass already marks covered.auditSnapshotin capture-kit, types in contracts. Registered through the descriptor registry. Text, JSON and MCP output. Not recorded in replay, not batchable. Noaudit --platform, nohelp dogfoodchange.snapshotis unchanged. The only edit in the snapshot path is anauditcommand added toruntime/snapshot.ts; no existing snapshot, settle, stabilization or replay code changed. The audit module loads lazily, so no other command's import closure grows (eager-closure budgets pass). A livesnapshotbefore and after the audit differed in nothing.Validation
pnpm check:affected --run --head d2c380da13passed,exactCommit: true.git range-diffshows the only change versus the previous head is the tree-helper import.pnpm check:affected --run --head 998e9cee0dpassed,exactCommit: true. It covers unit, provider-integration, integration-node, layering and fallow.press), Android provider scenario (px to dp).hittablestands in for visibility, and generic clickable Android containers are not evaluated. Not byte-compared against a separatemainbuild.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.