Repository navigation
Conversation
Size Report
Startup median (7 runs, lower is better):
|
Apex Sentinel · ✅ ApproveSince the last review: 0 new · 0 still open · 0 no longer raised No open findings. Not in the reviewers' prompt (6 files)
Reviewed with this repository's own Sentinel configuration ( 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment Earlier reviewsReview of
|
There was a problem hiding this comment.
All reported issues were addressed across 6 files
You’re at about 96% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
d2c380d to
521a20b
Compare
35230e2 to
59b2272
Compare
521a20b to
2e90b57
Compare
59b2272 to
aadf30b
Compare
|
I found nothing that blocks this change at 59b2272. All 17 checks are green and there are no conflicts. The delta is read against the base head 2e90b57, since the audit code lives only in open PR #4592. Not blocking, take or leave: the audit line in skills/agent-device/SKILL.md:18 has no support or trigger condition, and Vega has no snapshot (commands.md:340), so you could prefix it with "When the platform supports snapshot, and after a screen change,". The sentence in skills/dogfood/SKILL.md:27 holds two instructions, so you could split it, and do the same for the first line of Platform checks in the help. The comment at scripts/help-conformance-cases.mjs:149 says audit on the initial screen, but the regex matches an audit line anywhere in the plan, so "plans an audit" would be accurate. The open review thread on the missing Vega condition (#4600 (comment)) still apply, as do the three lower-priority threads on the same notes. The thread at #4600 (comment) does not apply: audit keeps the ref frame and issues only a partial publication, so snapshot refs stay valid after it. You can resolve that one. This can merge after base #4592 lands. |
Summary
help dogfoodnow has aPlatform checks:block after Goal/Loop: on the first screen and after a screen changes meaningfully, runauditfirst and thensnapshot -i(audit performs its own capture, so it goes first), act on the snapshot refs or the pinned refs audit prints, and report its findings as accessibility findings; on iOS test Back and the edge-back swipe where a screen was pushed; on Android test system Back and applicable sheet dismissal; probe a dismissible sheet's unchanged swipe-down (expect dismiss), edited dismissal (expect confirm or save), and explicit Cancel; check destructive confirmation or undo, swipe-action alternatives, and each field's return key against its task; exercise each control once with reversible test data. One line carries the exceptions: autosave, explicit discard semantics, mandatory flows, nondismissible presentations. It links the Apple Human Interface Guidelines and Material accessibility guidance and does not restate whatauditalready checks (target size, names).The new command is discoverable outside that topic: one
auditline each inskills/agent-device/SKILL.mdandskills/dogfood/SKILL.md, and the recommended agent rule inwebsite/docs/docs/agent-setup.mdnow points atauditfor the per-screen pass. Each carries the same trigger — first screen, and after a screen changes meaningfully — and the skill line applies only when the target supports snapshots, so snapshotless targets (Vega) skip it.Stacked on #4592.
Evidence
agent-device help dogfoodrenders the block on lines 18-25, inside the first 30 lines.--case dogfood-mode, Sonnet, 3 runs): 3/3 with the block, 9/9 checks each, and every planned pass now emitsauditbeforesnapshot -i. With the earlier draft that only said "run audit", Sonnet stopped planningsnapshot -iand the case failedusesSnapshotI(2/3), which is why the line names both commands in order. The newrunsPlatformAuditexpectation is falsified by the base text: base runs produce plans with noauditcommand.Test plan
pnpm formatpnpm buildnpx vitest run src/commands/schema/cli-help-first-screen.test.ts src/commands/schema/cli-help-workflows.test.ts scripts/__tests__/help-conformance-{topic-coverage,expectation-falsification,error-recovery-coverage}.test.ts scripts/__tests__/agent-setup-startup-contract.test.ts(88 tests)node scripts/help-conformance-bench.mjs --case dogfood-mode --runner claude:sonnet --repeat 3→ 3/3, 9/9 checks eachnode scripts/check-affected/run.ts --run --base origin/feat/static-accessibility-audit-v2 --head HEAD→ 42 runnable checks passed, 0 failed, 25 skipped as GitHub-authoritative,exactCommit=trueonaadf30b47eover base2e90b576c5. Device commands are unchanged.🤖 Generated with Apex