Skip to content

docs(help): add platform checks and audit to the dogfood workflow - #4600

Open
thymikee wants to merge 1 commit into
feat/static-accessibility-audit-v2from
docs/dogfood-platform-checks
Open

thymikee wants to merge 1 commit into
feat/static-accessibility-audit-v2from
docs/dogfood-platform-checks

Conversation

@thymikee

@thymikee thymikee commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Summary

help dogfood now has a Platform checks: block after Goal/Loop: on the first screen and after a screen changes meaningfully, run audit first and then snapshot -i (audit performs its own capture, so it goes first), act on the snapshot refs or the pinned refs audit prints, and report its findings as accessibility findings; on iOS test Back and the edge-back swipe where a screen was pushed; on Android test system Back and applicable sheet dismissal; probe a dismissible sheet's unchanged swipe-down (expect dismiss), edited dismissal (expect confirm or save), and explicit Cancel; check destructive confirmation or undo, swipe-action alternatives, and each field's return key against its task; exercise each control once with reversible test data. One line carries the exceptions: autosave, explicit discard semantics, mandatory flows, nondismissible presentations. It links the Apple Human Interface Guidelines and Material accessibility guidance and does not restate what audit already checks (target size, names).

The new command is discoverable outside that topic: one audit line each in skills/agent-device/SKILL.md and skills/dogfood/SKILL.md, and the recommended agent rule in website/docs/docs/agent-setup.md now points at audit for the per-screen pass. Each carries the same trigger — first screen, and after a screen changes meaningfully — and the skill line applies only when the target supports snapshots, so snapshotless targets (Vega) skip it.

Stacked on #4592.

Evidence

  • agent-device help dogfood renders the block on lines 18-25, inside the first 30 lines.
  • Bench (--case dogfood-mode, Sonnet, 3 runs): 3/3 with the block, 9/9 checks each, and every planned pass now emits audit before snapshot -i. With the earlier draft that only said "run audit", Sonnet stopped planning snapshot -i and the case failed usesSnapshotI (2/3), which is why the line names both commands in order. The new runsPlatformAudit expectation is falsified by the base text: base runs produce plans with no audit command.

Test plan

  • pnpm format
  • pnpm build
  • npx vitest run src/commands/schema/cli-help-first-screen.test.ts src/commands/schema/cli-help-workflows.test.ts scripts/__tests__/help-conformance-{topic-coverage,expectation-falsification,error-recovery-coverage}.test.ts scripts/__tests__/agent-setup-startup-contract.test.ts (88 tests)
  • node scripts/help-conformance-bench.mjs --case dogfood-mode --runner claude:sonnet --repeat 3 → 3/3, 9/9 checks each
  • node scripts/check-affected/run.ts --run --base origin/feat/static-accessibility-audit-v2 --head HEAD → 42 runnable checks passed, 0 failed, 25 skipped as GitHub-authoritative, exactCommit=true on aadf30b47e over base 2e90b576c5. Device commands are unchanged.

🤖 Generated with Apex

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 6.33 MB 6.33 MB +1.2 kB
Package (unpacked) 6.33 MB 6.33 MB +1.2 kB
Package (download) 1.92 MB 1.92 MB +465 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 32.5 ms 36.8 ms +4.3 ms
CLI --help 70.8 ms 82.7 ms +11.9 ms

@apex-sentinel-staging

apex-sentinel-staging Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Apex Sentinel · ✅ Approve

Since the last review: 0 new · 0 still open · 0 no longer raised

No open findings.

Not in the reviewers' prompt (6 files)
  • scripts/help-conformance-cases.mjs: no reviewer was selected for this change
  • skills/agent-device/SKILL.md: no reviewer was selected for this change
  • skills/dogfood/SKILL.md: no reviewer was selected for this change
  • src/commands/schema/cli-help-first-screen.test.ts: no reviewer was selected for this change
  • src/commands/schema/cli-help-workflows.ts: no reviewer was selected for this change
  • website/docs/docs/agent-setup.md: no reviewer was selected for this change

Reviewed with this repository's own Sentinel configuration (b3c1a3c8abd9).

💬 Talking to Sentinel

In a finding's thread, reply with:

Command What it does
@apex-sentinel-staging note <context> Adds context; Sentinel re-checks the cited code
@apex-sentinel-staging pivot <why> Says the finding is wrong; Sentinel re-checks the cited code
@apex-sentinel-staging like Marks the finding as useful
@apex-sentinel-staging dislike <why> Marks it as not useful, so it is not raised again

On this conversation, comment @apex-sentinel-staging review to run a full review once again.

Earlier reviews

Review of 59b2272d · 16.11.2026 16:23 UTC

Apex Sentinel · ✅ Approve

Since the last review: 0 new · 0 still open · 0 no longer raised

No open findings.

Not in the reviewers' prompt (6 files)
  • scripts/help-conformance-cases.mjs: no reviewer was selected for this change
  • skills/agent-device/SKILL.md: no reviewer was selected for this change
  • skills/dogfood/SKILL.md: no reviewer was selected for this change
  • src/commands/schema/cli-help-first-screen.test.ts: no reviewer was selected for this change
  • src/commands/schema/cli-help-workflows.ts: no reviewer was selected for this change
  • website/docs/docs/agent-setup.md: no reviewer was selected for this change

Reviewed with this repository's own Sentinel configuration (244d1ff68344).

Review of 35230e29 · 16.11.2026 16:03 UTC

Apex Sentinel · ✅ Approve

No open findings.

Not in the reviewers' prompt (6 files)
  • scripts/help-conformance-cases.mjs: no reviewer was selected for this change
  • skills/agent-device/SKILL.md: no reviewer was selected for this change
  • skills/dogfood/SKILL.md: no reviewer was selected for this change
  • src/commands/schema/cli-help-first-screen.test.ts: no reviewer was selected for this change
  • src/commands/schema/cli-help-workflows.ts: no reviewer was selected for this change
  • website/docs/docs/agent-setup.md: no reviewer was selected for this change

Reviewed with this repository's own Sentinel configuration (244d1ff68344).

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 6 files

You’re at about 96% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread skills/agent-device/SKILL.md Resolved
Comment thread skills/dogfood/SKILL.md Resolved
Comment thread scripts/help-conformance-cases.mjs Resolved
Comment thread skills/agent-device/SKILL.md Resolved
@thymikee
thymikee force-pushed the feat/static-accessibility-audit-v2 branch from d2c380d to 521a20b Compare November 16, 2026 16:13
@thymikee
thymikee force-pushed the docs/dogfood-platform-checks branch from 35230e2 to 59b2272 Compare November 16, 2026 16:22
@thymikee
thymikee force-pushed the feat/static-accessibility-audit-v2 branch from 521a20b to 2e90b57 Compare November 16, 2026 16:42
@thymikee
thymikee force-pushed the docs/dogfood-platform-checks branch from 59b2272 to aadf30b Compare November 16, 2026 16:55
@thymikee

Copy link
Copy Markdown
Member Author

I found nothing that blocks this change at 59b2272. All 17 checks are green and there are no conflicts. The delta is read against the base head 2e90b57, since the audit code lives only in open PR #4592.

Not blocking, take or leave: the audit line in skills/agent-device/SKILL.md:18 has no support or trigger condition, and Vega has no snapshot (commands.md:340), so you could prefix it with "When the platform supports snapshot, and after a screen change,". The sentence in skills/dogfood/SKILL.md:27 holds two instructions, so you could split it, and do the same for the first line of Platform checks in the help. The comment at scripts/help-conformance-cases.mjs:149 says audit on the initial screen, but the regex matches an audit line anywhere in the plan, so "plans an audit" would be accurate.

The open review thread on the missing Vega condition (#4600 (comment)) still apply, as do the three lower-priority threads on the same notes. The thread at #4600 (comment) does not apply: audit keeps the ref frame and issues only a partial publication, so snapshot refs stay valid after it. You can resolve that one.

This can merge after base #4592 lands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant