Repository navigation
refactor(capture-kit): share the snapshot tree helpers outside Android presentation - #4594
Conversation
…d presentation Move the platform-neutral snapshot tree helpers out of the Android presentation module to packages/capture-kit/src/snapshot/snapshot-tree.ts and update the two Android importers. Pure move; no behaviour change.
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
No issues found across 3 files
You’re at about 96% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Apex Sentinel · ✅ ApproveNo open findings. Reviewed with this repository's own Sentinel configuration ( 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment |
|
I found no problems in 64b9e4e, and all 20 checks pass. There are no conflicts, and nothing else needs to happen before merge. Not blocking: the helpers in |
Summary
Move the platform-neutral snapshot tree helpers (
findAncestor,ChildrenByParent,buildChildrenByParent,collectDescendants,markNodeAndDescendantsForRemoval) frompackages/capture-kit/src/snapshot/snapshot-presentation/android/tree.tstopackages/capture-kit/src/snapshot/snapshot-tree.ts. Update the two Android presentation importers. No Android-specific code was left behind: every export of the old module is platform-neutral.Touched files: 3 (1 rename, 2 import updates). Pure move, no behaviour change.
This prepares #4592: the cross-platform static accessibility audit must not import an Android presentation module for these helpers.
Validation
64b9e4e02f8701a76e7373d9c4f6c74a9f7bf979pnpm check:affected --run --head 64b9e4e02f: all runnable checks passed (format, lint, typecheck, layering, fallow, build, vitest-related, unit), receiptexactCommit: true.git diff -M90% --stat origin/main...HEADshows the rename with 0 content changes plus two import-line updates.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.