Skip to content

test: isolate ps fixtures from host proc identity - #4549

Merged
thymikee merged 1 commit into
0.22from
fix/v022-process-ps-fixture-isolation-20261114
Nov 14, 2026
Merged

thymikee merged 1 commit into
0.22from
fix/v022-process-ps-fixture-isolation-20261114

Conversation

@thymikee

@thymikee thymikee commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

Summary

Keep fabricated-PID ps tests independent of the host's Linux proc identity. The two fixture files now model an unreadable proc boot ID and preserve their existing ps observations. Dedicated proc-positive tests, all existing assertions and production process/signal code remain unchanged.

Two test files, 14 additions. This is a CI prerequisite for the Linux Coverage failure reported on #4535; no issue is closed. Linux causality remains unproven until hosted execution.

Validation

Base 61d027bd3f4c2b19418df2d62ddb514dad6528f8; head 8698989b5734158975e52c6552f63f1ff5640af4.

Pinned pnpm 11.17 frozen install/build passed. Exact pnpm check:affected --run --head 8698989b5734158975e52c6552f63f1ff5640af4 passed: exit 0, 42 local passes/25 hosted or manual skips, exactCommit=true, checkoutChanged=false. Initial/final clean fingerprint: 115d83d8799839bb6ba056578d6478cefd334966ad0bd48c0e7a64d6cefe95af. Receipt SHA256: 1101260ca40ffdfee42db364db60603f4b44a5c0c2ade342fbca46ee84c17d32.

Independent Apex source review found no regressions after tracing the proc/ps seam, mock lifecycle and signal-safety cases. This is source evidence, separate from local checks.

Hosted results at this head: 14 successful checks and one skipped matrix placeholder. Linux Coverage passed on Ubuntu: 2,193 files and 20,176 tests passed, with 4 files/70 tests skipped. The tested merge tree equals this head. Changed-line coverage, CRAP and leak gates passed. This does not change the failed result at old #4535 head 8940075 or establish unchanged-base causality. Sentinel has no findings. Integration is queued until the active exact-base review finishes; nothing merged.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

View guided diff Turn on auto-fix

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

You’re at about 90% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

View guided diff | Turn on auto-fix | Re-trigger cubic

@github-actions

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 6.28 MB 6.28 MB 0 B
Package (unpacked) 6.27 MB 6.27 MB 0 B
Package (download) 1.90 MB 1.90 MB +9 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 26.4 ms 23.6 ms -2.8 ms
CLI --help 49.2 ms 55.4 ms +6.3 ms

@apex-sentinel-staging

Copy link
Copy Markdown

Apex Sentinel · ✅ Approve

No open findings.

Reviewed with this repository's own Sentinel configuration (d78be6c88715).

💬 Talking to Sentinel

In a finding's thread, reply with:

Command What it does
@apex-sentinel-staging note <context> Adds context; Sentinel re-checks the cited code
@apex-sentinel-staging pivot <why> Says the finding is wrong; Sentinel re-checks the cited code
@apex-sentinel-staging like Marks the finding as useful
@apex-sentinel-staging dislike <why> Marks it as not useful, so it is not raised again

On this conversation, comment @apex-sentinel-staging review to run a full review once again.

@thymikee
thymikee merged commit 41d11fe into 0.22 Nov 14, 2026
15 checks passed
@thymikee
thymikee deleted the fix/v022-process-ps-fixture-isolation-20261114 branch November 14, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant