Repository navigation
test: isolate ps fixtures from host proc identity - #4549
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
No issues found across 2 files
You’re at about 90% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Contributor
Size Report
Startup median (7 runs, lower is better):
|
Apex Sentinel · ✅ ApproveNo open findings. Reviewed with this repository's own Sentinel configuration ( 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment |
This was referenced Nov 14, 2026
thymikee
added a commit
that referenced
this pull request
Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep fabricated-PID ps tests independent of the host's Linux proc identity. The two fixture files now model an unreadable proc boot ID and preserve their existing ps observations. Dedicated proc-positive tests, all existing assertions and production process/signal code remain unchanged.
Two test files, 14 additions. This is a CI prerequisite for the Linux Coverage failure reported on #4535; no issue is closed. Linux causality remains unproven until hosted execution.
Validation
Base
61d027bd3f4c2b19418df2d62ddb514dad6528f8; head8698989b5734158975e52c6552f63f1ff5640af4.Pinned pnpm 11.17 frozen install/build passed. Exact
pnpm check:affected --run --head 8698989b5734158975e52c6552f63f1ff5640af4passed: exit 0, 42 local passes/25 hosted or manual skips, exactCommit=true, checkoutChanged=false. Initial/final clean fingerprint:115d83d8799839bb6ba056578d6478cefd334966ad0bd48c0e7a64d6cefe95af. Receipt SHA256:1101260ca40ffdfee42db364db60603f4b44a5c0c2ade342fbca46ee84c17d32.Independent Apex source review found no regressions after tracing the proc/ps seam, mock lifecycle and signal-safety cases. This is source evidence, separate from local checks.
Hosted results at this head: 14 successful checks and one skipped matrix placeholder. Linux Coverage passed on Ubuntu: 2,193 files and 20,176 tests passed, with 4 files/70 tests skipped. The tested merge tree equals this head. Changed-line coverage, CRAP and leak gates passed. This does not change the failed result at old #4535 head
8940075or establish unchanged-base causality. Sentinel has no findings. Integration is queued until the active exact-base review finishes; nothing merged.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.