Repository navigation
Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 12 files
You’re at about 90% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Apex Sentinel · ✅ ApproveSince the last review: 1 new · 0 still open · 1 no longer raised 1 finding(s): 1 minor. 🟡 Minor (1)
Reviewed with this repository's own Sentinel configuration ( 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment Earlier reviewsReview of
|
| Where | Finding |
|---|---|
scripts/release-plan.mjs:52 |
0.22 nightlies stop the moment main's stable release passes 0.22.0 |
1 finding below minor hidden (user_settings.min_severity).
1 new finding away from what changed since 3ea1e40 not shown. Comment @apex-sentinel-staging review for a full review.
Reviewed with this repository's own Sentinel configuration (d78be6c88715).
Review of 3ea1e405 · 14.11.2026 12:41 UTC
Apex Sentinel · ✅ Approve
1 finding(s): 1 minor.
🟡 Minor (1)
| Where | Finding |
|---|---|
scripts/release-plan.mjs:156 |
assertAheadOfStable rejects a 0.22 nightly while main holds that release |
1 finding below minor hidden (user_settings.min_severity).
Reviewed with this repository's own Sentinel configuration (d78be6c88715).
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on 3ea1e40. The verdict and the full list are in the summary comment.
There was a problem hiding this comment.
Apex Sentinel: 1 finding moved to a new line on ae654e8. The verdict and the full list are in the summary comment.
|
I found two problems at ae654e8 that need a fix before this can merge. The 0.22 nightly is published by
Not blocking, and you can take or leave these: (1) Would one exported CodeQL reports 4 high alerts, all on lines this PR adds or makes reachable: On the open threads: the one on the stable-version guard still applies and is the second problem above, and the one on tag suffix acceptance still applies as hardening (note 5). The thread on the daily cron firing twice does not apply: each cron fires once per UTC day, the unchanged-SHA skip covers a repeat, and a second same-day publish needs a manual Before merge, push e9d4741 and settle the provenance stance for nightly-0.22. Then either show that |
|
Verified local evidence for unpublished candidate 443d483, based on published ae654e8:
Independent source/security delta recheck is still running; no new-head hosted/security or activation clearance follows from these local results. Current published AE654 CodeQL failure remains red. #4546 is now merged into 0.22 as 0081f61; successful ci.yml push CI at that exact SHA remains a separate activation requirement. No tags, publication, dispatch or external policy changes occurred. |
|
Exact-head evidence for 48bad16:
Source prerequisite #4546 is integrated and exact resulting 0.22 push CI succeeded: https://github.com/callstack/agent-device/actions/runs/43607376172 New-head hosted/security admission remains pending. The four HIGH CodeQL failures at ae654 remain recorded; independent model-gap assessments do not suppress or waive them. No activation, npm publication, tag, dispatch or external policy change occurred. |
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on 48bad16. The verdict and the full list are in the summary comment.
|
Thanks for the update. At 48bad16 the other reviewers' inline threads are addressed, but the nightly-0.22 provenance problem from the earlier review is still open, and so are the CodeQL alerts. A nightly-0.22 run executes the publish job with CodeQL still fails with four HIGH cache-poisoning alerts, at release.yml lines 107, 113 and 119 and Not blocking, and fine to take or leave: in a scheduled run, readRun waits for settled CI before the npm-day skip, which only needs The PR now adds four more per-channel special cases: the The local suites and the RED/GREEN runs were not rerun here, and the 0.22 push CI run was not opened. I judged the planner changes from the diff against ae654e8. For the other threads: matchNightlyVersion channel suffix, npm-day skip and assertAheadOfStable on main only are fixed at this head, so you can resolve them. The merge-commit build thread is benign: on pull_request Before merge, please settle the nightly-0.22 provenance question and close the four CodeQL alerts with evidence. |
Summary
Add a separate 0.22 nightly at 01:53 UTC through the existing main-owned release workflow. Preserve main's 01:23 nightly, stable/latest behavior, permissions and private packages. Twelve files, 703 gross lines. Source prerequisite #4546 is integrated; exact 0.22 push CI passed.
The maintenance channel keeps exact source-SHA/green-push-CI admission, its own version suffix, dist-tag, daily deduplication and concurrency. Main retains its ahead-of-stable guard. Documentation describes the stamping entrypoint and source-owned helpers precisely.
Validation
Published head 48bad16. Direct pnpm 11.17.0 frozen install/build passed. One intended RED: 9 failed/40 passed; identical GREEN: 49 passed, same environment/two workers/fixed child clock. This is runtime-boundary regression evidence, not an independent reproduction of the old clock race.
One exact affected gate passed: 42 local checks/25 skips, exit 0, exactCommit=true, checkoutChanged=false, matching clean fingerprints, default origin/main and merge base d78be6c. Parent verified 147 evidence files and original/copy receipt/archive hashes. Full validation evidence.
Independent source/prose/test-design/security rechecks found NO FINDINGS at this head; prior low findings and documentation nit are fixed. CodeQL at this exact head failed with four HIGH cache-poisoning alerts, matching the previously reviewed annotations. Independent cache-model-gap assessments do not waive this failed check. Activation remains blocked pending security disposition; other hosted lanes remain unconfirmed here. Size passed: +44 B installed/unpacked, +16 B download; no performance clearance is claimed. No npm publication, tags, dispatch or external policy changes occurred.