Repository navigation
ci: prepare 0.22 source version and push CI for nightly releases - #4546
Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
No issues found across 12 files
You’re at about 90% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Apex Sentinel · ✅ ApproveSince the last review: 1 new · 0 still open · 0 no longer raised 1 finding(s): 1 minor. 🟡 Minor (1)
Reviewed with this repository's own Sentinel configuration ( 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment Earlier reviewsReview of
|
|
This PR is ready: I found no problems in the code at 0d970bd. Hosted CI is still running (Smoke Tests (macos) and one review check), and the diff touches nothing those runs exercise: it changes version strings, the push trigger list in ci.yml, one notifier tag branch for |
0d970bd to
fd8d23e
Compare
|
Exact rebased prerequisite evidence at fd8d23e, actual 0.22 base 41d11fe:
Published with an explicit old-head lease. New-head hosted checks remain pending, and the old head's 19-success/2-skip set is not inherited. After integration, require successful ci.yml push CI on the resulting exact 0.22 SHA. #4545 owns activation separately; its CodeQL failure and source corrections are not cleared here. No publishing, tags, dispatch, npm trust or external policy changes occurred. |
|
I reviewed fd8d23e and found no code problems. The patch is byte-identical to the head I reviewed earlier (0d970bd), so that earlier review still applies. The hosted checks on fd8d23e are still running, including Smoke Tests (ios), Smoke Tests (macos) and one review check, and none has failed. This change touches only tests, version, docs and CI triggers, plus the update-check dist-tag mapping, so it does not reach the device, runner or daemon code those smoke jobs exercise. I did not re-run check:affected and relied on the 42/25 result you reported. I read #4545 only as its diff at ae654e8, and I could not check the channel strings against the newer unpublished candidate 443d483. The strings here match the published head. Please wait for the hosted checks on fd8d23e to pass. Then please confirm push CI is green on the exact 0.22 SHA before #4545 activates. |
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on fd8d23e. The verdict and the full list are in the summary comment.
Summary
Prepare 0.22 for its separate nightly channel: enable push CI, synchronize public/MCP development versions to 0.22.0-dev, and route update notices to nightly-0.22. Twelve files, 58 additions/13 deletions. Private packages stay unchanged. This prerequisite activates no publishing.
Validation
Head fd8d23e, base 0.22 at 41d11fe after #4549. Independent source/design/prose recheck: NO FINDINGS; the single patch is byte-identical to the prior reviewed patch.
Fresh pinned pnpm 11.17 frozen install/build passed. Exactly once, pnpm check:affected --run --head fd8d23e exited 0: 42 passed, 25 skipped, exactCommit=true, checkoutChanged=false, matching clean fingerprints. Detailed evidence and receipt hashes.
Current-head hosted results: 19 SUCCESS, 2 SKIPPED, none pending or failing; Coverage, Integration and Apple smoke passed. Skipped matrix entries do not prove a full mutation sweep.
The updater finding was rejected with the actual pinned producer/stamper trace: main-owned #4545 supplies the distinct channel version and version tooling; this prerequisite activates no publisher.
After integration, require green push CI at the resulting exact 0.22 SHA. Scheduler #4545 still has separate source-correction, validation/security and activation requirements. No nightly publication, tag, dispatch or external policy change occurred.