Skip to content

ci: prepare 0.22 source version and push CI for nightly releases - #4546

Merged
thymikee merged 1 commit into
0.22from
chore/nightly-022-source-prerequisite
Nov 14, 2026
Merged

thymikee merged 1 commit into
0.22from
chore/nightly-022-source-prerequisite

Conversation

@thymikee

@thymikee thymikee commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

Summary

Prepare 0.22 for its separate nightly channel: enable push CI, synchronize public/MCP development versions to 0.22.0-dev, and route update notices to nightly-0.22. Twelve files, 58 additions/13 deletions. Private packages stay unchanged. This prerequisite activates no publishing.

Validation

Head fd8d23e, base 0.22 at 41d11fe after #4549. Independent source/design/prose recheck: NO FINDINGS; the single patch is byte-identical to the prior reviewed patch.

Fresh pinned pnpm 11.17 frozen install/build passed. Exactly once, pnpm check:affected --run --head fd8d23e exited 0: 42 passed, 25 skipped, exactCommit=true, checkoutChanged=false, matching clean fingerprints. Detailed evidence and receipt hashes.

Current-head hosted results: 19 SUCCESS, 2 SKIPPED, none pending or failing; Coverage, Integration and Apple smoke passed. Skipped matrix entries do not prove a full mutation sweep.

The updater finding was rejected with the actual pinned producer/stamper trace: main-owned #4545 supplies the distinct channel version and version tooling; this prerequisite activates no publisher.

After integration, require green push CI at the resulting exact 0.22 SHA. Scheduler #4545 still has separate source-correction, validation/security and activation requirements. No nightly publication, tag, dispatch or external policy change occurred.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 6.28 MB 6.28 MB +27 B
Package (unpacked) 6.27 MB 6.27 MB +29 B
Package (download) 1.90 MB 1.90 MB +24 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 20.1 ms 19.4 ms -0.7 ms
CLI --help 43.0 ms 40.2 ms -2.8 ms

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 12 files

You’re at about 90% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

View guided diff | Turn on auto-fix | Re-trigger cubic

@apex-sentinel-staging

apex-sentinel-staging Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Apex Sentinel · ✅ Approve

Since the last review: 1 new · 0 still open · 0 no longer raised

1 finding(s): 1 minor.

🟡 Minor (1)

Where Finding
src/cli/update-check.ts:172 🆕 distTagFor routes real 0.22 nightlies to main's nightly tag, not nightly-0.22

Reviewed with this repository's own Sentinel configuration (d78be6c88715).

💬 Talking to Sentinel

In a finding's thread, reply with:

Command What it does
@apex-sentinel-staging note <context> Adds context; Sentinel re-checks the cited code
@apex-sentinel-staging pivot <why> Says the finding is wrong; Sentinel re-checks the cited code
@apex-sentinel-staging like Marks the finding as useful
@apex-sentinel-staging dislike <why> Marks it as not useful, so it is not raised again

On this conversation, comment @apex-sentinel-staging review to run a full review once again.

Earlier reviews

Review of 0d970bd5 · 14.11.2026 12:50 UTC

Apex Sentinel · ✅ Approve

No open findings.

1 finding below minor hidden (user_settings.min_severity).

Reviewed with this repository's own Sentinel configuration (d78be6c88715).

@thymikee

Copy link
Copy Markdown
Member Author

This PR is ready: I found no problems in the code at 0d970bd. Hosted CI is still running (Smoke Tests (macos) and one review check), and the diff touches nothing those runs exercise: it changes version strings, the push trigger list in ci.yml, one notifier tag branch for -nightly-0-22. versions, tests and docs. Not blocking, and you can take or leave these: test/ci/release-workflow.test.ts gets an append-only conflict at the end of the file when 0.22 is merged into main, because #4545 appends different tests there; distTagFor in src/cli/update-check.ts hard-codes the -nightly-0-22. infix, so a 0.23 channel would need to derive the tag from one pattern such as /-nightly-(\d+)-(\d+)\./; and the "separate activation and first successful publish" sentence in installation.md can go once the first nightly-0.22 publish lands. Next, wait for CI on this head to finish and merge into 0.22, then check that push CI is green at the merged 0.22 HEAD before #4545 merges.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Nov 14, 2026
@thymikee
thymikee force-pushed the chore/nightly-022-source-prerequisite branch from 0d970bd to fd8d23e Compare November 14, 2026 14:44
@thymikee

Copy link
Copy Markdown
Member Author

Exact rebased prerequisite evidence at fd8d23e, actual 0.22 base 41d11fe:

  • New independent Apex source/design/prose recheck: NO FINDINGS. One unchanged patch (range-diff =); full patch bytes equal 61d..0d970bd; candidate tree 7b52f1256fcd3f454d3a5de1bb0851d3b8a7d526 equals the merge of the updated base and old prerequisite.
  • Fresh pinned pnpm 11.17.0 frozen install/build: exit 0.
  • Exactly once: pnpm check:affected --run --head fd8d23e; raw exit 0, 42 passed / 25 skipped of 67 selected, FAIL-OPEN retained. exactCommit=true, checkoutChanged=false, initial/final checkout clean.
  • Matching fingerprint: 0472b690a756b983cfaec5d9ff9b1e9bf089c683a6dc66cca24e50b6a3cc582f.
  • Receipt SHA256: 196ce46b68568b2bb8ca18d6e033100167272f908b51dbbed935c9aa3e2a80c6. All 59 archived files verified; immutable archive SHA256 1457d375231c781f614a12987288b8bdba243c4c0012a1ed246321eedf6f7524.
  • Gate UTC 14:19:50.667–14:27:43.065, 2026-11-14. No lock-wait messages; actual acquisition wait unmeasured.
  • Default gate base stayed origin/main d78be6c, merge base d38e35e. Actual immediate 0.22 base above is separate.

Published with an explicit old-head lease. New-head hosted checks remain pending, and the old head's 19-success/2-skip set is not inherited. After integration, require successful ci.yml push CI on the resulting exact 0.22 SHA. #4545 owns activation separately; its CodeQL failure and source corrections are not cleared here. No publishing, tags, dispatch, npm trust or external policy changes occurred.

@thymikee

Copy link
Copy Markdown
Member Author

I reviewed fd8d23e and found no code problems. The patch is byte-identical to the head I reviewed earlier (0d970bd), so that earlier review still applies. The hosted checks on fd8d23e are still running, including Smoke Tests (ios), Smoke Tests (macos) and one review check, and none has failed. This change touches only tests, version, docs and CI triggers, plus the update-check dist-tag mapping, so it does not reach the device, runner or daemon code those smoke jobs exercise. I did not re-run check:affected and relied on the 42/25 result you reported. I read #4545 only as its diff at ae654e8, and I could not check the channel strings against the newer unpublished candidate 443d483. The strings here match the published head. Please wait for the hosted checks on fd8d23e to pass. Then please confirm push CI is green on the exact 0.22 SHA before #4545 activates.

@apex-sentinel-staging apex-sentinel-staging Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apex Sentinel: 1 new finding on fd8d23e. The verdict and the full list are in the summary comment.

Comment thread src/cli/update-check.ts Resolved
@thymikee
thymikee merged commit 0081f61 into 0.22 Nov 14, 2026
21 checks passed
@thymikee
thymikee deleted the chore/nightly-022-source-prerequisite branch November 14, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant