Repository navigation
Conversation
Size Report
Startup median (7 runs, lower is better):
|
aedf9f5 to
0315a02
Compare
|
At 0315a02, one defect failed CI, and the design needs a decision before merge. The newer head 8180363 changes only packages/replay/src/plugin.ts:4 uses Not blocking, and you can take or leave these: (1) Could this land as one layer instead of a standalone package and an unconsumed resolver? That layer would declare the native execution port in I did not run tests, typecheck, or build and pack |
8180363 to
9f1fa69
Compare
9f1fa69 to
25e621d
Compare
25e621d to
499d4bc
Compare
|
The code at 499d4bc is ready; I found no problems that need a change. Not blocking, and fine to take or leave: |
499d4bc to
3e5030d
Compare
|
Current registry head is I am retaining the small existing registry implementation rather than adding a shared create-once abstraction solely to remove similar lines. The independent smaller-design assessment accepted the three execution entrypoints and accounted for the +34.7 kB package growth (mostly declarations); it did not establish a performance win. The native ADR0034 amendment remains Proposed, pending maintainer acceptance. Exact-head affected admission passed: 42 passed / 25 skipped, exactCommit=true, checkoutChanged=false. All 19 hosted checks passed. Later source/help fixes are owned by the top routing layer, so this head has not been churned. No registry/source readiness statement here clears C3, live/platform, ADR or npm placeholder/trusted-publisher prerequisites. |
There was a problem hiding this comment.
All reported issues were addressed across 11 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
This comment has been minimized.
This comment has been minimized.
Apex Sentinel · ✅ ApproveSince the last review: 0 new · 0 still open · 1 no longer raised 1 finding(s): 1 minor. 🟡 Minor (1)
1 finding below 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment Earlier reviewsReview of
|
| Where | Finding |
|---|---|
packages/plugins/src/registry.ts:219 |
🆕 A one-off native execution create() failure permanently disables the slot, unlike backend loads |
1 finding below minor hidden (user_settings.min_severity).
Reviewed with this repository's own Sentinel configuration (d78be6c88715).
Review of 89400750 · 14.11.2026 10:19 UTC
Apex Sentinel · ✅ Approve
Since the last review: 1 new · 0 still open · 0 no longer raised
1 finding(s): 1 minor.
🟡 Minor (1)
| Where | Finding |
|---|---|
packages/plugins/src/registry.ts:209 |
🆕 resolveReplayExecution can pick another backend's slot and report invalid_plugin, not plugin-not-installed |
1 finding below minor hidden (user_settings.min_severity).
Reviewed with this repository's own Sentinel configuration (d38e35e61193).
Review of 2c5f4d13 · 14.11.2026 10:04 UTC
Apex Sentinel · ✅ Approve
Since the last review: 0 new · 0 still open · 0 no longer raised
No open findings.
Reviewed with this repository's own Sentinel configuration (d38e35e61193).
Review of 3e5030d2 · 14.11.2026 08:21 UTC
Apex Sentinel · ✅ Approve
No open findings.
3 findings below minor hidden (user_settings.min_severity).
Reviewed with this repository's own Sentinel configuration (d38e35e61193).
|
Confirmed at The lower Maestro-layer Apple setup correction is already queued in the coordinated stack refresh, so it will reach this PR too. It installs the built plugin after the shared build under a persistent job-scoped plugin home. No additional engine change or CI retry is needed for this diagnostic. Fresh hosted iOS success remains required after publication. |
3e5030d to
2c5f4d1
Compare
2c5f4d1 to
8940075
Compare
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on 8940075. The verdict and the full list are in the summary comment.
|
I reviewed 8940075 and found no code problems. The earlier review of 3e5030d (#4535 (comment)) found the code clean, and the code commits are unchanged since then. The new commit 8940075 only reverts the ADR changes, and ADR 0034 now matches base. Hosted CI is unclear. Coverage failed and ten jobs were cancelled, which fits a superseding push. I could not read the Coverage failure, so I cannot say whether it relates to this PR. I also did not rerun tests locally. Please rerun CI on 8940075 and check the Coverage result. On the open threads: the minor thread about the package-name fallback in the registry still holds (#4535 (comment)). It is not urgent, because Before merge, CI must pass on 8940075 and the two moot threads must be resolved. The maintainer's native-contract acceptance, which the PR names as a merge condition, is still needed. I could not confirm the preserved proposal text in #3871 beyond your reply. |
8940075 to
f390132
Compare
|
This PR is ready at f390132. The earlier review of 8940075 found no problems, and the fallback by package name is now limited to slots with no backend and a recorded failure. The test 'a package name cannot select an active foreign backend for native execution' covers it. Tests were not run locally. I checked this by reading the code. Not blocking: a rejected native The open inline thread on registry.ts:322-343 is fixed at this head, so you can resolve it: #4535 (comment). Two threads no longer apply because the head does not touch the ADR 0034 docs, so you can resolve them too: #4535 (comment) (outdated amendment) and #4535 (comment) (proposal removed, it lives in #3871). All checks pass at this head except Android Smoke Tests run 43638215393. It failed at step 2, assertVisible 'Maestro selection: clickable', in 'resolve duplicate target through no-index Maestro tapOn'. The diff only touches backend selection, and that selection and step 1 succeeded, so this looks unrelated. I did not compare it with a main run. Before merge, please rerun that job or show it fails the same way on main. |
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on f390132. The verdict and the full list are in the summary comment.
f390132 to
61ae277
Compare
|
This PR is ready at 61ae277. Since the earlier review (f390132), the failed-create recovery and the package-name fallback concerns are fixed in the code. Not blocking: the native lazy-load block in registry.ts is a line-for-line copy of the format lazy-load in About the open review threads: two of the threads no longer apply, because the PR no longer changes ADR 0034. Please resolve #4535 (comment) and #4535 (comment). The other two threads are fixed at this head (failed I did not run the tests, so the affected and full check counts in the description are unverified. CI on this head was cancelled for 13 jobs, which looks like a superseded stacked push. One Smoke Tests job failed in run 43662183448. I did not open its log, but it looks unrelated: |
Summary
Introduce optional replay execution registry contracts for #3871, preserving backend identity, transient recovery and disposal fencing.
Unpublished candidate:
8f2ac64f935d4fbf740c5de02d3c5a8b779a5a6e. 12 files / 385 gross lines above DATA; 333 / 9,141 against default-main merge-base.Validation
Independent Codex recheck found no actionable findings within the R1 repair and preservation interactions. The two-file repair survives all four rebases; eight range-diff entries match.
At
8f2ac64f935d4fbf740c5de02d3c5a8b779a5a6e, pinned frozen install/build and full-repository format passed. Exact affected: 42 passed / 25 skipped,exactCommit=true,checkoutChanged=false; receiptc43ad7c22d01eeea3b699e4c88499cf6311aa0c8f6c5d054845884880284093e.All seven new-head canonical invocations passed once, serially, under one frozen ENV. Counts overlap; skips retain their CI/manual owners. Existing refs stayed unchanged; source/logical index matched before and after each gate. Physical-index captures remain separate, with within-head byte-change causes unproven. Initial/final snapshots cannot exclude transient edits.
The candidate remains unpublished; published head
61ae2772is unchanged and new-head hosted checks are unverified. Node22.13 packaging and earlier ENV/ref owner dispositions still block source publication. Both plugins remain private pending maintainer placeholders, trusted publishers and usable publication. Native ADR, live/current-client, performance and security remain open. No merge clearance.