Repository navigation
Conversation
Size Report
Startup median (7 runs, lower is better):
|
33d14c8 to
cf03d03
Compare
cf03d03 to
7a799d9
Compare
7a799d9 to
08ce68f
Compare
|
I reviewed 08ce68f. The code has two problems to fix before merge. CI is green at this head: the 12 non-passing jobs in the first run were cancelled, and the same jobs pass in the re-runs. Smoke Tests and the Mutants matrix were skipped, so they give no device signal. There are no conflicts. The Maestro help still tells agents to install only Native Not blocking, take or leave: This review is from reading the code. I did not run tests or the packed smoke, and I did not reproduce the earlier-commit claims (tree identity with 7a799d9, 1,714 focused tests, seven packed checks, 31 repaired hosted cases). I did not trace the composite-resource-admission fixture, the CI gate action changes or the install-workspace-replay-plugins script in depth. Whether ADR 0034's proposed native amendment is accepted is a maintainer decision outside this review. Before merge, the Maestro help must state the |
08ce68f to
67c0e73
Compare
|
Thanks for the update. I re-read the changes at 67c0e73 against the earlier review (#4537 (comment)). Two findings from that review remain, and the other earlier findings are now addressed. CI is green. The 12 jobs that first showed as not passing were cancelled runs, and all 12 passed in their re-runs. Smoke Tests and the Mutants matrix were skipped, so CI gives no device signal for the plugin execution route. I reviewed by reading the code. I did not run the new daemon-composition-replay-selection tests or the packed smoke. I reasoned about the four custom replace/remove cases from the earlier code path and did not run them against the old code. No conflicts. The Maestro help still tells agents to install only No run yet shows a device-facing route working through the plugin-provided engine (native-command.ts#L91). The PR body still lists live Android and iOS verification as pending. Please install Before merge, the Maestro help must name |
67c0e73 to
5fe9441
Compare
|
Thanks for the update. At 651a68b, two findings from the earlier review (#4537 (comment)) are still open: the The Native replay and test suites now route through the plugin execution (native-command.ts#L91, test-command.ts:199). The PR body claims no device run, and Smoke Tests were skipped. Nothing yet shows that a device replay works through the plugin engine, or that the plugin-absent refusal happens before a session exists. Please attach these runs: (1) Not blocking, take or leave: I read the code and did not run any tests, including command-tools-parity, cli-startup-import-closure, the installed-package-metro consumer, or the packed smokes. I did not re-trace the client-side Maestro collection route or the "core clients can send .ad sources" sentence, since they moved verbatim and the earlier review covered them. I compared the help text before and after by reading it, not by a run. |
|
Fixed the Maestro prerequisite finding in e567c5b. The existing help test failed on the missing native install command before the fix. Committed focused results: 1,019 passed across eight files, including all eager-closure roots and MCP text policy. Format, lint/typecheck, build and layering passed. Seven actual packed checks passed. The new Maestro-only packed embedded request uses the real factory and current client: {"code":"INVALID_ARGS","details":{"reason":"plugin-not-installed","package":"@agent-device/replay","installCommand":"agent-device plugins add @agent-device/replay"}}Sessions are empty before and after. This is a device-free packed embedded admission check, not an installed-store live device run. Client source collection may create Maestro's backend before daemon admission; I removed an incorrect test assumption that no backend could be created. No execution or session success is inferred from collection. For the outstanding live requests, here are actual retained outputs at 67c0e73, not a new execution at e567: {"backend":"ad","source":"store","package":"@agent-device/replay","version":"0.0.0","state":"active"}
{"nativeResume":{"success":true,"replayed":14,"healed":0,"sessionActive":false}}
{"nativeSuite":{"passed":0,"failed":1,"attempts":1}}
{"maestroReplay":{"success":true,"replayed":5,"healed":0,"sessionActive":true}}The native package was explicitly installed from its real tarball (SHA256 Android native replay and a passing two-test retry suite remain unproven. Recording's HTTP restriction exists in current code as well as the old bound client. I have not bypassed T3 with an unbound device CLI, retried stopped device paths, changed assertions or called these partial results full clearance. Evidence: |
There was a problem hiding this comment.
All reported issues were addressed across 69 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Apex Sentinel · ✅ ApproveSince the last review: 1 new · 0 still open · 0 no longer raised 1 finding(s): 1 minor. 🟡 Minor (1)
Not in the reviewers' prompt (1 file)
Reviewed with this repository's own Sentinel configuration ( 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment Earlier reviewsReview of
|
| Where | Finding |
|---|---|
packages/replay-port/src/daemon-port/replay-plugin-admission.ts:17 |
Missing replay plugin still hides the explicit --maestro routing hint for .yaml test inputs |
Not in the reviewers' prompt (1 file)
pnpm-lock.yaml: generated or a lockfile, so its lines were left out
Reviewed with this repository's own Sentinel configuration (d38e35e61193).
Review of 153a1279 · 14.11.2026 10:07 UTC
Apex Sentinel · ✅ Approve
Since the last review: 0 new · 1 still open · 0 no longer raised
1 finding(s): 1 minor.
🟡 Minor (1)
| Where | Finding |
|---|---|
packages/replay-port/src/daemon-port/replay-plugin-admission.ts:20 |
Missing replay plugin still hides the "requires explicit --maestro routing" hint for .yaml input |
Not in the reviewers' prompt (1 file)
pnpm-lock.yaml: generated or a lockfile, so its lines were left out
2 findings below minor hidden (user_settings.min_severity).
Reviewed with this repository's own Sentinel configuration (d38e35e61193).
Review of e567c5ba · 14.11.2026 08:22 UTC
Apex Sentinel · ✅ Approve
1 finding(s): 1 minor.
🟡 Minor (1)
| Where | Finding |
|---|---|
packages/replay-port/src/daemon-port/replay-plugin-admission.ts:20 |
Missing replay plugin hides the "requires explicit --maestro routing" hint for .yaml input |
Not in the reviewers' prompt (1 file)
pnpm-lock.yaml: generated or a lockfile, so its lines were left out
1 finding below minor hidden (user_settings.min_severity).
Reviewed with this repository's own Sentinel configuration (d38e35e61193).
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on e567c5b. The verdict and the full list are in the summary comment.
|
Both new device-job failures are now traced to missing plugin installation, not assumed infrastructure faults:
The C3 Android workflow fix is locally committed: select an isolated AGENT_DEVICE_HOME and invoke its existing built-workspace installer after build and before daemon startup. When restacked here, that call uses the existing combined replay-plugin installer. I also prepared Apple workflow setup after successful shared build, exporting the same isolated plugin home to subsequent iOS/macOS phases. Linux already routes execution through run-gate, whose declared execution-gate setup installs the real plugins; no Linux change is proposed. No scenario/assertion/timeout/selector fallback or product auto-install is added. Separately, the exact e567 local affected and full gates both passed once: 42/25 and 41/25, exactCommit=true, checkoutChanged=false, clean fingerprints. I independently verified both raw receipts and 113 original/copy SHA-256 pairs in the immutable report. These do not clear either hosted device failure. Corrections will be published with the coordinated stack refresh after the integration candidate is validated and the active source review is preserved. The current failed jobs will not be blindly rerun. This PR stays ready for review. |
|
I reviewed e567c5b against the earlier findings (#4537 (comment)). The smoke jobs still fail because of this stack, and the native device evidence is still missing. The smoke jobs start a daemon with an empty plugin store, but replay and test now need the installed plugins ( The second finding from the earlier review still stands. Native replay and test suites now run through the @agent-device/replay plugin (https://github.com/callstack/agent-device/blob/e567c5b/packages/replay-port/src/daemon-port/native-command.ts#L91). The only live runs I could see are iOS-only partial results at 67c0e73: the full replay failed at Catalog selection, the suite passed 0 and failed 1, and only a Not blocking: the help path at cli-help.ts:887 passes the same ad installation twice to Open threads still apply on #4537 (comment) (private package, docs install) and #4537 (comment) (ADR 0016 scope). Eight lower-priority threads also still apply. One thread does not apply, so please resolve it: #4537 (comment) (the empty backend is consistently treated as native). CI looks related to this change, since the failing jobs run replay and test on a booted device. No conflicts. Before merge, the shared plugin install needs to land with the smoke jobs green, and the live Android and iOS runs need to be attached. |
e567c5b to
153a127
Compare
There was a problem hiding this comment.
All reported issues were addressed across 20 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
153a127 to
3c32e14
Compare
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
Thanks for the update. At 3c32e14 the code looks right, but I still can't see live proof for the new route. I read the code and did not run any test, gate, installer or packed smoke. Since the earlier review (#4537 (comment)), the docs now say both plugin packages are private and unpublished, the ADR scope and the Maestro requirement are fixed, the empty backend is refused, and the nightly and prepack install steps are fixed. Two points remain: live validation and the CI installer step. Native replay and every test suite now run only through the installed The previous review asked for one owned installer step, but the delta added inline installer calls at android.yml#L96 and apple.yml#L88. This copy-per-site approach already misses a site. The Not blocking, and you can take or leave these: the unrouted-YAML refusal now exists in three places with the same predicate and message (admission.ts#L27, native-command.ts:81-82, source-discovery.ts:87-88), and Could both collapses be done together? (a) One ad-script function returns the route or throws the typed routing error (unknown or empty backend, YAML without All 13 non-passing checks at 3c32e14 are cancelled, not failed, so there is no failure to attribute. The delta changes the route that Smoke Tests exercise, so those jobs need to rerun to completion before the smoke lanes count as fixed. I did not check whether the cancellations came from a newer push or a manual cancel. I also did not trace every gate id to confirm the run-gate install list covers all gates that start a daemon; I only grepped workflow and script call sites. There are no conflicts. Before merge, please attach the live Android and iOS plugin-route evidence at this head with Smoke Tests (Android) and (ios) green, and fold the per-workflow installer copies into one owned step that also covers On the open inline threads: the thread on redundant macOS installs still holds (#4537 (comment)), and it folds into the single installer step above. No other blocking thread still applies. These threads do not apply and can be resolved: admission order for suites, because every suite needs |
3c32e14 to
2e40c35
Compare
|
At 2e40c35 the routing fixes from the earlier review (#4537 (comment)) are in: Native Hosted Android Smoke (run 43638214672) fails in Not blocking, and you can take or leave these: four install sites still remain ( Could one The open inline thread on the macOS double install (r4572890870) still applies and is covered by the install note above. These two are fixed at this head and can be resolved: r4572985095 (admission now refuses YAML without maestro before Before merge, this needs live Android and iOS evidence for the plugin route at this head, or green Smoke Tests (Android, reaching the native |
Land the native plugin with its routing consumer, installation, workflows and package guards. Retain C3 rejected-load retry and inventory ownership with typed repair guidance; preserve lower-layer slot identity and refuse raw YAML suites before plugin or device admission.
2e40c35 to
ce66416
Compare
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on ce66416. The verdict and the full list are in the summary comment.
|
This PR is ready at ce66416, and the findings from the earlier review (#4537 (comment)) are now fixed. I read the code and the hosted logs. I did not run any test, gate or packed smoke myself. The checks show green on this head: Android 43662183826, Apple 43662183827 (iOS and macOS), Linux 43662183807, CI 43662183783 and mutants 43662183833 all pass. The failed Apple run and cancelled mutants run in the list belong to a duplicate run set that concurrency superseded on the same head. The smoke lanes reach 01-settings.ad natively on iOS and Android, so the routes this diff touches are covered. The plugin-absent refusals are pre-device daemon refusals, and request-router-replay-plugin.test.ts covers them through the router handler. Not blocking, and you can take or leave it: the PR body says the Apple and mutation jobs were cancelled with no replacement result, so please update the Validation section to link the green Android 43662183826 and Apple 43662183827 runs. There are no conflicts. The one open inline thread, #4537 (comment), does not apply: the check in packages/replay/src/plugin.ts accepts any 0.22.* version, and the declared range '>=0.22.0-0 <0.23.0' admits 0.22.0-alpha.1 under semver, so the check and the range agree, and you can resolve it. Before merge, publish @agent-device/replay and @agent-device/maestro (npm placeholders and trusted publishers) and lift |
Summary
Route optional replay/test execution through the plugin for #3871, preserving typed admission and lightweight installation disclosure.
Unpublished candidate:
0f8af82402c5888d519d2fd0055f6bd1c2451de8. 74 files / 1,884 gross lines above REG; 360 / 10,741 against default-main merge-base.Validation
Independent Codex recheck found no actionable findings within the R1 repair and preservation interactions. The two-file repair survives all four rebases; eight range-diff entries match.
At
0f8af82402c5888d519d2fd0055f6bd1c2451de8, pinned frozen install/build and full-repository format passed. Exact affected: 42 passed / 25 skipped,exactCommit=true,checkoutChanged=false; receiptb9a5914cf6f0ad62b03b8d625d73c7e7ca63244135c2a4b75deab89033effc8f. Full: 41 passed / 25 skipped; receiptd97914929e672223a48821374649a841571a99e69e62ad6b33e9c3749e186ab4.All seven new-head canonical invocations passed once, serially, under one frozen ENV. Counts overlap; skips retain their CI/manual owners. Existing refs stayed unchanged; source/logical index matched before and after each gate. Physical-index captures remain separate, with within-head byte-change causes unproven. Initial/final snapshots cannot exclude transient edits.
The candidate remains unpublished; published head
ce66416fis unchanged and new-head hosted checks are unverified. Node22.13 packaging and earlier ENV/ref owner dispositions still block source publication. Both plugins remain private pending maintainer placeholders, trusted publishers and usable publication. Native ADR, live/current-client, performance and security remain open. No merge clearance.