Repository navigation
chore: move CI and @types/bun to Bun 1.4.4 - #185
Conversation
CI jobs ran Bun 1.4.3, so tests never exercised the 1.4.4 runtime that hosts now use. The unit tests, formatter, linter and bun --check all pass locally on 1.4.4 (1295 pass, 7 skip, 0 fail).
|
@coderabbitai full review |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
bompus has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Description check |  |
The description explains the change and reports local validation results, but it omits all required template checklist items for README checks, the changelog requirement, and private-information confi… | Add the three required checklist items from the repository template and mark each item accurately. State whether a CHANGELOG.md entry is required, confirm that the README Development checks pass, and confirm that the change contains no priv… |
-
Check name Status Explanation Title check The title clearly identifies the main change: updating CI and @types/bunto Bun 1.4.4.Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Suppressions Explained The pull request changes only Bun versions in CI and dependency versions in package.json and bun.lock. No changed line adds or broadens a lint, type-check, or formatter suppression directive or ignore… Interface Changes Documented The pull request changes only Bun versions in .github/workflows/ci.ymland dependency metadata inpackage.jsonandbun.lock. It does not add, remove, or rename an MCP tool or argument, a `swarma…Full details: Suppressions Explained
-
Explanation
The pull request changes only Bun versions in CI and dependency versions in package.json and bun.lock. No changed line adds or broadens a lint, type-check, or formatter suppression directive or ignore entry.
Full details: Interface Changes Documented
-
Explanation
The pull request changes only Bun versions in
.github/workflows/ci.ymland dependency metadata inpackage.jsonandbun.lock. It does not add, remove, or rename an MCP tool or argument, aswarmailcommand or flag, or an environment variable. The documentation condition is therefore not triggered.
-
Full details: Description check
-
Explanation
The description explains the change and reports local validation results, but it omits all required template checklist items for README checks, the changelog requirement, and private-information confirmation.
Resolution
Add the three required checklist items from the repository template and mark each item accurately. State whether a CHANGELOG.md entry is required, confirm that the README Development checks pass, and confirm that the change contains no private project, local path, home directory, or credential references.
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
✅ Action performedFull review finished. |
CI ran Bun 1.4.3 while hosts moved to 1.4.4, so the test jobs never exercised the runtime we actually use. This pins both CI jobs to 1.4.4 and bumps `@types/bun` (and its `bun-types` dependency) to match.
Checked locally on Bun 1.4.4: `bun run check` (formatter, linter, `bun --check`) passes and `bun test` gives 1295 pass, 7 skip, 0 fail. That includes the WebSocket wake paths, whose close and error behavior changed in 1.4.4.
`bun-types@1.4.4` is under the three-day release-age gate until 2026-10-25; `@types/bun` is excluded but its dependency is not, so the bump used a one-off `--minimum-release-age-excludes` and `bunfig.toml` is unchanged.
Summary by cubic
CI ran Bun 1.4.3 while hosts moved to 1.4.4, so test jobs never exercised the runtime we actually use. This pins both CI jobs to 1.4.4 and bumps
@types/bun(and itsbun-typesdependency) to match.Verified locally on 1.4.4:
bun run checkpasses andbun testgives 1295 pass, 7 skip, 0 fail, including the WebSocket wake paths whose close and error behavior changed in 1.4.4. The update uses a one-off--minimum-release-age-excludesbecausebun-types@1.4.4is under the three-day release-age gate until 2026-10-25;bunfig.tomlis unchanged.Written for commit f5fd07a. Summary will update on new commits.
Summary by CodeRabbit