Skip to content

Preserve picture rotation while reading DOCX - #920

Merged
bokuweb merged 1 commit into
bokuweb:mainfrom
developer0hye:fix/read-picture-rotation
Sep 5, 2026
Merged

Preserve picture rotation while reading DOCX#920
bokuweb merged 1 commit into
bokuweb:mainfrom
developer0hye:fix/read-picture-rotation

Conversation

@developer0hye

Copy link
Copy Markdown
Contributor

Summary

  • parse a:xfrm rot while reading DrawingML pictures
  • normalize the OOXML angle and round it to the nearest whole degree supported by Pic.rot
  • add regression coverage for the 20933656 angle used by the office2pdf event-poster fixture

This prevents picture rotation from being reset to zero when a DOCX is read.

Validation

  • red regression test: left: 0, right: 349
  • RUSTUP_TOOLCHAIN=1.88.0 cargo fmt --all -- --check
  • RUSTUP_TOOLCHAIN=1.88.0 make test (361 unit, 41 integration, 21 reader, 1 WASM, and doctests passed)
  • RUSTUP_TOOLCHAIN=1.88.0 make lint
  • git diff --check

Related: developer0hye/office2pdf#1366

Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>

@bokuweb bokuweb left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bokuweb
bokuweb merged commit 03b1e91 into bokuweb:main Sep 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants