fix: preserve parsed picture rotation - #4
Merged
developer0hye merged 1 commit intoAug 30, 2026
Conversation
Signed-off-by: Yonghye Kwon <developer.0hye@gmail.com>
Owner
Author
|
The branch-specific implementation is validated by both build and Clippy jobs, and the new picture-rotation parser test passes locally on Rust 1.81. The remaining CI failures reproduce on the unchanged
Upstream bokuweb#920 runs the same parser change against current upstream and all four CI jobs pass. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
a:xfrm rotwhile reading DrawingML picturesPic.rot20933656 -> 349This compatible backport lets office2pdf preserve the floating picture angle while upstream PR bokuweb#920 is pending.
Validation
left: 0,right: 349cargo test -p docx-rs --lib -- --test-threads=1(276 passed)rustfmt +1.81 --edition 2021 --checkgit diff --checkExisting branch baselines
cargo fmt --all -- --checkreports unrelated pre-existing formatting infit_text.rsandelements/mod.rs.make testreaches 309 passing unit tests, then 20 existing platform-sensitive snapshot mismatches; generated snapshot changes were discarded.make lintreports seven pre-existing warnings outside this change.Related: developer0hye/office2pdf#1366
Upstream: bokuweb#920