Move getExtensionList() into BaseRepository as constructor parameter#1091
Merged
bdemers merged 1 commit intofeature/filter-visitor-spifrom Apr 3, 2026
Merged
Conversation
Member
Author
|
This change is part of the following stack: Change managed by git-spice. |
bdemers
force-pushed
the
feature/filter-visitor-spi
branch
from
1a836c0 to
11ea545
Compare
bdemers
force-pushed
the
feature/extension-list-refactor
branch
from
84738ca to
f6c1df1
Compare
This was referenced Apr 3, 2026
bdemers
force-pushed
the
feature/filter-visitor-spi
branch
from
11ea545 to
f94b4fd
Compare
bdemers
force-pushed
the
feature/extension-list-refactor
branch
from
f6c1df1 to
d52cbc0
Compare
Extension classes are now passed to the BaseRepository constructor as varargs, removing the need for each subclass to override getExtensionList(). Repositories with no extensions simply omit the parameter (defaults to empty list). Also migrates scim-server and spring-boot test InMemory services from raw Repository to BaseRepository, removing duplicate patch() and getResourceClass() implementations. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bdemers
force-pushed
the
feature/filter-visitor-spi
branch
from
f94b4fd to
45f1a2b
Compare
bdemers
force-pushed
the
feature/extension-list-refactor
branch
from
d52cbc0 to
4a38690
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BaseRepositoryconstructor as varargs, removing the need for each subclass to overridegetExtensionList()scim-serverandspring-boottest InMemory services from rawRepositorytoBaseRepository, removing duplicatepatch()andgetResourceClass()implementationsTest plan
BaseRepositoryTesthas 3 new tests for extension list behavior (default empty, provided extensions, no-arg constructor)mvn clean verifypasses